Skip to content

Commit fb14aa4

Browse files
authored
Prevent diff-features job of test workflow from failing silently (#3116)
* Set `PUPPETEER_SKIP_DOWNLOAD=1` via job env * Enable pipefail to avoid silent errors
1 parent 4582d08 commit fb14aa4

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

.github/workflows/test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ jobs:
6363
concurrency:
6464
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}-diff-features
6565
cancel-in-progress: true
66+
env:
67+
PUPPETEER_SKIP_DOWNLOAD: 1
6668
steps:
6769
- name: Clone collector (base)
6870
uses: actions/checkout@v6
@@ -89,18 +91,20 @@ jobs:
8991
node-version-file: pr/.nvmrc
9092
- name: Install
9193
run: |
92-
PUPPETEER_SKIP_DOWNLOAD=1
94+
set -eo pipefail
9395
cd bcd && npm ci | sed "s/^/[bcd] /" &
9496
cd base && npm ci | sed "s/^/[base] /" &
9597
cd pr && npm ci | sed "s/^/[pr] /" &
9698
wait
9799
- name: Build tests
98100
run: |
101+
set -eo pipefail
99102
cd base && npm run build:tests | sed "s/^/[base] /" &
100103
cd pr && npm run build:tests | sed "s/^/[pr] /" &
101104
wait
102105
- name: Feature coverage
103106
run: |
107+
set -eo pipefail
104108
cd base && npm run feature-coverage -- -l > ../base-features.txt | sed "s/^/[base] /" &
105109
cd pr && npm run feature-coverage -- -l > ../pr-features.txt | sed "s/^/[pr] /" &
106110
wait

0 commit comments

Comments
 (0)