From 605172b4b0250efd4a6a441a94d804c0c6b17358 Mon Sep 17 00:00:00 2001 From: farhan Date: Mon, 5 Oct 2026 12:09:35 +0500 Subject: [PATCH 1/2] fix: run CI once per push to master to avoid coverage race MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit release.yml calls ci.yml via workflow_call on every push to master, so the separate push: trigger in ci.yml fired CI twice concurrently. Both runs raced to upload to the Codecov coverage data branch. Remove the push: trigger from ci.yml; release.yml's workflow_call covers pushes to master already. Also replace the "Version bumped" PR template checklist item with a Conventional Commits reminder — versioning is now automated by python-semantic-release and the manual checkbox is misleading. Co-Authored-By: Claude Sonnet 4.6 --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++-- .github/workflows/ci.yml | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ed62972a..af40b8b0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,9 @@ **Merge checklist:** Check off if complete *or* not applicable: -- [ ] Version bumped -- [ ] Changelog record added +- [ ] Commit messages (and PR title, if squash merging) use the correct + [Conventional Commits](https://www.conventionalcommits.org/) type — they determine the + release: `fix:` → patch, `feat:` → minor, `!` / `BREAKING CHANGE:` → major - [ ] Documentation updated (not only docstrings) - [ ] Fixup commits are squashed away - [ ] Unit tests added/updated diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 61077011..bf53aa14 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,8 +1,6 @@ name: CI on: - push: - branches: [master] pull_request: workflow_dispatch: # Allow this workflow to be called from other workflows From bd327c55415f7a657597b0d992db9a3624dd6ffe Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Wed, 7 Oct 2026 09:58:17 -0400 Subject: [PATCH 2/2] docs: Apply batched suggestions from code review Co-authored-by: Feanil Patel --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index af40b8b0..2d92e8ff 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,7 +2,7 @@ **Merge checklist:** Check off if complete *or* not applicable: - [ ] Commit messages (and PR title, if squash merging) use the correct - [Conventional Commits](https://www.conventionalcommits.org/) type — they determine the + [Conventional Commits](https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0051-bp-conventional-commits.html#specification) type — they determine the release: `fix:` → patch, `feat:` → minor, `!` / `BREAKING CHANGE:` → major - [ ] Documentation updated (not only docstrings) - [ ] Fixup commits are squashed away