Skip to content

Commit ba4bbdd

Browse files
Fix typo and simplify boolean assignment in setup.py
1 parent 4ddfc01 commit ba4bbdd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def main():
1414
os.chdir(os.path.dirname(os.path.abspath(__file__)))
1515

1616
CI_BUILD = os.environ.get("CI_BUILD", "False")
17-
is_CI_build = True if CI_BUILD == "1" else False
17+
is_CI_build = CI_BUILD == "1"
1818
cmake_source_dir = "opencv"
1919
minimum_supported_numpy = "1.13.3"
2020
build_contrib = get_build_env_var_by_name("contrib")
@@ -29,7 +29,7 @@ def main():
2929

3030
python_version = cmaker.CMaker.get_python_version()
3131
python_lib_path = cmaker.CMaker.get_python_library(python_version) or ""
32-
# HACK: For Scikit-build 0.17.3 and newer that returns None or empty sptring for PYTHON_LIBRARY in manylinux2014
32+
# HACK: For Scikit-build 0.17.3 and newer that returns None or empty string for PYTHON_LIBRARY in manylinux2014
3333
# A small release related to PYTHON_LIBRARY handling changes in 0.17.2; scikit-build 0.17.3 returns an empty string from get_python_library if no Python library is present (like on manylinux), where 0.17.2 returned None, and previous versions returned a non-existent path. Note that adding REQUIRED to find_package(PythonLibs will fail, but it is incorrect (you must not link to libPython.so) and was really just injecting a non-existent path before.
3434
# TODO: Remove the hack when the issue is handled correctly in main OpenCV CMake.
3535
if python_lib_path == "":

0 commit comments

Comments
 (0)