Throw on invalid type

Author: mikunn

index.js

@@ -2,6 +2,13 @@ var deepEqual = require('deep-equal');
 
 module.exports = convert;
 
+function InvalidTypeError(message) {
+	this.name = 'InvalidTypeError';
+	this.message = message;
+}
+
+InvalidTypeError.prototype = new Error();
+
 function convert(schema, options) {
 	var notSupported = [
 		'nullable', 'discriminator', 'readOnly',
@@ -78,6 +85,7 @@ function convertSchema(schema, options) {
 
 	}
 
+	validateType(schema.type);
 	schema = convertTypes(schema, options);
 
 	if (typeof schema['x-patternProperties'] === 'object'
@@ -119,6 +127,14 @@ function convertProperties(properties, options) {
 	return props;
 }
 
+function validateType(type) {
+	var validTypes = ['integer', 'number', 'string', 'boolean', 'object', 'array'];
+
+	if (validTypes.indexOf(type) < 0 && type !== undefined) {
+		throw new InvalidTypeError('Type "' + type + '" is not a valid type');
+	}
+}
+
 function convertTypes(schema, options) {
 	var toDateTime = options.dateToDateTime;
 

test/invalid_types.js

@@ -0,0 +1,35 @@
+var test = require('tape')
+	, join = require('path').join
+	, fs = require('fs')
+	, convert = require('../')
+;
+
+test('invalid types', function(assert) {
+	var schema, msg;
+
+	assert.plan(3);
+
+	schema = {
+		type: 'dateTime'
+	};
+
+	msg = 'dateTime is invalid type';
+	assert.throws(function() { convert(schema); }, /InvalidTypeError/, msg);
+
+	schema = {
+		type: 'foo'
+	};
+
+	msg = 'foo is invalid type';
+	assert.throws(function() { convert(schema); }, /InvalidTypeError/, msg);
+
+	schema = getSchema('schema-2-invalid-type.json');
+
+	msg = 'invalid type inside complex schema';
+	assert.throws(function() { convert(schema); }, /InvalidTypeError.*invalidtype/, msg);
+});
+
+function getSchema(file) {
+	var path = join(__dirname, 'schemas', file);
+	return JSON.parse(fs.readFileSync(path));
+}

test/schemas/schema-2-invalid-type.json

@@ -0,0 +1,131 @@
+{
+	"allOf": [
+    {
+      "anyOf": [
+        {
+          "type": "object",
+          "properties": {
+            "cats": {
+              "type": "array",
+              "items": {
+                "type": "integer",
+                "format": "int64",
+                "example": [
+                  1
+                ]
+              }
+            }
+          }
+        },
+        {
+          "type": "object",
+          "properties": {
+            "dogs": {
+              "type": "array",
+              "items": {
+                "type": "integer",
+                "format": "int64",
+                "example": [
+                  1
+                ]
+              }
+            }
+          }
+        },
+        {
+          "type": "object",
+          "properties": {
+            "bring_cats": {
+              "type": "array",
+              "items": {
+                "allOf": [
+                  {
+                    "type": "object",
+                    "properties": {
+                      "email": {
+                        "type": "string",
+                        "example": "cats@email.com"
+                      },
+                      "sms": {
+                        "type": "string",
+                        "nullable": true,
+                        "example": "+12345678"
+                      },
+                      "properties": {
+                        "type": "object",
+                        "additionalProperties": {
+                          "type": "invalidtype"
+                        },
+                        "example": {
+                          "name": "Wookie"
+                        }
+                      }
+                    }
+                  },
+                  {
+                    "required": [
+                      "email"
+                    ]
+                  }
+                ]
+              }
+            }
+          }
+        }
+      ]
+    },
+    {
+      "type": "object",
+      "properties": {
+        "playground": {
+          "type": "object",
+          "required": [
+            "feeling",
+            "child"
+          ],
+          "properties": {
+            "feeling": {
+              "type": "string",
+              "example": "Good feeling"
+            },
+            "child": {
+              "type": "object",
+              "required": [
+                "name",
+                "age"
+              ],
+              "properties": {
+                "name": {
+                  "type": "string",
+                  "example": "Steven"
+                },
+                "age": {
+                  "type": "integer",
+                  "example": 5
+                }
+              }
+            },
+            "toy": {
+              "type": "object",
+              "properties": {
+                "breaks_easily": {
+                  "type": "boolean",
+                  "default": false
+                },
+                "color": {
+                  "type": "string",
+                  "description": "Color of the toy"
+                },
+                "type": {
+                  "type": "string",
+									"enum": ["bucket", "shovel"],
+                  "description": "Toy type"
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  ]
+}