Minor fixes following PR review.

Author: kabalin

.travis.dist.yml

@@ -45,5 +45,6 @@ script:
   - moodle-plugin-ci savepoints
   - moodle-plugin-ci mustache
   - moodle-plugin-ci grunt
+  - moodle-plugin-ci phpdoc
   - moodle-plugin-ci phpunit
   - moodle-plugin-ci behat

docs/CHANGELOG.md

@@ -13,6 +13,9 @@ The format of this change log follows the advice given at [Keep a CHANGELOG](htt
 - Updated [.travis.dist.yml] to install `openjdk-8-jre-headless` instead of
   `oracle-java8-installer` and `oracle-java8-set-default` packages. See
   [#83](https://github.com/blackboard-open-source/moodle-plugin-ci/issues/83) for details.
+- Add `moodle-plugin-ci phpdoc` check which executes
+  [moodlehq/moodle-local_moodlecheck](https://github.com/moodlehq/moodle-local_moodlecheck.git)
+  on the plugin.
 
 ## [2.4.0] - 2018-09-11
 ### Changed

docs/TravisFileExplained.md

@@ -43,8 +43,6 @@ env:
  global:
 # This line determines which version branch of Moodle to test against.
   - MOODLE_BRANCH=MOODLE_35_STABLE
-# Optionally, it is possible to specify a different Moodle repo to use:
-# - MOODLE_REPO=git://github.com/username/moodle.git
 # This matrix is used for testing against multiple databases.  So for
 # each version of PHP being tested, one build will be created for each
 # database listed here.  EG: for PHP 5.6, one build will be created
@@ -54,6 +52,10 @@ env:
   - DB=pgsql
   - DB=mysqli
 
+# Optionally, it is possible to specify a different Moodle repo to use
+# (git://github.com/moodle/moodle.git is used by default):
+# - MOODLE_REPO=git://github.com/username/moodle.git
+
 # This lists steps that are run before the installation step. 
 before_install:
 # This disables XDebug which should speed up the build.

src/Command/PHPDocCommand.php

@@ -12,11 +12,11 @@
 
 namespace MoodlePluginCI\Command;
 
+use MoodlePluginCI\Bridge\MoodlePlugin;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Process\ProcessBuilder;
-use MoodlePluginCI\Bridge\MoodlePlugin;
 
 class PHPDocCommand extends AbstractMoodleCommand
 {
@@ -42,8 +42,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // We need local_moodlecheck plugin to run this check.
         $pluginlocation  = __DIR__.'/../../vendor/moodlehq/moodle-local_moodlecheck';
-        $plugin = new MoodlePlugin($pluginlocation);
-        $directory = $this->moodle->getComponentInstallDirectory($plugin->getComponent());
+        $plugin          = new MoodlePlugin($pluginlocation);
+        $directory       = $this->moodle->getComponentInstallDirectory($plugin->getComponent());
         if (!is_dir($directory)) {
             // Copy plugin into Moodle if it does not exist.
             $filesystem = new Filesystem();
@@ -54,7 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ProcessBuilder::create()
                 ->setPrefix('php')
                 ->add('local/moodlecheck/cli/moodlecheck.php')
-                ->add('-p=' . $this->plugin->directory)
+                ->add('-p='.$this->plugin->directory)
                 ->add('-f=text')
                 ->setTimeout(null)
                 ->setWorkingDirectory($this->moodle->directory)
@@ -69,6 +69,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         // moodlecheck.php does not return valid exit status,
         // We have to parse output to see if there are errors.
         $results = $process->getOutput();
+
         return (preg_match('/\s+Line/', $results)) ? 1 : 0;
     }
 }