From 9fe2253e280d5df1db260dbbe99af3c54d477a58 Mon Sep 17 00:00:00 2001 From: Jon Steinich Date: Thu, 17 Sep 2026 21:18:01 -0500 Subject: [PATCH] Revert "feat(gha): run the affected unit tests against OpenTofu (#439)" This reverts commit 823682df87027d4c52776a93f23d3eb2ff8f734b. The OpenTofu unit job fails on every PR that touches a terraform-tagged project, blocking all CI since the merge. It passed on its own PR vacuously. #439's diff touched only .github/workflows/pr-unit.yml, so `nx affected` resolved to no terraform-tagged projects and the tofu job ran zero tests. The green check proved nothing. Two independent problems surface once it runs for real: 1. Unsigned provider pins OpenTofu rejects - kreuzwerker/docker 2.16.0 in provider-generator's versions-file.test.ts and 3.0.2 in its provider.test.ts. Same class as #301/#429/#436/#440, missed because those pins carry a version inline rather than in a cdktf.json. 2. Snapshots that embed a fully qualified provider name. provider-schema's provider-schema.test.ts snapshot contains "registry.terraform.io/hashicorp/null" under terraform and "registry.opentofu.org/hashicorp/null" under tofu. No single snapshot can satisfy both CLIs, so this is not a pin bump - it needs the host normalized out of the snapshot, per-CLI snapshots, or those tests excluded from the tofu run. Reverting to unblock, rather than fixing forward, because (2) needs a decision rather than a patch. Re-landing should keep the axis red on its own PR until the fixtures are clean - a change to pr-unit.yml alone cannot demonstrate that. Co-Authored-By: Claude Opus 5 --- .github/workflows/pr-unit.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pr-unit.yml b/.github/workflows/pr-unit.yml index ad8794115..260aded4a 100644 --- a/.github/workflows/pr-unit.yml +++ b/.github/workflows/pr-unit.yml @@ -106,8 +106,6 @@ jobs: terraform_binary: terraform1.16.1 - terraform_version: "1.5.7" terraform_binary: terraform1.5.7 - - terraform_version: "1.12.6" - terraform_binary: tofu1.12.6 steps: - name: Checkout uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 @@ -146,7 +144,7 @@ jobs: uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: ${{ steps.global-cache-dir-path.outputs.providerSchema }} - key: providerSchema-${{ runner.os }}-${{ matrix.terraform_binary }}-unit-affected + key: providerSchema-${{ runner.os }}-${{ matrix.terraform_version }}-unit-affected - name: Create TF_PLUGIN_CACHE_DIR if set run: |