[FIX] account_edi_ubl_cii: fix FacturX validation issues

Issue:
There are several issues with the XML of FacturX.

Steps to reproduce:
- Create a partner with a direct debit mandate
- In the Accounting tab of the partner select "FacturX" as eInvoice format
- Create an invoice with this partner, pay with SDD, confirm
- Send to FacturX
- Verify the PDF with https://www.portinvoice.com/
	- Missing namespace
- In the XML the code for the payment means does not adapt to the payment method: 42 (Payment to bank account) and not 59 (SDD)

Cause:
- The namespaces are not there (It's not mandatory).
- We always input "42" as payment mean

Solution:
- Added namespace `xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100"` and `xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"`
- Added the code "59" for SDD, as a lot of codes could be added we add a dictionnary that could be used to add codes. This commit only handles the SDD code

opw-4907827

closes odoo#219799

X-original-commit: 17a1fc4
Signed-off-by: Paolo Gatti (pgi) <pgi@odoo.com>
Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>

Author: mathcoutant

addons/account_edi_ubl_cii/data/cii_22_templates.xml

@@ -5,7 +5,9 @@
             <t t-set="line" t-value="line_vals['line']"/>
             <t  xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100"
                 xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100"
-                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100">
+                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100"
+                xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100"
+                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
 
                 <ram:IncludedSupplyChainTradeLineItem>
                     <!-- Line number. -->
@@ -101,7 +103,9 @@
         <template id="account_invoice_partner_facturx_export_22">
             <t  xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100"
                 xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100"
-                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100">
+                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100"
+                xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100"
+                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                 <!-- Contact. -->
                 <ram:Name t-out="partner.display_name"/>
                 <ram:SpecifiedLegalOrganization t-if="specified_legal_organization_val">
@@ -127,7 +131,9 @@
         <template id="account_invoice_address_facturx_export_22">
             <t  xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100"
                 xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100"
-                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100">
+                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100"
+                xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100"
+                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                 <!-- Address. -->
                 <ram:PostalTradeAddress>
                     <ram:PostcodeCode t-out="partner.zip"/>
@@ -144,7 +150,9 @@
             <rsm:CrossIndustryInvoice
                 xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100"
                 xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100"
-                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100">
+                xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100"
+                xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100"
+                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                 <!-- Factur-x level:
                     * minimum or basicwl:   urn:factur-x.eu:1p0...
                     * basic:                urn:cen.eu:en16931:2017:compliant:factur-x.eu:1p0:basic
@@ -243,7 +251,7 @@
 
                         <!-- Bank account. -->
                         <ram:SpecifiedTradeSettlementPaymentMeans t-if="record.partner_bank_id.sanitized_acc_number">
-                            <ram:TypeCode>42</ram:TypeCode>
+                            <ram:TypeCode t-out="payment_means_code"/>
                             <ram:PayeePartyCreditorFinancialAccount>
                                 <ram:IBANID
                                     t-if="record.partner_bank_id.acc_type == 'iban'"

addons/account_edi_ubl_cii/models/account_edi_xml_cii_facturx.py

@@ -15,6 +15,12 @@
     'udt': "urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100",
 }
 
+# Imcomplete, full list on https://service.unece.org/trade/untdid/d16b/tred/tred4461.htm
+PAYMENT_MEAN_CODES = {
+    'Payment to bank account': 42,
+    'SEPA direct debit': 59
+}
+
 
 class AccountEdiXmlCii(models.AbstractModel):
     _name = 'account.edi.xml.cii'
@@ -238,6 +244,11 @@ def grouping_key_generator(base_line, tax_data):
         template_values['tax_basis_total_amount'] = tax_details['base_amount_currency']
         template_values['tax_total_amount'] = tax_details['tax_amount_currency']
 
+        if self.env['account.payment']._fields.get('sdd_mandate_id') and invoice.matched_payment_ids.sdd_mandate_id:
+            template_values['payment_means_code'] = PAYMENT_MEAN_CODES['SEPA direct debit']
+        else:
+            template_values['payment_means_code'] = PAYMENT_MEAN_CODES['Payment to bank account']
+
         return template_values
 
     def _export_invoice(self, invoice):

addons/account_edi_ubl_cii/tests/test_ubl_cii.py

@@ -35,7 +35,9 @@ def setUpClass(cls):
         cls.namespaces = {
             'rsm': "urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100",
             'ram': "urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100",
-            'udt': "urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100"
+            'udt': "urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100",
+            'qdt': "urn:un:unece:uncefact:data:standard:QualifiedDataType:100",
+            'xsi': "http://www.w3.org/2001/XMLSchema-instance",
         }
 
     def import_attachment(self, attachment, journal=None):
@@ -416,3 +418,68 @@ def test_import_discount(self):
         imported_invoice = self.import_attachment(xml_attachment, self.company_data["default_journal_sale"])
         for line in imported_invoice.invoice_line_ids:
             self.assertFalse(line.discount, "A discount on the imported lines signals a rounding error in the discount computation")
+
+    def test_payment_means_code_in_facturx_xml(self):
+        bank_ing = self.env['res.bank'].create({'name': 'ING', 'bic': 'BBRUBEBB'})
+        partner_bank = self.env['res.partner.bank'].create({
+                'acc_number': 'BE15001559627230',
+                'partner_id': self.partner_a.id,
+                'bank_id': bank_ing.id,
+                'company_id': self.env.company.id,
+            })
+        invoice = self.env['account.move'].create({
+            'partner_id': self.partner_a.id,
+            'move_type': 'out_invoice',
+            'invoice_line_ids': [Command.create({'product_id': self.product_a.id})],
+            'delivery_date': "2024-12-31",
+            'partner_bank_id': partner_bank.id,
+        })
+        invoice.action_post()
+
+        xml_attachment = self.env['ir.attachment'].create({
+            'raw': self.env['account.edi.xml.cii']._export_invoice(invoice)[0],
+            'name': 'test_invoice.xml',
+        })
+        xml_tree = etree.fromstring(xml_attachment.raw)
+        code = xml_tree.find('.//ram:SpecifiedTradeSettlementPaymentMeans/ram:TypeCode', self.namespaces)
+        self.assertEqual(code.text, '42')
+
+        if self.env['ir.module.module']._get('account_sepa_direct_debit').state == 'installed':
+            company = self.env.company
+            company.sdd_creditor_identifier = 'BE30ZZZ300D000000042'
+            company_bank_journal = self.company_data['default_journal_bank']
+            company_bank_journal.bank_acc_number = 'CH9300762011623852957'
+            company_bank_journal.bank_account_id.bank_id = bank_ing
+            self.partner_a.country_id = self.env.ref('base.nl').id
+
+            mandate = self.env['sdd.mandate'].create({
+                'name': 'mandate ' + (self.partner_a.name or ''),
+                'partner_bank_id': partner_bank.id,
+                'one_off': True,
+                'start_date': fields.Date.today(),
+                'partner_id': self.partner_a.id,
+                'company_id': company.id,
+            })
+            mandate.action_validate_mandate()
+            invoice = self.env['account.move'].create({
+                'partner_id': self.partner_a.id,
+                'move_type': 'out_invoice',
+                'invoice_line_ids': [Command.create({'product_id': self.product_a.id})],
+                'delivery_date': "2024-12-31",
+            })
+            invoice.action_post()
+            sdd_method_line = company_bank_journal.inbound_payment_method_line_ids.filtered(lambda l: l.code == 'sdd')
+            sdd_method_line.payment_account_id = self.inbound_payment_method_line.payment_account_id
+            self.env['account.payment.register'].with_context(active_model='account.move', active_ids=invoice.ids).create({
+                'payment_date': invoice.invoice_date,
+                'journal_id': company_bank_journal.id,
+                'payment_method_line_id': sdd_method_line.id,
+            })._create_payments()
+
+            xml_attachment = self.env['ir.attachment'].create({
+                'raw': self.env['account.edi.xml.cii']._export_invoice(invoice)[0],
+                'name': 'test_invoice.xml',
+            })
+            xml_tree = etree.fromstring(xml_attachment.raw)
+            code = xml_tree.find('.//ram:SpecifiedTradeSettlementPaymentMeans/ram:TypeCode', self.namespaces)
+            self.assertEqual(code.text, '59')