From ad2e88f2173f6d7bd5da5f8d5dc2ad40f09da111 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 25 Oct 2026 13:29:54 +0000 Subject: [PATCH] docs(patches): link the radix focus-scope patch to its upstream issue (objectui#13466) Stock @radix-ui/react-focus-scope 1.3.1 still fails the race case of dialog-popover-focus-scope.test.tsx with the patch removed (1 failed / 2 passed, measured 2026-10-25), so the patch stays. The README now names the upstream issue radix-ui/primitives#4226, records the measurement, and replaces the exit condition with one an outside event can trigger. Refs objectui#13466 Co-authored-by: Claude Claude-Session: https://claude.ai/code/session_0196W5VLn6ZrtibyAZrR8oiK --- patches/README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/patches/README.md b/patches/README.md index 7d1ee26c1c..a66e9b2694 100644 --- a/patches/README.md +++ b/patches/README.md @@ -25,8 +25,10 @@ its `patchedDependencies` entry, and re-run `pnpm install`. | | | |---|---| | Package | `@radix-ui/react-focus-scope@1.1.16` | -| Tracking | objectui#3183 | -| Remove when | upstream `radix-ui/primitives` cancels the pending stack eviction on an effect re-run | +| Tracking | objectui#3183, objectui#13466 | +| Upstream | [radix-ui/primitives#4226](https://github.com/radix-ui/primitives/issues/4226) (same root cause, Suspense trigger); related, closed: [radix-ui/primitives#4148](https://github.com/radix-ui/primitives/issues/4148) | +| Last measured | 2026-10-25: stock `1.3.1` with the patch removed fails the race case (1 failed / 2 passed) | +| Remove when | radix-ui/primitives#4226 is fixed in a released `@radix-ui/react-focus-scope` and the regression test below is green on that release with this patch removed | `FocusScope`'s stack effect schedules `focusScopesStack.remove(scope)` inside a `setTimeout(0)` cleanup. When the effect re-runs for a **still-mounted** scope (a