From ac17a0f91102e99d6b48edb99bc3696d532d859b Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Thu, 15 Oct 2026 23:10:45 +0000
Subject: [PATCH 1/3] feat(app-shell): Publish opens the pending-changes sheet
 to confirm, Changes to review

DraftChangesPanel takes a `posture` prop. `confirm` expands every row
once the list arrives, puts a per-type summary line above it and moves
focus to Publish all; `review` (the default) keeps rows collapsed and
focus on the list. The Studio's Publish passes `confirm`, its Changes
button `review`; every other host passes nothing and keeps reviewing.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
---
 .changeset/12517-publish-confirm-posture.md   |  13 ++
 .../src/preview/DraftChangesPanel.tsx         |  68 ++++++-
 .../DraftChangesPanel.posture-12517.test.tsx  | 142 +++++++++++++
 ...esignSurface.publishPosture-12517.test.tsx | 186 ++++++++++++++++++
 .../studio-design/StudioDesignSurface.tsx     |  19 +-
 packages/i18n/src/locales/ar.ts               |   8 +
 packages/i18n/src/locales/de.ts               |   4 +
 packages/i18n/src/locales/en.ts               |   6 +
 packages/i18n/src/locales/es.ts               |   5 +
 packages/i18n/src/locales/fr.ts               |   5 +
 packages/i18n/src/locales/ja.ts               |   4 +
 packages/i18n/src/locales/ko.ts               |   4 +
 packages/i18n/src/locales/pt.ts               |   5 +
 packages/i18n/src/locales/ru.ts               |   6 +
 packages/i18n/src/locales/zh.ts               |   4 +
 15 files changed, 474 insertions(+), 5 deletions(-)
 create mode 100644 .changeset/12517-publish-confirm-posture.md
 create mode 100644 packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
 create mode 100644 packages/app-shell/src/views/studio-design/StudioDesignSurface.publishPosture-12517.test.tsx

diff --git a/.changeset/12517-publish-confirm-posture.md b/.changeset/12517-publish-confirm-posture.md
new file mode 100644
index 0000000000..08de00b47c
--- /dev/null
+++ b/.changeset/12517-publish-confirm-posture.md
@@ -0,0 +1,13 @@
+---
+'@object-ui/app-shell': minor
+'@object-ui/i18n': minor
+---
+
+The Studio's Publish and Changes buttons no longer open the pending-changes sheet the same way.
+
+- **Publish opens it to confirm.** Every pending item is expanded, so the fields and keys each one adds, changes or removes are on screen. A summary line above the list counts what the publish carries, by type (for example "3 items · 1 object · 1 app · 1 page"). Focus lands on Publish all. The header button still publishes nothing by itself; only Publish all in the sheet does.
+- **Changes opens it to review.** Items stay collapsed and focus lands on the list. Publish all is still in the footer, unfocused.
+
+Every other place that opens the sheet (the Home page, the draft preview bar and the history timeline) keeps the review behaviour. With nothing pending, Publish stays disabled and says why, as before.
+
+New language-pack keys under `preview.changes`: `summaryItems` (with its plural forms) and `summaryType`, in every shipped locale.
diff --git a/packages/app-shell/src/preview/DraftChangesPanel.tsx b/packages/app-shell/src/preview/DraftChangesPanel.tsx
index 889646a653..f6af034fc7 100644
--- a/packages/app-shell/src/preview/DraftChangesPanel.tsx
+++ b/packages/app-shell/src/preview/DraftChangesPanel.tsx
@@ -471,8 +471,20 @@ export interface DraftChangesPanelProps {
   onPublish?: () => void | Promise<void>;
   /** Disables the confirm button and shows a spinner while the caller publishes. */
   publishing?: boolean;
+  /**
+   * How the sheet opens (objectui#12517). `review` — the default, and what
+   * every host but the Studio's Publish gets: rows collapsed, focus on the
+   * list. `confirm` — the host's Publish opened it: every row expanded to
+   * show what changes, a per-type summary line above the list, and focus on
+   * the footer's Publish all once it renders. Read on each open; a posture
+   * never changes what the footer button does (objectui#2261: only it
+   * publishes).
+   */
+  posture?: DraftChangesPosture;
 }
 
+export type DraftChangesPosture = 'review' | 'confirm';
+
 export function DraftChangesPanel({
   open,
   onOpenChange,
@@ -480,6 +492,7 @@ export function DraftChangesPanel({
   include,
   onPublish,
   publishing = false,
+  posture = 'review',
 }: DraftChangesPanelProps) {
   const { t, language } = useObjectTranslation();
   const [entries, setEntries] = useState<DraftChangeEntry[] | null>(null);
@@ -514,6 +527,36 @@ export function DraftChangesPanel({
     });
   }, []);
 
+  /**
+   * objectui#12517 — the posture's two openings. Each open starts collapsed;
+   * the confirm posture expands every row ONCE, when the list first arrives,
+   * so a row the author then collapses stays collapsed while the type reads
+   * below re-map the entries. Focus lands on the list at open (the Publish
+   * all button does not exist until the list loads) and moves to Publish all
+   * on that same arrival — only if the author has not moved it meanwhile.
+   */
+  const listRef = useRef<HTMLDivElement>(null);
+  const publishRef = useRef<HTMLButtonElement>(null);
+  const settledRef = useRef(false);
+  // The list as it stood when the sheet opened: the previous open's, until
+  // this open's load replaces it. Only a list newer than that one settles.
+  const entriesAtOpenRef = useRef<DraftChangeEntry[] | null>(null);
+  useEffect(() => {
+    if (!open) return;
+    settledRef.current = false;
+    entriesAtOpenRef.current = entries;
+    setExpanded(new Set());
+    // Keyed on the open transition alone: `entries` is read, not watched.
+  }, [open]);
+  useEffect(() => {
+    if (!open || settledRef.current || entries === null || entries === entriesAtOpenRef.current) return;
+    settledRef.current = true;
+    if (posture !== 'confirm') return;
+    setExpanded(new Set(entries.map(entryKey)));
+    const button = publishRef.current;
+    if (button && document.activeElement === listRef.current) button.focus();
+  }, [open, posture, entries]);
+
   const markCompared = (key: string, isUnchanged: boolean) => {
     setUnchanged((prev) => {
       if (prev.has(key) === isUnchanged) return prev;
@@ -652,6 +695,13 @@ export function DraftChangesPanel({
         side="right"
         className="flex w-[420px] flex-col sm:max-w-[420px]"
         data-testid="draft-changes-panel"
+        data-posture={posture}
+        onOpenAutoFocus={(event) => {
+          // objectui#12517 — the list, not the first tabbable (the close
+          // button): see the posture effect above for where focus goes next.
+          event.preventDefault();
+          listRef.current?.focus();
+        }}
       >
         <SheetHeader>
           <SheetTitle>
@@ -663,9 +713,24 @@ export function DraftChangesPanel({
             })}
           </SheetDescription>
         </SheetHeader>
+        {posture === 'confirm' && entries && entries.length > 0 && !error ? (
+          // objectui#12517 — what the publish carries, counted off the same
+          // per-type grouping the headings below read.
+          <p data-testid="draft-changes-summary" className="mt-3 px-4 text-xs font-medium text-foreground">
+            {[
+              t('preview.changes.summaryItems', { count: entries.length, defaultValue: '{{count}} items' }),
+              ...[...byType.entries()].map(([type, items]) =>
+                t('preview.changes.summaryType', { n: items.length, type, defaultValue: '{{n}} {{type}}' }),
+              ),
+            ].join(' · ')}
+          </p>
+        ) : null}
         <div
+          ref={listRef}
+          tabIndex={-1}
+          aria-label={t('preview.changes.title', { defaultValue: 'Pending changes' })}
           data-testid="draft-changes-list"
-          className="mt-4 flex min-h-0 flex-1 flex-col gap-4 overflow-y-auto px-4 pb-6"
+          className="mt-4 flex min-h-0 flex-1 flex-col gap-4 overflow-y-auto px-4 pb-6 outline-none"
         >
           {error ? (
             <p className="text-sm text-destructive">
@@ -854,6 +919,7 @@ export function DraftChangesPanel({
                   })}
             </p>
             <Button
+              ref={publishRef}
               size="sm"
               onClick={() => void onPublish()}
               disabled={publishing}
diff --git a/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx b/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
new file mode 100644
index 0000000000..a67e95b769
--- /dev/null
+++ b/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
@@ -0,0 +1,142 @@
+/**
+ * ObjectUI
+ * Copyright (c) 2024-present ObjectStack Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+/**
+ * objectui#12517 — the pending-changes sheet opens in one of two postures.
+ *
+ * `confirm` (the Studio's Publish): every row expanded, a per-type summary
+ * line above the list, focus on the footer's Publish all. `review` (the
+ * Studio's Changes, and the default every other host gets): rows collapsed,
+ * focus on the list, the footer button present but not focused, no summary.
+ *
+ * The CONTROL is the mount the Home page, `DraftPreviewBar` and
+ * `CommitTimeline` use: no `posture` prop at all. It must read exactly as the
+ * review posture does.
+ */
+
+import '@testing-library/jest-dom/vitest';
+import * as React from 'react';
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import { act, cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
+
+vi.mock('@object-ui/i18n', async (importOriginal) => ({
+  ...(await importOriginal<Record<string, unknown>>()),
+  useObjectTranslation: () => ({
+    // Interpolating, so the summary line reads as an author would see it.
+    t: (_k: string, o?: Record<string, unknown> & { defaultValue?: string }) =>
+      (o?.defaultValue ?? _k).replace(/\{\{(\w+)\}\}/g, (_m, name: string) => String(o?.[name] ?? '')),
+    language: 'en',
+  }),
+}));
+
+import { DraftChangesPanel, type DraftChangesPosture } from '../DraftChangesPanel';
+
+// Three drafts of two types: the summary line has something to count.
+const DRAFT_ROWS = [
+  { type: 'object', name: 'st_ticket', packageId: 'com.x', label: 'Ticket' },
+  { type: 'object', name: 'st_queue', packageId: 'com.x', label: 'Queue' },
+  { type: 'page', name: 'st_home', packageId: 'com.x', label: 'Home' },
+];
+
+const fetchMock = vi.fn(async (input: RequestInfo | URL) => {
+  const url = String(input);
+  const ok = (body: unknown) => ({ ok: true, status: 200, json: async () => body });
+  if (url.includes('/_drafts')) return ok({ drafts: DRAFT_ROWS });
+  if (/\/meta\/object(\?|$)/.test(url)) return ok([{ name: 'st_queue' }]);
+  if (/\/meta\/page(\?|$)/.test(url)) return ok([]);
+  if (url.includes('state=draft')) return ok({ name: 'x', label: 'Draft label' });
+  return { ok: false, status: 404, json: async () => ({}) };
+});
+
+afterEach(() => {
+  cleanup();
+  vi.unstubAllGlobals();
+  fetchMock.mockClear();
+});
+
+function Host({ posture, open = true }: { posture?: DraftChangesPosture; open?: boolean }) {
+  return (
+    <DraftChangesPanel
+      open={open}
+      onOpenChange={() => {}}
+      packageId="com.x"
+      onPublish={() => {}}
+      {...(posture ? { posture } : {})}
+    />
+  );
+}
+
+async function renderHost(posture?: DraftChangesPosture) {
+  vi.stubGlobal('fetch', fetchMock as unknown as typeof fetch);
+  const utils = render(<Host posture={posture} />);
+  // Every row classified: each badge has replaced its spinner.
+  await waitFor(() => expect(screen.getAllByText(/^(New|Update)$/)).toHaveLength(DRAFT_ROWS.length));
+  return utils;
+}
+
+const toggles = () => screen.getAllByTestId('draft-entry-toggle');
+
+function expectReviewPosture() {
+  for (const toggle of toggles()) expect(toggle).toHaveAttribute('aria-expanded', 'false');
+  expect(screen.queryAllByTestId('draft-entry-detail')).toHaveLength(0);
+  expect(screen.getByTestId('draft-changes-list')).toHaveFocus();
+  // The footer is there — review never hides the way to publish — but unfocused.
+  const publish = screen.getByTestId('draft-changes-publish');
+  expect(publish).toBeInTheDocument();
+  expect(publish).not.toHaveFocus();
+  expect(screen.queryByTestId('draft-changes-summary')).toBeNull();
+}
+
+describe('objectui#12517 — the pending-changes sheet opens in a posture', () => {
+  it('confirm: every row expanded, the summary line counted by type, focus on Publish all', async () => {
+    await renderHost('confirm');
+    expect(screen.getByTestId('draft-changes-panel')).toHaveAttribute('data-posture', 'confirm');
+    for (const toggle of toggles()) expect(toggle).toHaveAttribute('aria-expanded', 'true');
+    await waitFor(() => expect(screen.getAllByTestId('draft-entry-detail')).toHaveLength(DRAFT_ROWS.length));
+    expect(screen.getByTestId('draft-changes-publish')).toHaveFocus();
+    expect(screen.getByTestId('draft-changes-summary')).toHaveTextContent(/^3 items · 2 object · 1 page$/);
+  });
+
+  it('review: rows collapsed, focus on the list, Publish all present but not focused', async () => {
+    await renderHost('review');
+    expect(screen.getByTestId('draft-changes-panel')).toHaveAttribute('data-posture', 'review');
+    expectReviewPosture();
+  });
+
+  it('CONTROL: a host that passes no posture (Home, DraftPreviewBar, CommitTimeline) gets review', async () => {
+    await renderHost(undefined);
+    expect(screen.getByTestId('draft-changes-panel')).toHaveAttribute('data-posture', 'review');
+    expectReviewPosture();
+  });
+
+  it('confirm: a row the author collapses stays collapsed while the rows classify', async () => {
+    vi.stubGlobal('fetch', fetchMock as unknown as typeof fetch);
+    render(<Host posture="confirm" />);
+    await waitFor(() => expect(toggles()).toHaveLength(DRAFT_ROWS.length));
+    await waitFor(() => expect(toggles()[0]).toHaveAttribute('aria-expanded', 'true'));
+    fireEvent.click(toggles()[0]);
+    await waitFor(() => expect(screen.getAllByText(/^(New|Update)$/)).toHaveLength(DRAFT_ROWS.length));
+    expect(toggles()[0]).toHaveAttribute('aria-expanded', 'false');
+    expect(toggles()[1]).toHaveAttribute('aria-expanded', 'true');
+  });
+
+  it('the posture is read on each open: Publish then Changes opens collapsed the second time', async () => {
+    vi.stubGlobal('fetch', fetchMock as unknown as typeof fetch);
+    const { rerender } = render(<Host posture="confirm" />);
+    await waitFor(() => expect(screen.getByTestId('draft-changes-publish')).toHaveFocus());
+    for (const toggle of toggles()) expect(toggle).toHaveAttribute('aria-expanded', 'true');
+
+    rerender(<Host posture="confirm" open={false} />);
+    await waitFor(() => expect(screen.queryByTestId('draft-changes-panel')).toBeNull());
+    await act(async () => {
+      rerender(<Host posture="review" />);
+    });
+    await waitFor(() => expect(screen.getAllByText(/^(New|Update)$/)).toHaveLength(DRAFT_ROWS.length));
+    expectReviewPosture();
+  });
+});
diff --git a/packages/app-shell/src/views/studio-design/StudioDesignSurface.publishPosture-12517.test.tsx b/packages/app-shell/src/views/studio-design/StudioDesignSurface.publishPosture-12517.test.tsx
new file mode 100644
index 0000000000..f7787ee8a6
--- /dev/null
+++ b/packages/app-shell/src/views/studio-design/StudioDesignSurface.publishPosture-12517.test.tsx
@@ -0,0 +1,186 @@
+// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
+
+/**
+ * objectui#12517 — the shell header's two doors into the one pending-changes
+ * sheet open it in two postures: Publish opens it to confirm, Changes opens it
+ * to review. One sheet, one component; the host only says which door was used.
+ *
+ * Publish stays review-then-confirm (objectui#2261): the header click opens the
+ * sheet and publishes nothing; only the sheet's footer button does. With
+ * nothing pending, Publish stays disabled and described by
+ * `publish-none-reason` (objectui#12303).
+ *
+ * Real: the surface, `useMetadataClient` and `usePendingDrafts`. Stubbed:
+ * `globalThis.fetch`, `packages-io`'s package list, `sonner`, the dock and
+ * panels no assertion reads, and `DraftChangesPanel`, replaced by a probe that
+ * prints the props the surface mounts it with (the panel's own postures are
+ * pinned by `DraftChangesPanel.posture-12517.test.tsx`).
+ */
+
+import '@testing-library/jest-dom/vitest';
+import * as React from 'react';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
+import { MemoryRouter, Route, Routes } from 'react-router-dom';
+
+const PACKAGE_ID = 'app.a';
+const DRAFTS = `/api/v1/meta/_drafts?packageId=${PACKAGE_ID}`;
+
+vi.mock('sonner', () => ({
+  toast: {
+    warning: vi.fn(),
+    error: vi.fn(),
+    success: vi.fn(),
+    info: vi.fn(),
+    message: vi.fn(),
+    dismiss: vi.fn(),
+  },
+  Toaster: () => null,
+}));
+
+vi.mock('./packages-io', async (importOriginal) => {
+  const actual = await importOriginal<Record<string, unknown>>();
+  return {
+    ...actual,
+    fetchPackages: vi.fn(async () => [{ id: PACKAGE_ID, name: PACKAGE_ID, writable: true, namespace: 'a' }]),
+  };
+});
+
+vi.mock('@object-ui/react', async (importOriginal) => {
+  const actual = await importOriginal<Record<string, unknown>>();
+  return { ...actual, useAdapter: () => ({}) };
+});
+
+vi.mock('../../components/SuggestedBindingsPanel', () => ({ SuggestedBindingsPanel: () => null }));
+vi.mock('../metadata-admin/AccessExplainPanel', () => ({ AccessExplainPanel: () => null }));
+vi.mock('./StudioAiCopilot', () => ({ StudioChatDock: () => null }));
+vi.mock('../../preview/DraftChangesPanel', () => ({
+  DraftChangesPanel: (props: { open: boolean; posture?: string; onPublish?: unknown }) =>
+    props.open ? (
+      <div
+        data-testid="probe-changes-panel"
+        data-posture={props.posture ?? 'none'}
+        data-can-publish={String(typeof props.onPublish === 'function')}
+      />
+    ) : null,
+}));
+
+import { StudioDesignSurface } from './StudioDesignSurface';
+import { t } from '../metadata-admin/i18n';
+
+window.matchMedia = ((query: string) => ({
+  matches: false,
+  media: query,
+  onchange: null,
+  addEventListener: () => {},
+  removeEventListener: () => {},
+  addListener: () => {},
+  removeListener: () => {},
+  dispatchEvent: () => false,
+})) as unknown as typeof window.matchMedia;
+(globalThis as unknown as { ResizeObserver: unknown }).ResizeObserver =
+  (globalThis as unknown as { ResizeObserver?: unknown }).ResizeObserver ??
+  class {
+    observe() {}
+    unobserve() {}
+    disconnect() {}
+  };
+
+let pending: Array<Record<string, unknown>> = [];
+/** Every request the surface sent that is not a read. */
+const writes: string[] = [];
+
+function json(body: unknown) {
+  return new Response(JSON.stringify(body), { status: 200, headers: { 'content-type': 'application/json' } });
+}
+
+beforeEach(() => {
+  writes.length = 0;
+  vi.stubGlobal(
+    'fetch',
+    vi.fn(async (input: unknown, init?: { method?: string }) => {
+      const url = String(input);
+      if (init?.method && init.method !== 'GET') writes.push(`${init.method} ${url}`);
+      if (url === DRAFTS) return json({ drafts: pending });
+      return json([]);
+    }) as unknown as typeof fetch,
+  );
+});
+
+afterEach(() => {
+  cleanup();
+  vi.unstubAllGlobals();
+});
+
+function renderSurface() {
+  render(
+    <MemoryRouter initialEntries={[`/studio/${PACKAGE_ID}/access`]}>
+      <Routes>
+        <Route path="/studio/:packageId/:tab" element={<StudioDesignSurface />} />
+      </Routes>
+    </MemoryRouter>,
+  );
+}
+
+const changesButton = () => screen.getByRole('button', { name: new RegExp(`^${t('engine.studio.changes', 'en')}`) });
+const publishButton = () => screen.getByRole('button', { name: t('engine.studio.publish', 'en') });
+
+describe('objectui#12517 — Publish opens the sheet to confirm, Changes opens it to review', () => {
+  beforeEach(() => {
+    pending = [
+      { type: 'object', name: 'a_ticket', packageId: PACKAGE_ID },
+      { type: 'app', name: 'a_app', packageId: PACKAGE_ID },
+      { type: 'page', name: 'a_home', packageId: PACKAGE_ID },
+    ];
+  });
+
+  it('Publish opens the one sheet in the confirm posture, and publishes nothing by itself', async () => {
+    renderSurface();
+    await waitFor(() => expect(screen.getByTestId('studio-changes-count')).toHaveTextContent('3'));
+    await waitFor(() => expect(publishButton()).toBeEnabled());
+    fireEvent.click(publishButton());
+    const sheet = await screen.findByTestId('probe-changes-panel');
+    expect(sheet).toHaveAttribute('data-posture', 'confirm');
+    expect(sheet).toHaveAttribute('data-can-publish', 'true');
+    expect(screen.getAllByTestId('probe-changes-panel')).toHaveLength(1);
+    // Review-then-confirm (objectui#2261): the header click wrote nothing.
+    expect(writes.filter((w) => w.includes('publish'))).toEqual([]);
+  });
+
+  it('Changes opens the same sheet in the review posture', async () => {
+    renderSurface();
+    await waitFor(() => expect(screen.getByTestId('studio-changes-count')).toHaveTextContent('3'));
+    fireEvent.click(changesButton());
+    const sheet = await screen.findByTestId('probe-changes-panel');
+    expect(sheet).toHaveAttribute('data-posture', 'review');
+    expect(screen.getAllByTestId('probe-changes-panel')).toHaveLength(1);
+  });
+
+  it('each door sets its own posture: Publish, then Changes, reads review the second time', async () => {
+    renderSurface();
+    await waitFor(() => expect(publishButton()).toBeEnabled());
+    fireEvent.click(publishButton());
+    expect(await screen.findByTestId('probe-changes-panel')).toHaveAttribute('data-posture', 'confirm');
+    fireEvent.click(changesButton());
+    await waitFor(() =>
+      expect(screen.getByTestId('probe-changes-panel')).toHaveAttribute('data-posture', 'review'),
+    );
+  });
+});
+
+describe('objectui#12517 keeps objectui#12303 — nothing pending', () => {
+  beforeEach(() => {
+    pending = [];
+  });
+
+  it('Publish stays disabled and described by publish-none-reason; no count pill', async () => {
+    renderSurface();
+    const reason = await screen.findByTestId('publish-none-reason');
+    expect(publishButton()).toBeDisabled();
+    expect(publishButton()).toHaveAttribute('aria-describedby', reason.id);
+    expect(screen.queryByTestId('studio-changes-count')).toBeNull();
+    // Changes still opens the sheet, to review.
+    fireEvent.click(changesButton());
+    expect(await screen.findByTestId('probe-changes-panel')).toHaveAttribute('data-posture', 'review');
+  });
+});
diff --git a/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx b/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx
index 844ff8cf0f..7bd58e0814 100644
--- a/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx
+++ b/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx
@@ -278,7 +278,7 @@ import { ObjectHooksPanel } from './ObjectHooksPanel.js';
 import { ObjectActionsPanel } from './ObjectActionsPanel.js';
 import { getIcon } from '../../utils/getIcon.js';
 import { fetchPackages, prefixObjectName, type PkgEntry } from './packages-io.js';
-import { DraftChangesPanel } from '../../preview/DraftChangesPanel.js';
+import { DraftChangesPanel, type DraftChangesPosture } from '../../preview/DraftChangesPanel.js';
 import { toast } from 'sonner';
 
 // ADR-0057 P3c follow-up (#2477 item 3) — the folded layout's side-by-side
@@ -1202,6 +1202,9 @@ export function StudioDesignSurface({ aiSlot }: StudioDesignSurfaceProps): React
   // one atomic pass (POST /packages/:id/publish-drafts), reviewed as a whole in
   // DraftChangesPanel. There is no per-item publish.
   const [changesOpen, setChangesOpen] = React.useState(false);
+  // objectui#12517 — which trigger opened the sheet: Publish opens it to
+  // confirm (rows expanded, focus on Publish all), Changes opens it to review.
+  const [changesPosture, setChangesPosture] = React.useState<DraftChangesPosture>('review');
   const [publishing, setPublishing] = React.useState(false);
   const [publishNonce, setPublishNonce] = React.useState(0); // ↑ → pillars re-read the published baseline
   const [draftNonce, setDraftNonce] = React.useState(0); // ↑ → a draft save landed (`onDraftSaved`)
@@ -1578,8 +1581,12 @@ export function StudioDesignSurface({ aiSlot }: StudioDesignSurfaceProps): React
       type="button"
       // Publish is review-then-confirm: open the pending-changes panel,
       // whose footer button fires the actual atomic package publish —
-      // never straight from this header click (objectui#2261).
-      onClick={() => setChangesOpen(true)}
+      // never straight from this header click (objectui#2261). It opens the
+      // panel in its confirm posture (objectui#12517).
+      onClick={() => {
+        setChangesPosture('confirm');
+        setChangesOpen(true);
+      }}
       disabled={publishing || !hasPending || readOnly}
       aria-describedby={
         readOnly
@@ -1710,7 +1717,10 @@ export function StudioDesignSurface({ aiSlot }: StudioDesignSurfaceProps): React
               {/* objectui#12459 — the pending count is a pill, not "· N" text. */}
               <button
                 type="button"
-                onClick={() => setChangesOpen(true)}
+                onClick={() => {
+                  setChangesPosture('review');
+                  setChangesOpen(true);
+                }}
                 className="inline-flex h-8 items-center gap-1.5 rounded-md border px-2.5 text-[13px] text-foreground hover:bg-muted"
               >
                 <GitBranch className="h-3.5 w-3.5 text-muted-foreground" />
@@ -1886,6 +1896,7 @@ export function StudioDesignSurface({ aiSlot }: StudioDesignSurfaceProps): React
           include={packageId === null ? isOrgScopeDraft : undefined}
           onPublish={readOnly ? undefined : doPublish}
           publishing={publishing}
+          posture={changesPosture}
         />
 
         <CreateItemDialog
diff --git a/packages/i18n/src/locales/ar.ts b/packages/i18n/src/locales/ar.ts
index 9092df3a38..085f427269 100644
--- a/packages/i18n/src/locales/ar.ts
+++ b/packages/i18n/src/locales/ar.ts
@@ -4233,6 +4233,14 @@ const ar = {
       confirmNoteSeparate_many: 'النشر يُصدر المسودات المعلقة ({{count}}) كلًّا على حدة: المسودة التي يتعذّر نشرها تبقى معلقة، وتُنشر البقية.',
       confirmNoteSeparate_other: 'النشر يُصدر المسودات المعلقة ({{count}}) كلًّا على حدة: المسودة التي يتعذّر نشرها تبقى معلقة، وتُنشر البقية.',
       publishConfirm: 'نشر الكل',
+      summaryItems: '{{count}} عنصر',
+      summaryItems_zero: '{{count}} عنصر',
+      summaryItems_one: 'عنصر واحد ({{count}})',
+      summaryItems_two: 'عنصران ({{count}})',
+      summaryItems_few: '{{count}} عناصر',
+      summaryItems_many: '{{count}} عنصرًا',
+      summaryItems_other: '{{count}} عنصر',
+      summaryType: '{{type}} {{n}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/de.ts b/packages/i18n/src/locales/de.ts
index 7cae908fd5..041d4a2286 100644
--- a/packages/i18n/src/locales/de.ts
+++ b/packages/i18n/src/locales/de.ts
@@ -3894,6 +3894,10 @@ const de = {
       confirmNoteSeparate_one: 'Beim Veröffentlichen wird der {{count}} ausstehende Entwurf für sich allein freigegeben: Scheitert er, bleibt er ausstehend.',
       confirmNoteSeparate_other: 'Beim Veröffentlichen werden die {{count}} ausstehenden Entwürfe einzeln freigegeben: Ein Entwurf, der dabei scheitert, bleibt ausstehend, die übrigen werden trotzdem freigegeben.',
       publishConfirm: 'Alle veröffentlichen',
+      summaryItems: '{{count}} Elemente',
+      summaryItems_one: '{{count}} Element',
+      summaryItems_other: '{{count}} Elemente',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/en.ts b/packages/i18n/src/locales/en.ts
index 494cbc38d4..ded59d1d35 100644
--- a/packages/i18n/src/locales/en.ts
+++ b/packages/i18n/src/locales/en.ts
@@ -3377,6 +3377,12 @@ const en = {
       confirmNoteSeparate_one: 'Publishing releases the {{count}} pending draft on its own: if it fails, it stays pending.',
       confirmNoteSeparate_other: 'Publishing releases the {{count}} pending drafts one at a time: a draft that fails stays pending while the others go live.',
       publishConfirm: 'Publish all',
+      // objectui#12517 — the confirm posture's summary line above the list:
+      // the item count, then one `{{n}} {{type}}` per type group.
+      summaryItems: '{{count}} items',
+      summaryItems_one: '{{count}} item',
+      summaryItems_other: '{{count}} items',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/es.ts b/packages/i18n/src/locales/es.ts
index 8d53f8cd0b..efbaeaaba5 100644
--- a/packages/i18n/src/locales/es.ts
+++ b/packages/i18n/src/locales/es.ts
@@ -3977,6 +3977,11 @@ const es = {
       confirmNoteSeparate_many: 'Publicar libera los {{count}} de borradores pendientes uno por uno: el que falle sigue pendiente y los demás se publican igualmente.',
       confirmNoteSeparate_other: 'Publicar libera los {{count}} borradores pendientes uno por uno: el que falle sigue pendiente y los demás se publican igualmente.',
       publishConfirm: 'Publicar todo',
+      summaryItems: '{{count}} elementos',
+      summaryItems_one: '{{count}} elemento',
+      summaryItems_many: '{{count}} de elementos',
+      summaryItems_other: '{{count}} elementos',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/fr.ts b/packages/i18n/src/locales/fr.ts
index 6870e5e4f7..48151c12f5 100644
--- a/packages/i18n/src/locales/fr.ts
+++ b/packages/i18n/src/locales/fr.ts
@@ -3974,6 +3974,11 @@ const fr = {
       confirmNoteSeparate_many: 'La publication libère les {{count}} de brouillons en attente un par un : celui qui échoue reste en attente, les autres sont publiés quand même.',
       confirmNoteSeparate_other: 'La publication libère les {{count}} brouillons en attente un par un : celui qui échoue reste en attente, les autres sont publiés quand même.',
       publishConfirm: 'Tout publier',
+      summaryItems: '{{count}} éléments',
+      summaryItems_one: '{{count}} élément',
+      summaryItems_many: '{{count}} d’éléments',
+      summaryItems_other: '{{count}} éléments',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/ja.ts b/packages/i18n/src/locales/ja.ts
index 8c328f9904..42a151a95d 100644
--- a/packages/i18n/src/locales/ja.ts
+++ b/packages/i18n/src/locales/ja.ts
@@ -3896,6 +3896,10 @@ const ja = {
       confirmNoteSeparate_one: '公開すると、保留中のドラフト {{count}} 件がそれぞれ個別に公開されます。公開に失敗したドラフトは保留中のまま残り、ほかのドラフトは公開されます。',
       confirmNoteSeparate_other: '公開すると、保留中のドラフト {{count}} 件がそれぞれ個別に公開されます。公開に失敗したドラフトは保留中のまま残り、ほかのドラフトは公開されます。',
       publishConfirm: 'すべて公開',
+      summaryItems: '{{count}} 件',
+      summaryItems_one: '{{count}} 件',
+      summaryItems_other: '{{count}} 件',
+      summaryType: '{{type}} {{n}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/ko.ts b/packages/i18n/src/locales/ko.ts
index 771862f222..320caabd7a 100644
--- a/packages/i18n/src/locales/ko.ts
+++ b/packages/i18n/src/locales/ko.ts
@@ -3893,6 +3893,10 @@ const ko = {
       confirmNoteSeparate_one: '게시하면 대기 중인 초안 {{count}}개가 하나씩 따로 게시됩니다. 게시에 실패한 초안은 대기 상태로 남고, 나머지는 그대로 게시됩니다.',
       confirmNoteSeparate_other: '게시하면 대기 중인 초안 {{count}}개가 하나씩 따로 게시됩니다. 게시에 실패한 초안은 대기 상태로 남고, 나머지는 그대로 게시됩니다.',
       publishConfirm: '모두 게시',
+      summaryItems: '{{count}}개 항목',
+      summaryItems_one: '{{count}}개 항목',
+      summaryItems_other: '{{count}}개 항목',
+      summaryType: '{{type}} {{n}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/pt.ts b/packages/i18n/src/locales/pt.ts
index 9af05157c3..b6ae303d1a 100644
--- a/packages/i18n/src/locales/pt.ts
+++ b/packages/i18n/src/locales/pt.ts
@@ -3972,6 +3972,11 @@ const pt = {
       confirmNoteSeparate_many: 'Publicar libera os {{count}} de rascunhos pendentes um a um: o que falhar continua pendente e os demais são publicados mesmo assim.',
       confirmNoteSeparate_other: 'Publicar libera os {{count}} rascunhos pendentes um a um: o que falhar continua pendente e os demais são publicados mesmo assim.',
       publishConfirm: 'Publicar tudo',
+      summaryItems: '{{count}} itens',
+      summaryItems_one: '{{count}} item',
+      summaryItems_many: '{{count}} de itens',
+      summaryItems_other: '{{count}} itens',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/ru.ts b/packages/i18n/src/locales/ru.ts
index a7798882b9..6bc554177d 100644
--- a/packages/i18n/src/locales/ru.ts
+++ b/packages/i18n/src/locales/ru.ts
@@ -4076,6 +4076,12 @@ const ru = {
       confirmNoteSeparate_many: 'Публикация выпускает {{count}} ожидающих черновиков по отдельности: черновик, который не удастся опубликовать, останется ожидающим, а остальные всё равно будут опубликованы.',
       confirmNoteSeparate_other: 'Публикация выпускает {{count}} ожидающего черновика по отдельности: черновик, который не удастся опубликовать, останется ожидающим, а остальные всё равно будут опубликованы.',
       publishConfirm: 'Опубликовать всё',
+      summaryItems: '{{count}} элементов',
+      summaryItems_one: '{{count}} элемент',
+      summaryItems_few: '{{count}} элемента',
+      summaryItems_many: '{{count}} элементов',
+      summaryItems_other: '{{count}} элемента',
+      summaryType: '{{n}} {{type}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.
diff --git a/packages/i18n/src/locales/zh.ts b/packages/i18n/src/locales/zh.ts
index 3153e01d48..1650ccff7a 100644
--- a/packages/i18n/src/locales/zh.ts
+++ b/packages/i18n/src/locales/zh.ts
@@ -2932,6 +2932,10 @@ const zh = {
       confirmNoteSeparate_one: '发布会逐个单独发布这 {{count}} 个待发布草稿：发布失败的草稿仍保持待发布，其余草稿照常发布。',
       confirmNoteSeparate_other: '发布会逐个单独发布这 {{count}} 个待发布草稿：发布失败的草稿仍保持待发布，其余草稿照常发布。',
       publishConfirm: '全部发布',
+      summaryItems: '{{count}} 项',
+      summaryItems_one: '{{count}} 项',
+      summaryItems_other: '{{count}} 项',
+      summaryType: '{{type}} {{n}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.

From ad97f9dd99341e15f9aa03716b954869d1f33ac5 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Thu, 15 Oct 2026 23:32:07 +0000
Subject: [PATCH 2/3] fix(app-shell): seed the confirm posture's expansion
 before paint

The seed ran in a passive effect, so the commit that first rendered the
list painted it collapsed for a frame; a loaded test run read that frame.
Seed in layout effects, and pin that no collapsed row is ever observed.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
---
 packages/app-shell/src/preview/DraftChangesPanel.tsx   |  8 +++++---
 .../__tests__/DraftChangesPanel.posture-12517.test.tsx | 10 ++++++++++
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/packages/app-shell/src/preview/DraftChangesPanel.tsx b/packages/app-shell/src/preview/DraftChangesPanel.tsx
index f6af034fc7..eb865e1615 100644
--- a/packages/app-shell/src/preview/DraftChangesPanel.tsx
+++ b/packages/app-shell/src/preview/DraftChangesPanel.tsx
@@ -24,7 +24,7 @@
  * publish action itself still belongs to the caller.
  */
 
-import { useCallback, useEffect, useRef, useState } from 'react';
+import { useCallback, useEffect, useLayoutEffect, useRef, useState } from 'react';
 import { ChevronDown, ChevronRight, Equal, FilePlus2, FilePen, Loader2, Rocket, ShieldAlert } from 'lucide-react';
 import { toast } from 'sonner';
 import {
@@ -534,6 +534,8 @@ export function DraftChangesPanel({
    * below re-map the entries. Focus lands on the list at open (the Publish
    * all button does not exist until the list loads) and moves to Publish all
    * on that same arrival — only if the author has not moved it meanwhile.
+   * Layout effects, so the frame that first paints the list already paints
+   * it expanded: a passive effect let one collapsed frame through first.
    */
   const listRef = useRef<HTMLDivElement>(null);
   const publishRef = useRef<HTMLButtonElement>(null);
@@ -541,14 +543,14 @@ export function DraftChangesPanel({
   // The list as it stood when the sheet opened: the previous open's, until
   // this open's load replaces it. Only a list newer than that one settles.
   const entriesAtOpenRef = useRef<DraftChangeEntry[] | null>(null);
-  useEffect(() => {
+  useLayoutEffect(() => {
     if (!open) return;
     settledRef.current = false;
     entriesAtOpenRef.current = entries;
     setExpanded(new Set());
     // Keyed on the open transition alone: `entries` is read, not watched.
   }, [open]);
-  useEffect(() => {
+  useLayoutEffect(() => {
     if (!open || settledRef.current || entries === null || entries === entriesAtOpenRef.current) return;
     settledRef.current = true;
     if (posture !== 'confirm') return;
diff --git a/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx b/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
index a67e95b769..b1a038d77d 100644
--- a/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
+++ b/packages/app-shell/src/preview/__tests__/DraftChangesPanel.posture-12517.test.tsx
@@ -94,7 +94,17 @@ function expectReviewPosture() {
 
 describe('objectui#12517 — the pending-changes sheet opens in a posture', () => {
   it('confirm: every row expanded, the summary line counted by type, focus on Publish all', async () => {
+    // No frame shows a collapsed row: the expansion lands in the commit that
+    // first renders the list, not in a passive effect after it is painted
+    // (under load the observer below fired in that gap, and so would a paint).
+    let collapsedSeen = 0;
+    const observer = new MutationObserver(() => {
+      collapsedSeen += document.querySelectorAll('[data-testid="draft-entry-toggle"][aria-expanded="false"]').length;
+    });
+    observer.observe(document.body, { subtree: true, childList: true, attributes: true });
     await renderHost('confirm');
+    observer.disconnect();
+    expect(collapsedSeen).toBe(0);
     expect(screen.getByTestId('draft-changes-panel')).toHaveAttribute('data-posture', 'confirm');
     for (const toggle of toggles()) expect(toggle).toHaveAttribute('aria-expanded', 'true');
     await waitFor(() => expect(screen.getAllByTestId('draft-entry-detail')).toHaveLength(DRAFT_ROWS.length));

From 459d12b577ced6a30275a2ce7fd0179c949a1ee6 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Fri, 16 Oct 2026 00:34:47 +0000
Subject: [PATCH 3/3] fix(i18n): give ru its own order for the confirm
 summary's type segment

The ru value was byte-identical to en, which the untranslated-identity
pin reads as a value never translated.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
---
 packages/i18n/src/locales/ru.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/i18n/src/locales/ru.ts b/packages/i18n/src/locales/ru.ts
index 6bc554177d..8f32f3b317 100644
--- a/packages/i18n/src/locales/ru.ts
+++ b/packages/i18n/src/locales/ru.ts
@@ -4081,7 +4081,7 @@ const ru = {
       summaryItems_few: '{{count}} элемента',
       summaryItems_many: '{{count}} элементов',
       summaryItems_other: '{{count}} элемента',
-      summaryType: '{{n}} {{type}}',
+      summaryType: '{{type}}: {{n}}',
       // [`7a90afdf9`] Pre-publish security-posture findings, shown next to
       // the confirm button so a refusal the door would issue is read BEFORE
       // the click rather than as a toast after the batch rolled back.