HTML Content
', - }); + })); // HTML renderer uses dangerouslySetInnerHTML const hasContent = container.querySelector('p') || container.textContent?.includes('HTML Content'); diff --git a/packages/components/src/__tests__/data-table-row-click.test.tsx b/packages/components/src/__tests__/data-table-row-click.test.tsx index 85b603b582..32cbcc031c 100644 --- a/packages/components/src/__tests__/data-table-row-click.test.tsx +++ b/packages/components/src/__tests__/data-table-row-click.test.tsx @@ -25,6 +25,15 @@ import { renderComponent } from './test-utils'; // cold transform is billed to `hookTimeout`, which is why this carried a raised // timeout. See object-ui/no-dynamic-import-in-test-hook (objectui#3010/#3021). import '../renderers'; +import type { DataTableSchema } from '@object-ui/types'; + +/** + * Types a literal below as the node it is rather than as the `BaseSchema` + * `renderComponent` accepts (objectui#11347): once `BaseSchema`'s index + * signature is gone (objectui#8347), a literal checked against `BaseSchema` + * may author only `BaseSchema`'s own keys. + */ +const dataTableNode = (schema: DataTableSchema): DataTableSchema => schema; describe('data-table — row click heuristic ignores overlay items', () => { const baseSchema = { @@ -85,12 +94,12 @@ describe('data-table — row click heuristic ignores overlay items', () => { it('clicking a plain text cell still calls onRowClick (sanity)', () => { const onRowClick = vi.fn(); - const { container } = renderComponent({ + const { container } = renderComponent(dataTableNode({ type: 'data-table', columns: [{ header: 'Name', accessorKey: 'name' }], data: [{ id: '1', name: 'Alice' }], onRowClick, - }); + })); // Click on the name cell text (not a button/link/menu). const cell = Array.from(container.querySelectorAll('td')).find((td) => diff --git a/packages/components/src/__tests__/empty-action-declared-7105.test.tsx b/packages/components/src/__tests__/empty-action-declared-7105.test.tsx index 85e5e58b14..be9d2a61de 100644 --- a/packages/components/src/__tests__/empty-action-declared-7105.test.tsx +++ b/packages/components/src/__tests__/empty-action-declared-7105.test.tsx @@ -72,7 +72,7 @@ import { render } from '@testing-library/react'; import { ComponentRegistry } from '@object-ui/core'; import { SchemaRenderer } from '@object-ui/react'; import { EmptySchema as EmptyMirror } from '@object-ui/types/zod'; -import type { EmptySchema, SchemaNode } from '@object-ui/types'; +import type { ButtonSchema, EmptySchema, SchemaNode } from '@object-ui/types'; import '../renderers'; const HERE = dirname(fileURLToPath(import.meta.url)); @@ -101,16 +101,20 @@ type _ActionIsSchemaNode = Expect< Equal< EmptySchema['action'], SchemaNode > >; * The shipped demo, as a literal the compiler checks against the declared type. * The first test asserts it is byte-identical to the file the docs page renders. */ +const DEMO_ACTION: ButtonSchema = { + type: 'button', + label: 'Create Project', + variant: 'default', +}; +// `DEMO_ACTION` is typed as the `button` node it is (objectui#11347): the slot is +// `SchemaNode`, and once `BaseSchema`'s index signature is gone (objectui#8347) +// a literal checked against it may author only `BaseSchema`'s own keys. const DEMO = { type: 'empty', icon: 'folder-plus', title: 'No projects yet', description: 'Get started by creating your first project', - action: { - type: 'button', - label: 'Create Project', - variant: 'default', - }, + action: DEMO_ACTION, } satisfies EmptySchema; const readDemo = (): unknown => JSON.parse(readFileSync(DEMO_PATH, 'utf8')); diff --git a/packages/components/src/__tests__/form-renderers.test.tsx b/packages/components/src/__tests__/form-renderers.test.tsx index 58353e83c6..5371a8e0c1 100644 --- a/packages/components/src/__tests__/form-renderers.test.tsx +++ b/packages/components/src/__tests__/form-renderers.test.tsx @@ -18,6 +18,31 @@ import { // cold transform is billed to `hookTimeout`, which is why this carried a raised // timeout. See object-ui/no-dynamic-import-in-test-hook (objectui#3010/#3021). import '../renderers'; +import type { + ButtonSchema, + InputSchema, + LabelSchema, + RadioGroupSchema, + SelectSchema, + SliderSchema, + TextSchema, +} from '@object-ui/types'; + +/** + * Types a literal below as the node it is rather than as the `BaseSchema` + * `renderComponent` accepts, children included (objectui#11347): once + * `BaseSchema`'s index signature is gone (objectui#8347), a literal checked + * against `BaseSchema` or `SchemaNode` may author only `BaseSchema`'s own keys. + * The literals that deliberately author a retired or undeclared key stay + * untyped, on purpose. + */ +const buttonNode = (schema: ButtonSchema): ButtonSchema => schema; +const inputNode = (schema: InputSchema): InputSchema => schema; +const labelNode = (schema: LabelSchema): LabelSchema => schema; +const radioGroupNode = (schema: RadioGroupSchema): RadioGroupSchema => schema; +const selectNode = (schema: SelectSchema): SelectSchema => schema; +const sliderNode = (schema: SliderSchema): SliderSchema => schema; +const textNode = (schema: TextSchema): TextSchema => schema; /** * Comprehensive tests for form renderer components @@ -47,14 +72,14 @@ describe('Form Renderers - Display Issue Detection', () => { }); it('should support different variants', () => { - const variants = ['default', 'secondary', 'destructive', 'outline', 'ghost', 'link']; + const variants: NonNullable{schema.text}
+ {/* The message is the DECLARED `label` (`LoadingSchema.label`, "Loading + text/message", on both faces). The renderer used to read an + undeclared `text` here and leave `label` inert; no producer authors + either spelling, so the read moved to the declared one and `text` + is retired, with no alias (objectui#11347). */} + {schema.label && ( +{schema.label}
)}