From 460b5829244a6fe43e60371496ead97dd2d1a3a1 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 30 Oct 2026 11:45:51 +0000 Subject: [PATCH 1/2] ci: schedule the ui jobs and Build Docs on a root package.json diff (#27717) setup-pnpm reads the root manifest's `packageManager` field to pick the pnpm it materialises, and every ui job and Build Docs run it. The `ui:` and `docs:` filter lists carried no `package.json` row, so a diff confined to a pnpm bump started none of them on the PR. Both lists gain the row; `core:` already had it. The parity gate's header named setup-pnpm as the one local composite action its recognizer does not follow. Build Core uses setup-workspace, which calls setup-pnpm in turn; the bound now says so. Claude-Session: https://claude.ai/code/session_01L9qibxnVpxAbqTXMwJU6LM Co-authored-by: Claude --- .github/workflows/ci.yml | 10 ++++++++++ scripts/check-ci-filter-parity.mjs | 6 ++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 41c5a3755bc..1875ed6c463 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -280,6 +280,11 @@ jobs: - '.nvmrc' - '.github/actions/setup-workspace/**' - '.github/actions/setup-pnpm/**' + # setup-pnpm materialises the pnpm the root manifest's + # `packageManager` field pins (#27717), so a diff confined to + # that field changes the pnpm Build Docs installs with. `core:` + # already carries this row for its own jobs. + - 'package.json' core: - 'packages/**' - 'examples/**' @@ -533,6 +538,11 @@ jobs: # PR, nor in the queue, where these outputs read the same diff. - '.nvmrc' - '.github/actions/setup-pnpm/**' + # The root manifest, because setup-pnpm reads its `packageManager` + # field to pick the pnpm every ui job runs (#27717). A diff + # confined to a pnpm bump matched no list here, so the ui jobs + # skipped on the PR and in the queue alike. + - 'package.json' # The seven packages objectui installs from this tree (the set its # `.objectstack-pin` used to pack). A change here compiles and builds # the Console in the same PR — the check the retired Spec Shape Gate diff --git a/scripts/check-ci-filter-parity.mjs b/scripts/check-ci-filter-parity.mjs index 44654807bc8..fd9dc2d3e39 100644 --- a/scripts/check-ci-filter-parity.mjs +++ b/scripts/check-ci-filter-parity.mjs @@ -190,8 +190,10 @@ * script a PACKAGE's own manifest runs (`pnpm --filter