From 352780c30a937b5022659dab51ebf12dfc3bf2ae Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 27 Oct 2026 09:21:31 +0000 Subject: [PATCH] fix(plugin-security): translate the built-in positions' labels and descriptions Setup -> Positions under zh-CN listed the seven built-in positions in English: the plugin's bundle had no positions group. Add hand-authored zh-CN, ja-JP and es-ES entries beside the permission sets, and a test of the served overlay per locale. Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01FEkQ5nLEq1iuL8pxDHXN76 --- .../26562-builtin-position-translations.md | 10 ++ .../translations/builtin-positions.test.ts | 68 ++++++++++ .../src/translations/builtin-positions.ts | 120 ++++++++++++++++++ .../plugin-security/src/translations/index.ts | 13 +- 4 files changed, 207 insertions(+), 4 deletions(-) create mode 100644 .changeset/26562-builtin-position-translations.md create mode 100644 packages/plugins/plugin-security/src/translations/builtin-positions.test.ts create mode 100644 packages/plugins/plugin-security/src/translations/builtin-positions.ts diff --git a/.changeset/26562-builtin-position-translations.md b/.changeset/26562-builtin-position-translations.md new file mode 100644 index 00000000000..6c0fb7ffda4 --- /dev/null +++ b/.changeset/26562-builtin-position-translations.md @@ -0,0 +1,10 @@ +--- +'@objectstack/plugin-security': patch +--- + +fix(plugin-security): the seven built-in positions are served in Chinese, Japanese and Spanish + +Clause-②: no +Metadata-protocol: none + +Setup → Positions lists the platform's built-in positions (Platform Admin, Organization Owner, Organization Admin, Organization Member, Organization External Member, Everyone, Guest) beside the app's own. Under zh-CN the app's positions read in Chinese while these seven stayed English, because this plugin's translation bundle carried no `positions` group. The bundle now carries `positions..label` and `.description` for each built-in position in zh-CN, ja-JP and es-ES, the locales its permission-set translations cover, so `GET /api/v1/meta/position` serves them in the requested locale. English is unchanged, and nothing else of a position changes. diff --git a/packages/plugins/plugin-security/src/translations/builtin-positions.test.ts b/packages/plugins/plugin-security/src/translations/builtin-positions.test.ts new file mode 100644 index 00000000000..498f09472dd --- /dev/null +++ b/packages/plugins/plugin-security/src/translations/builtin-positions.test.ts @@ -0,0 +1,68 @@ +// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license. + +import { describe, it, expect } from 'vitest'; +import { translateMetadataDocument } from '@objectstack/spec/system'; +import { securityBuiltinPositions } from '../builtin-positions.js'; +import { SecurityTranslations } from './index.js'; + +/** + * Every built-in position reads in the administrator's language. + * + * Setup → Positions lists the platform's seven built-in positions beside the + * app's own, each with its `label` and `description`, from + * `GET /meta/position`, which overlays the bundle's `positions` group on every + * served position. The app's positions came back translated and the + * platform's stayed English, because this plugin's bundle carried no + * `positions` group. This pins that every translated locale of the bundle + * carries both strings for exactly the built-ins, and that the served + * document is that locale's. It is deliberately not a copy of the wording, + * which `./builtin-positions.ts` owns. + */ +type AnyRec = Record; + +const TRANSLATED_LOCALES = Object.keys(SecurityTranslations).filter((l) => l !== 'en'); +const POSITION_NAMES = securityBuiltinPositions.map((p) => p.name); + +describe('built-in position translations', () => { + it('declares the seven built-in positions', () => { + expect([...POSITION_NAMES].sort()).toEqual( + ['everyone', 'guest', 'org_admin', 'org_external', 'org_member', 'org_owner', 'platform_admin'], + ); + }); + + it('the bundle carries translated locales', () => { + expect(TRANSLATED_LOCALES).toEqual(expect.arrayContaining(['zh-CN', 'ja-JP', 'es-ES'])); + }); + + describe.each(TRANSLATED_LOCALES)('%s', (locale) => { + const group = ((SecurityTranslations[locale] as AnyRec | undefined)?.positions ?? {}) as AnyRec; + + it('translates exactly the built-in positions', () => { + expect(Object.keys(group).sort()).toEqual([...POSITION_NAMES].sort()); + }); + + it('gives no two positions the same label', () => { + const labels = POSITION_NAMES.map((name) => (group[name] as AnyRec | undefined)?.label); + expect(new Set(labels).size).toBe(labels.length); + }); + + // The overlay `GET /meta/position` applies at the REST boundary, read + // through the bundle this plugin loads: the served position's label and + // description are this locale's, nothing else of the position changes. + it.each(securityBuiltinPositions.map((p) => [p.name, p] as const))( + '%s is served in this locale', + (name, position) => { + const entry = group[name] as AnyRec | undefined; + for (const attr of ['label', 'description'] as const) { + const text = entry?.[attr]; + expect(typeof text, `${locale} ${name}.${attr} missing`).toBe('string'); + expect(text, `${locale} ${name}.${attr} padded`).toBe(String(text).trim()); + expect(text, `${locale} ${name}.${attr}: an English copy, not a translation`).not.toBe(position[attr]); + expect(text, `${locale} ${name}.${attr}: names a position id`).not.toMatch(/\b[a-z]+_[a-z_]+\b/); + } + const served = translateMetadataDocument('position', { ...position }, SecurityTranslations, { locale }); + expect(served).toEqual({ ...position, label: entry?.label, description: entry?.description }); + }, + ); + }); +}); diff --git a/packages/plugins/plugin-security/src/translations/builtin-positions.ts b/packages/plugins/plugin-security/src/translations/builtin-positions.ts new file mode 100644 index 00000000000..0c233713928 --- /dev/null +++ b/packages/plugins/plugin-security/src/translations/builtin-positions.ts @@ -0,0 +1,120 @@ +// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license. + +/** + * Translations of the built-in positions' labels and descriptions — the + * `positions..label` / `.description` group of the translation bundle, + * which `translatePosition` overlays on every served `position` document + * (`GET /meta/position`, the list Setup → Positions shows). + * + * HAND-AUTHORED, not generated, for the reason `permission-sets.ts` gives: this + * package's extract runs objects-only, so `os i18n extract` writes no + * `positions` group here. The English source is each declaration in + * `../builtin-positions.ts` (the identity names' text comes from the spec's + * `BUILTIN_IDENTITY_METADATA`, the audience anchors' from that module); `en` + * needs no entry, because an untranslated locale serves the declaration's own + * text. When a source label or sentence changes, re-translate its three + * entries here in the same change: nothing marks a translation stale. + * `builtin-positions.test.ts` pins both strings per built-in position per + * locale, and the served overlay. + * + * Terms follow this bundle's objects: a position is 岗位 / ポジション / + * puesto, and the organization roles read as the member record's role options + * do (所有者, 外部成员 …). + */ + +import type { TranslationData } from '@objectstack/spec/system'; + +type PositionTranslations = NonNullable; + +export const zhCNBuiltinPositions: PositionTranslations = { + platform_admin: { + label: '平台管理员', + description: '平台运维人员（SaaS 管理员），不是租户内的用户角色。', + }, + org_owner: { + label: '组织所有者', + description: '租户内组织的所有者。', + }, + org_admin: { + label: '组织管理员', + description: '租户内组织的管理员。', + }, + org_member: { + label: '组织成员', + description: '租户内组织的成员。', + }, + org_external: { + label: '组织外部成员', + description: '租户内的外部成员（门户用户）：只能看到本人的身份记录，仅通过明确授予的权限访问数据。', + }, + everyone: { + label: '全体成员', + description: '内置受众锚点：每位已登录成员都隐式担任此岗位。绑定到此岗位的权限集就是租户的默认授权。高权限的权限集不能绑定到这里。', + }, + guest: { + label: '访客', + description: '内置受众锚点：未登录的访问者隐式且唯一地担任此岗位。这里的绑定受最严格的检查 — 只能指定具体对象、以只读为主、绝不允许通配符。', + }, +}; + +export const jaJPBuiltinPositions: PositionTranslations = { + platform_admin: { + label: 'プラットフォーム管理者', + description: 'プラットフォーム運用者（SaaS 管理者）。テナント内のユーザーの役割ではありません。', + }, + org_owner: { + label: '組織オーナー', + description: 'テナント内の組織のオーナー。', + }, + org_admin: { + label: '組織管理者', + description: 'テナント内の組織の管理者。', + }, + org_member: { + label: '組織メンバー', + description: 'テナント内の組織のメンバー。', + }, + org_external: { + label: '組織外部メンバー', + description: 'テナント内の外部メンバー（ポータルユーザー）：自分の ID レコードだけを参照でき、データには明示的に付与された権限でのみアクセスします。', + }, + everyone: { + label: '全メンバー', + description: '組み込みの対象者アンカー：サインインしたすべてのメンバーが暗黙的にこのポジションを持ちます。ここに割り当てた権限セットがテナントの既定の付与になります。高権限のセットはここに割り当てられません。', + }, + guest: { + label: 'ゲスト', + description: '組み込みの対象者アンカー：サインインしていないアクセス者だけが暗黙的にこのポジションを持ちます。ここへの割り当ては最も厳しく検査されます — 名前を指定したオブジェクトのみ、読み取り中心、ワイルドカードは不可。', + }, +}; + +export const esESBuiltinPositions: PositionTranslations = { + platform_admin: { + label: 'Administrador de la plataforma', + description: 'Operador de la plataforma (administrador SaaS). No es un rol de usuario dentro del inquilino.', + }, + org_owner: { + label: 'Propietario de la organización', + description: 'Propietario de una organización dentro de un inquilino.', + }, + org_admin: { + label: 'Administrador de la organización', + description: 'Administrador de una organización dentro de un inquilino.', + }, + org_member: { + label: 'Miembro de la organización', + description: 'Miembro de una organización dentro de un inquilino.', + }, + org_external: { + label: 'Miembro externo de la organización', + description: 'Miembro externo dentro de un inquilino (usuario del portal): solo ve sus propios registros de identidad y accede a los datos únicamente mediante concesiones explícitas.', + }, + everyone: { + label: 'Todos', + description: 'Ancla de audiencia integrada: todo miembro con sesión iniciada ocupa este puesto de forma implícita. Los conjuntos de permisos vinculados a él son las concesiones predeterminadas del inquilino. Aquí no se pueden vincular conjuntos de privilegios elevados.', + }, + guest: { + label: 'Invitado', + description: 'Ancla de audiencia integrada: quienes no han iniciado sesión ocupan este puesto de forma implícita y exclusiva. Sus vínculos pasan los controles más estrictos: solo objetos con nombre, sobre todo lectura y nunca un comodín.', + }, +}; diff --git a/packages/plugins/plugin-security/src/translations/index.ts b/packages/plugins/plugin-security/src/translations/index.ts index 278bd900647..17041442e4c 100644 --- a/packages/plugins/plugin-security/src/translations/index.ts +++ b/packages/plugins/plugin-security/src/translations/index.ts @@ -19,6 +19,7 @@ import { zhCNGeneratedSourceHashes } from './zh-CN.source-hashes.generated.js'; import { jaJPGeneratedSourceHashes } from './ja-JP.source-hashes.generated.js'; import { esESGeneratedSourceHashes } from './es-ES.source-hashes.generated.js'; import { zhCNPermissionSets, jaJPPermissionSets, esESPermissionSets } from './permission-sets.js'; +import { zhCNBuiltinPositions, jaJPBuiltinPositions, esESBuiltinPositions } from './builtin-positions.js'; /** * ## The provenance companions are READ here, not merely recorded @@ -50,23 +51,27 @@ import { zhCNPermissionSets, jaJPPermissionSets, esESPermissionSets } from './pe const enSource: TranslationData = { objects: enObjects }; /** - * The built-in permission sets' description translations (`permissions`) are - * hand-authored beside the generated objects (`permission-sets.ts` says why). - * They sit outside `withSourceFallback`'s inputs: `enSource` carries no - * `permissions` group, so no leaf of theirs is judged stale. + * The built-in permission sets' translations (`permissions`) and the built-in + * positions' (`positions`) are hand-authored beside the generated objects + * (`permission-sets.ts` says why). They sit outside `withSourceFallback`'s + * inputs: `enSource` carries neither group, so no leaf of theirs is judged + * stale. */ export const SecurityTranslations: TranslationBundle = { en: enSource, 'zh-CN': { ...withSourceFallback({ objects: zhCNObjects }, enSource, undefined, zhCNGeneratedSourceHashes), permissions: zhCNPermissionSets, + positions: zhCNBuiltinPositions, }, 'ja-JP': { ...withSourceFallback({ objects: jaJPObjects }, enSource, undefined, jaJPGeneratedSourceHashes), permissions: jaJPPermissionSets, + positions: jaJPBuiltinPositions, }, 'es-ES': { ...withSourceFallback({ objects: esESObjects }, enSource, undefined, esESGeneratedSourceHashes), permissions: esESPermissionSets, + positions: esESBuiltinPositions, }, };