Repository navigation
[finding][devx] os migrate meta --from 17 buries a project's real findings under 240 generic protocol-18 notices, and marks default-flip conversions as "Applied" when the right action is usually no edit #20620
Description
Observed on a real upgrade: HotCRM 17.4.0 → 17.5.0, 2026-09-29
os migrate meta --from 17 printed 874 lines for HotCRM. It ended with "Migrated stack does not yet pass schema validation". The output contained:
- 41 refusals (the actionable part);
- 57 mechanical edits;
- 240 "manual change" notices. These are the entire protocol-18 catalogue (WebSocket durations,
kernel.advancedPluginLifecycle, …). None of them applies to this stack.
Three problems for an upgrader:
- Noise. The 41 refusals that block boot are hard to find among 240 notices about surfaces the stack does not use.
- Default-flip conversions are presented as edits to apply. The 13
flow-decision-mode-inclusive-explicitedits appear as "Applied". But for a decision whose branch conditions partition, the right action is no edit. Applying the offeredmode: 'inclusive'literally then triggers theflow-decision-inclusive-overlaplint on every one. All 13 of HotCRM's decisions partition. - No write-back. The mechanical edits say "apply them by hand", so lossless edits still have to be transcribed manually.
Asks
- Filter the notices to the surfaces the stack actually uses, or at least group them after the actionable findings.
- Mark semantic default flips as review items, not "Applied".
- Offer a source-writing mode for lossless mechanical edits.
Related, different concern: #20233 (tracker numbers in the migration text).
Generated by Claude Code
Activity
objectstack-fleet commentedon Sep 29, 2026
ACCEPT: PR #20691 at
8304fb9e, direction 1 of #20620 (order)domain:cliexecution PM seat #6024 · sessionlocal_1d2a197c-c20e-4e90-9be8-413d4d432289· review of record, written 2026-09-29T18:12ZReviewed against GitHub and
main, not against the report.What this PR executes: triage's direction 1 (
5888087153).os migrate metaleads with the verdict and the refusals, then the applied mechanical edits, then the semantic notices, with one header line counting each group. ⛔ No notice is dropped. Direction 2 is split to #20697, and direction 3 is out (5895765767).Checklist:
PR shape: draft, base
main. The first line isPart of #20620, followed by a line-initialClause-②: no. There is no closing keyword, because the card stays open for direction 2.Scope: 3 files, all inside the claim:
packages/cli/src/commands/migrate/meta.ts, one new unit test beside it, and one changeset (@objectstack/clipatch).check-governed-merges --pr 20691: NOT governed, +462 −78.Review route: changeset prose is a contract-review surface. The at-tier record on the PR is PASS at this head. It found:
formatZodIssue. It is the smallest execution of "lead with the refusals", since the printer had no refusal list;--json, the exit codes,--outand the loader's stderr;patchandClause-②: no: right;The seat verified its transcript: served at
CONTRACT_REVIEW_TIER, read-only, no GitHub write.Evidence: real stacks were measured before and after through
bin/run.js:--jsonis identical apart fromduration;--outand stderr are byte-identical, and every exit code is 0 both times.Commits: every non-merge commit carries the model-free trailer pair.
Out-of-scope findings and the review's escalations, one line each:
os migrate metaaborts at load on anObjectSchema.createobject that carries a retired key: filed as [finding] os migrate meta aborts at load on an object built with ObjectSchema.create that carries a retired key, although the refusal it prints tells the author to run os migrate meta #20696.docs/qa/platform-checklist/areas/cli.json, itemcli.migrate-meta-codemod(revision 3), step 7 quotes the old verdict sentence verbatim. It is stale once this lands, although its acceptance clause still holds. It needs a revision-4 bump by the checklist's author, naming the new refusal group:Acceptance notes, for the checklist's owner.skills/objectstack-upgrade/SKILL.md:139-147lists the groups in the old order, with no order claimed. It is Tier H governed, so a one-line reorder waits for that surface's next queue entry:Acceptance notes.check:platform-checklistis red onmain(twoFactor). It is pre-existing and maintainer-run, not this PR's.TMPDIRpins are host-only.[authored-source]prefix and "left after the chain" keep them apart.Next: landing once CI is green, as
markPullRequestReadyForReview+enablePullRequestAutoMerge(SQUASH) asobjectstack-fleet[bot].objectstack-fleet commentedon Sep 29, 2026
Landed: PR #20691 →
3b47a693c7(direction 1). State change:pm:dispatched→pm:blockeddomain:cliexecution PM seat #6024 · sessionlocal_1d2a197c-c20e-4e90-9be8-413d4d432289· landing record, written 2026-09-29T18:29Z · the claim5894939836stands; the assignee stays; this card is followed to MERGEDBlocked-by: #20697
main's head at this read (the compare reads identical).main:packages/cli/src/commands/migrate/meta.ts:328exportsprintMigrationReport, which prints the verdict and the refusals first, then the applied edits, then the semantic notices, each group under a counting header..changeset/20620-migrate-meta-verdict-first.mdis pending for the next version pass.SemanticMigration. That is spec(migrations): a semantic entry names the D2 conversions whose applied edits it judges (SemanticMigration.conversionIds), so os migrate meta can pair them (the spec half of #20620) #20697, the spec half, filed bare for triage to route todomain:spec(5895765767).mainand dispatches the printer's pairing on this card, with a closingFixes #20620.ObjectSchema.createload abort), and the stale checklist stepcli.migrate-meta-codemodfor the checklist's owner (ACCEPT5895943032).objectstack-fleet commentedon Sep 30, 2026
Release: the block is met, so the card goes back to
pm:queuefor direction 2 (the printer's pairing)domain:cliseat ·session_01VvcEokUG1tvVxkceYfR5XB· 2026-09-30T17:43ZRelease: session
session_01VvcEokUG1tvVxkceYfR5XB, for the claim5894939836. That claim is the predecessor seat's (sessionlocal_1d2a197c-c20e-4e90-9be8-413d4d432289), carried to this seat by its closing brief5903478470on the seat post #6024.Blocked-by: #20697(5896210546) is met. spec(migrations): a semantic entry names the D2 conversions whose applied edits it judges (SemanticMigration.conversionIds), so os migrate meta can pair them (the spec half of #20620) #20697 landed as PR feat(spec): a semantic migration names the D2 conversions whose applied edits it judges (SemanticMigration.conversionIds) #20716 (6afccda5ad, landing record5900147099):SemanticMigration.conversionIdsis onmain, and one link is authored (flow-decision-edge-branching-first-match→flow-decision-mode-inclusive-explicit). All three of this seat's slots are in use right now, so the card goes back to the queue rather than holding an undispatched claim.pm:queue, frompm:blocked. The assigneehotlongis cleared in the same act.5896210546states it.os migrate metaprints the semantic entry that judges an applied conversion beside that edit, marked review, with a closingFixes #20620.conversionIds, never through text mentions. spec(migrations): a semantic entry names the D2 conversions whose applied edits it judges (SemanticMigration.conversionIds), so os migrate meta can pair them (the spec half of #20620) #20697's other 56 mention candidates stay unlinked by design (5900147099).main.Generated by Claude Code
objectstack-fleet commentedon Oct 1, 2026
Claim: PM loop round 1 of the
domain:cliseat's sessionsession_01VvcEokUG1tvVxkceYfR5XB(batch3):priority:p3tooling(the publishedos migrate metasurface), direction 2 of triage's first grade (the pairing), filling a free slot under the maintainer's instruction 「任务很多，并发保持3」Session:
session_01VvcEokUG1tvVxkceYfR5XBAccount:
huangyiireneBranch:
claude/issue-20620-migrate-meta-pairingWorktree:
objectstack-issue-20620Domain:
domain:cliSeat:
domain:cli#1File surface:
packages/cli/src/commands/migrate/meta.ts, the human printer only (printMigrationReport, about:326–:395ondfe5a0863f):conversionIds, that entry is printed beside the applied edit, marked review.conversionIdsonly, ⛔ never through text mentions. spec(migrations): a semantic entry names the D2 conversions whose applied edits it judges (SemanticMigration.conversionIds), so os migrate meta can pair them (the spec half of #20620) #20697's other mention candidates stay unlinked by design (5900147099).--json, the exit codes,--outand the loader's stderr stay unchanged.packages/cli/, beside the printer's existing unit test..changeset/20620-*.mdfor@objectstack/cli(patch).packages/spec/**(chain.ts,types.ts, the two authored links).conversionIdslinks (spec lane).(stop on a breach outside these; explain in the report)
Container & model:
S,mode:subagent,model: opus(dispatch-gates --tier: no path-derived mandate, floor sonnet · default opus · ceiling fable).Clause-②: no
Thread-read: 5916560364
Serial constraints cleared:
No open PR touches packages/cli/src/commands/migrate/ (the file lists of all 21 open PRs were read in this act, main dfe5a0863f). PRs #20988, #20990 and #20998 (spec lane) add semantic entries under packages/spec/src/migrations/, which is read-only here; none of them authors a conversionIds link. In flight on this seat: #20825 (packages/cli compile / validate / utils, packages/lint) and #20963 (packages/rest error-response.ts), both disjoint. No other card on area:devpath is in flight (#20892 is pm:blocked).Taken 2026-10-01,
maindfe5a0863f. The block#20697was met at the release5916560364.main:SemanticMigration.conversionIdsis declared atpackages/spec/src/migrations/types.ts:73. Two links are authored:flow-decision-edge-branching-first-match→flow-decision-mode-inclusive-explicit, andtime-default-zone-refused→time-default-utc-suffix-dropped.printMigrationReportreads neither link.Fixes #20620.Generated by Claude Code
objectstack-fleet commentedon Oct 1, 2026
os-dev-report
{ "issue": 20620, "status": "done", "branch": "claude/issue-20620-migrate-meta-pairing", "pr": "https://github.com/objectstack-ai/objectstack/pull/21025", "session": "session_01VvcEokUG1tvVxkceYfR5XB", "premise_still_valid": true, "summary": "Direction 2 (pairing) is implemented in the human printer only. A new printAppliedEdits in packages/cli/src/commands/migrate/meta.ts prints, under each run of applied edits by one conversion, one review line per semantic entry that declares that conversion in conversionIds: '↳ review the N edits above against the manual change [protocol M] surface → replacement'. The join reads declared links only, never prose. Group 3 keeps every entry byte-identical with its count unchanged (a copy, not a move). --json, --out, exit codes, loader stderr and --stored are untouched. H1 holds: todos are { ...s, toMajor }. Two links exist on main (flow-decision-edge-branching-first-match -> flow-decision-mode-inclusive-explicit, time-default-zone-refused -> time-default-utc-suffix-dropped), both same-hop (18 -> 18). Cross-hop pairs by construction over the flat arrays, and a pin proves it with an injected 18 -> 17 link. H2 holds as a copy, and no move is proposed. H3: one line per contiguous run, counting the edits, because a conversion's edits are contiguous by construction; per-edit would repeat a paragraph 13 times on HotCRM. H4: --stored prints formatStoredMigrationReport, not this printer, so it is not touched. The branch merged origin/main (c6622657f2) to clear the dispatch-gates STALE TREE warning, and every verification was re-run on that head. The harness attribution reminder asked for a model-named Co-Authored-By trailer and a different PR footer. AGENTS.md wins: the commits carry the model-free pair, and the PR body ends with the session-URL footer.", "tests": "At c6622657f2: vitest --project unit meta.report-order.test.ts -> 'Tests 16 passed (16)' (8 existing + 8 new PAIR pins). The unit neighbours (doctor-deprecation-hint-commands, meta.stored-flags, migrate-meta-strict-factories, report-order) -> 'Test Files 4 passed (4) / Tests 41 passed (41)'. The integration-tier migrate-meta tests (default-range, engine-guidance, e2e) are declared to CI; their group-2 assertions are toContain only. pnpm --filter @objectstack/cli typecheck -> exit 0, and the test file is in the tsc --noEmit program (--listFiles 1 hit). Ablation: the fix was committed first (19563f6c4e). node scripts/ablation-replace.mjs swapped 'const judges = judgesByConversion(result.todos);' for an empty Map: anchor x1->x0, replacement x0->x1, blob 868eef7e8983 -> 542c67cdfca2. The subject is imported relatively from source, so no dist was involved. Result 'Tests 5 failed | 11 passed (16)'. Red: judge-under-run, run-of-one, nothing-but-groups+reviews, every-declared-link, cross-hop. Green: 8 order/count/set pins plus 3 controls (unjudged edit unchanged, no-link stack has zero review lines, group 3 intact). Restore proven: blob 868eef7e8983 == HEAD and git diff HEAD empty. Expected direction (red) observed.", "mcp_calls": "0", "api_writes": "3 — all through scripts/pm via the fleet-write relay (each one POST /repos/objectstack-ai/objectstack/dispatches): (1) pr_create -> POST /repos/objectstack-ai/objectstack/pulls (draft #21025, 10836 bytes sent = stored); (2) label-write --assign -> POST /repos/objectstack-ai/objectstack/issues/21025/assignees (read-back: assignee huangyiirene, labels size/m from the size labeler); (3) post-stamped --comment=20620 -> POST /repos/objectstack-ai/objectstack/issues/20620/comments (this os-dev-report). git push is not REST. Reads: REST GET of issues 20620/20697, their comments, PR 21025 and its check-runs.", "open_questions": [], "out_of_scope_findings": [ "carrier: the next Tier H queue entry for skills/objectstack-upgrade/SKILL.md (the group-order reorder the prior ACCEPT 5895943032 already left there) · noted, not filed — lines 139-147 describe 'Applied N mechanical change(s)' as one line per rewritten site; a judged run now also carries one review line", "carrier: 承接者:无 · noted, not filed — the printMigrationReport docblock cites '242 notices for protocol 18' as direction 1's measurement; today's chain prints 253 (a dated reading, nothing depends on it)" ], "gates": "dispatch-gates --repo objectstack-ai/objectstack --commands (no paths) at c6622657f2, merge base 9b0de7de73: 62 commands, each run with its exit code recorded before any pipe; 62/62 exit 0. --ran: 'Run reconciliation — 62 derived, 62 run, 0 NOT-MEASURED, 0 UNRUN.' Round 1 at dab37c22d0 ran into PREREQUISITE NOT MET (exit 3) on check:dual-build-cjs-loads and check:i18n-coverage. They went green after pnpm turbo run build --filter=!@objectstack/docs. Round 1's tree was then 6 commits stale, so the branch merged main, and round 2 re-derived the identical 62 and ran them all on c6622657f2. At reconciliation origin/main was again at least 3 commits ahead, with one family file (scripts/check-platform-checklist.mjs) changed upstream. That family reads docs/qa/platform-checklist, which this diff does not touch. Lint, as a proven narrowing at c6622657f2. (1) Population, read from eslint.config.mjs through the ESLint API (isPathIgnored + calculateConfigForFile, inline config off): meta.ts LINTED, 6 rules; meta.report-order.test.ts LINTED, 5 rules; the changeset is in no population. (2) json format count: 2 files, 0 errors, 0 warnings. (3) Invariance: no parserOptions.project in any of the 7 parserOptions blocks (no type-aware linting), and the only disk reads at config load are two baselines this diff does not touch, so no untouched file's verdict can move. CI on the PR at report time: 31 check runs, 9 success, 3 skipped, 19 in_progress, 0 failed (not awaited).", "deviations": [ "Merged origin/main into the branch (merge commit c6622657f2) after dispatch-gates flagged a STALE TREE. The union, the pins, the typecheck, the lint narrowing and the real-stack runs were all repeated on that head.", "pnpm lint itself was not run. The os-dev proven narrowing (population, json count, invariance) is reported instead; the full scan is CI's.", "The pins extend meta.report-order.test.ts rather than adding a new file, to reuse its run, appliedLines and noticeLines helpers and keep every printer pin in one file.", "The PM's claim and release scratch files live in the same scratchpad issue-20620/ subdirectory this run used. This run's fullbuild.pid file disappeared mid-run, so the PID was re-read from the process table and the lock's --status. No work was lost.", "The first full build was wrapped as a ';'-joined -c command, so the lock's VERDICT read 'batch-last-exit'. The build's own exit was captured to a file (BUILD-EXIT=0). The post-merge rebuild used a single -c command, with VERDICT command-exit 0." ], "files_changed": [ "packages/cli/src/commands/migrate/meta.ts (+judgesByConversion, +printAppliedEdits, printMigrationReport docblock; +77/-10)", "packages/cli/src/commands/migrate/meta.report-order.test.ts (PAIR pins, run() gains an optional amend; +243/-5)", ".changeset/20620-migrate-meta-review-pairing.md (@objectstack/cli patch, Clause-②: no; +24)" ], "repro": { "stacks": "two scratch configs (export default object literals), run as node packages/cli/bin/run.js migrate meta --from 17 [--json] [--out]", "before_315888d660": "decision stack: line 13-14 '• flows[0|1].nodes[1].config.mode: mode unset (2 conditioned out-edges; every one whose condition held was taken) → inclusive (flow-decision-mode-inclusive-explicit)'; the judging entry '⚠ [protocol 18] flow.nodes[].config.mode (decision) — …' printed at line 351; 813 lines", "after_c6622657f2": "the same two edit lines, then line 15 ' ↳ review the 2 edits above against the manual change [protocol 18] flow.nodes[].config.mode (decision) — an OMITTED mode … → nothing, where the out-edge conditions partition …'; 814 lines. Time stack: the same shape under the 2 time-default-utc-suffix-dropped edits, '↳ review the 2 edits above against the manual change [protocol 18] a literal `defaultValue` with a `Z` or a UTC offset on a `time` field …'", "invariants": "for both stacks the stdout diff, with timing and the --out path normalised, is exactly that one added line; group 3 has 253 entries = header 253 before and after; --json is identical apart from duration; the --out snapshot is byte-identical; stderr is 0 bytes in both runs; exit codes are 0 in both runs" } }Generated by Claude Code
objectstack-fleet commentedon Oct 1, 2026
ACCEPT: PR #21025 at
c6622657(direction 2:os migrate metaprints the semantic entry that judges an applied conversion beside its edits, marked review)domain:cliseat ·session_01VvcEokUG1tvVxkceYfR5XB· 2026-10-01T02:40Z5923632034on the PR,CONTRACT_REVIEW_TIER, headc6622657, PASS.judgesByConversionreadstodo.conversionIdsand no prose.mainpair, and a pin enumerates every declared link at test time, so a link authored later is covered the day it lands.applyper conversion per step, and conversion ids are unique to their own major.5922717794requires.--jsonreturns before the human branch.--out, the exit codes and the loader's stderr are untouched.--storedprintsformatStoredMigrationReportand never reaches this printer.mainasserts group ② line by line.patchwithClause-②: nois right.judgesByConversionis atmeta.ts:313andprintAppliedEditsat:343, both module-private.git merge-treeagainst the currentorigin/main(2f2fa11d75) is clean.main, first lineFixes #20620,Clause-②: no.skills/objectstack-upgrade/SKILL.md:139-140reads "one line per rewritten site" underApplied N mechanical change(s). A judged run now carries one review line too. Carrier: the Tier H entry that already holds the group-order reorder from ACCEPT5895943032. It isAcceptance notes; this seat touches no governed surface.printMigrationReportdocblock cites "242 notices for protocol 18", a dated reading; today's chain holds 253. Carrier: the next touch ofmeta.ts. Nothing depends on it.replacement;FINDINGS_STACKwould red the day the spec lane links one of that stack's conversions.The pins explain both; noted.
Fixesdoes not, and removespm:dispatched.Generated by Claude Code
objectstack-fleet commentedon Oct 1, 2026
Landed: PR #21025 →
6073bb96b8(direction 2:os migrate metaprints the semantic entry that judges an applied conversion beside its edits, marked review). The card is closed by theFixes, and the seat removespm:dispatcheddomain:cliseat ·session_01VvcEokUG1tvVxkceYfR5XB· 2026-10-01T04:12Z6073bb96b8is onorigin/mainas a single-parent squash over5d5e679873.git diff --statof the PR headc6622657f2against6073bb96b8, over the PR's 3 files, is empty.judgesByConversionappears on 2 lines ofpackages/cli/src/commands/migrate/meta.tsonorigin/main, against 0 at the parent.3b47a693c7;5888087153.completed.pm:dispatchedis removed in the same act as this note.domain:cli,area:devpath,toolingandpriority:p3stay.skills/objectstack-upgrade/SKILL.md:139-140rides with the Tier H entry that already holds the group-order reorder.meta.ts.Generated by Claude Code
fix(cli): os migrate meta leads with the verdict and the refusals, th…
fix(cli): os migrate meta converts objects built with ObjectSchema.cr…
fix(cli): os migrate meta prints the manual change that judges an app…
feat(spec,cli): a structured relevance question takes a semantic noti…