Skip to content

Commit fde9ac1

Browse files
objectstack-devclaude
andcommitted
ci(spec-shape-gate): register the view-level provider 'api' retirement (PR 23160 -> objectui 12325) -- the positive control's second reading
Run 1 of the gate on this PR (empty registry) went red on exactly that retirement, in six objectui files. This commit registers it: five patterns, each a file or glob plus the TS code and the message fragment naming the retired arm, so the same diagnostics read as known and a new break in the same files stays red. Also rewords one message the cli-command-ids gate read as a quoted command phrase. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013zGKMG1cRedVzWtqGGGZW9
1 parent 1c3bc82 commit fde9ac1

2 files changed

Lines changed: 39 additions & 4 deletions

File tree

‎scripts/ci/spec-shape-gate.mjs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,9 +1140,9 @@ export function renderSummary({ sha, downstreamSha = null, commit = null, event
11401140
`⛔ The typecheck failed (exit ${status}) and **no diagnostic could be attributed to a file**.`,
11411141
'',
11421142
`That is not a shape break this gate can hand to anybody: the whole point of compiling a consumer is that the ` +
1143-
`objectstack change which moved the shape is identifiable from the objectui file that stopped compiling. Read the ` +
1144-
`job log -- the failure is upstream of the compiler (an install, a build, the spec's own build) or the compiler's ` +
1145-
`output shape moved. This run is exit 2: not a pass, not a shape break.`,
1143+
`change in objectstack which moved the shape is identifiable from the objectui file that stopped compiling. Read ` +
1144+
`the job log -- the failure is upstream of the compiler (an install, a build, the spec's own build) or the ` +
1145+
`compiler's output shape moved. This run is exit 2: not a pass, not a shape break.`,
11461146
);
11471147
} else {
11481148
const unknownRows = distinctRows(unknown);
Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,39 @@
11
{
22
"$comment": "Intentional spec retirements the Spec Shape Gate reads as `known` instead of red. One entry per retirement, written by the accepting seat when the downstream (objectui) card is filed, deleted when that card closes. Every entry carries exactly: retired, objectstack_pr, objectstack_commit (40-hex merge commit), downstream_card (owner/repo#N), registered_at (YYYY-MM-DD), matches (non-empty; each pattern names a repo-relative objectui `file` -- `*` within a segment, `**` across -- plus at least one of `code` (TS<digits>) or `message` (substring)). A file alone is refused. The reader, its grammar and its refusals: scripts/ci/spec-shape-gate.mjs (THE REGISTRY).",
3-
"retirements": []
3+
"retirements": [
4+
{
5+
"retired": "view-level data source provider 'api' (ViewDataSchema arm; ruling C on #23082, executed by PR #23160) -- the downstream still compares against the '\"api\"' literal, reads the arm's read/write keys, and casts test fixtures to its { data: { read } } shape",
6+
"objectstack_pr": 23160,
7+
"objectstack_commit": "1912af47ba6e3b250f7c717fea0d56e181029b9c",
8+
"downstream_card": "objectstack-ai/objectui#12325",
9+
"registered_at": "2026-10-13",
10+
"matches": [
11+
{
12+
"file": "packages/**",
13+
"code": "TS2367",
14+
"message": "'\"api\"'"
15+
},
16+
{
17+
"file": "packages/**",
18+
"code": "TS2678",
19+
"message": "'\"api\"'"
20+
},
21+
{
22+
"file": "packages/core/src/adapters/resolveDataSource.ts",
23+
"code": "TS2339",
24+
"message": "does not exist on type 'never'"
25+
},
26+
{
27+
"file": "packages/plugin-gantt/src/ObjectGantt.tsx",
28+
"code": "TS2339",
29+
"message": "does not exist on type 'never'"
30+
},
31+
{
32+
"file": "packages/types/src/__tests__/*.test.ts",
33+
"code": "TS2352",
34+
"message": "data: { read: Record<string, unknown>; }"
35+
}
36+
]
37+
}
38+
]
439
}

0 commit comments

Comments
 (0)