|
| 1 | +// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license. |
| 2 | + |
| 3 | +/** |
| 4 | + * [#27425] The SQL-driver half of the pin, over `private` federated objects |
| 5 | + * whose remote rows carry an owner. |
| 6 | + * |
| 7 | + * - The remote column is literally `owner_id` and `fields` do not declare it: |
| 8 | + * the driver serves it, but the registered field is the platform's injected |
| 9 | + * anchor and nothing declared says the column exists. Before the fix that |
| 10 | + * read as "ownership contributes nothing" (`null`), so a member read every |
| 11 | + * row; now the scope narrows to none. |
| 12 | + * - `external.columnMap` maps the remote owner column onto `owner_id`: the map |
| 13 | + * is declared metadata, the SQL driver applies it, and the member reads own |
| 14 | + * rows only, as with a declared field. |
| 15 | + * - `owner_id` declared in `fields`: the control, own rows only. |
| 16 | + * |
| 17 | + * Real `ObjectQL`, real `SqlDriver` on `better-sqlite3`, the real sharing |
| 18 | + * middleware: the registry's injection, the driver's remap and the composed |
| 19 | + * filter are each the shipped code, not a fixture of it. |
| 20 | + */ |
| 21 | + |
| 22 | +import { describe, it, expect, beforeAll, afterAll } from 'vitest'; |
| 23 | +import { ObjectQL } from '@objectstack/objectql'; |
| 24 | +import { SqlDriver } from '@objectstack/driver-sql'; |
| 25 | + |
| 26 | +import { SharingService } from './sharing-service.js'; |
| 27 | +import { buildSharingMiddleware } from './sharing-plugin.js'; |
| 28 | +import { hasPhantomOwnerAnchor } from './federated-phantom-anchors.js'; |
| 29 | + |
| 30 | +const MEMBER = 'u_member'; |
| 31 | +const ADMIN = 'u_admin'; |
| 32 | + |
| 33 | +/** The remote table: its owner column is called `assignee`. */ |
| 34 | +const REMOTE = { |
| 35 | + name: 'remote_rows', |
| 36 | + fields: { |
| 37 | + id: { type: 'text', name: 'id', label: 'Id', primary: true }, |
| 38 | + name: { type: 'text', name: 'name', label: 'Name' }, |
| 39 | + assignee: { type: 'text', name: 'assignee', label: 'Assignee' }, |
| 40 | + }, |
| 41 | +}; |
| 42 | + |
| 43 | +const SHARE_FIELDS: Record<string, Record<string, unknown>> = { |
| 44 | + id: { type: 'text', name: 'id', label: 'Id', primary: true }, |
| 45 | + object_name: { type: 'text', name: 'object_name', label: 'Object' }, |
| 46 | + record_id: { type: 'text', name: 'record_id', label: 'Record' }, |
| 47 | + recipient_type: { type: 'text', name: 'recipient_type', label: 'Recipient type' }, |
| 48 | + recipient_id: { type: 'text', name: 'recipient_id', label: 'Recipient' }, |
| 49 | + access_level: { type: 'text', name: 'access_level', label: 'Access' }, |
| 50 | +}; |
| 51 | + |
| 52 | +/** A second remote table whose owner column is literally `owner_id`. */ |
| 53 | +const REMOTE_OWNED = { |
| 54 | + name: 'remote_owned', |
| 55 | + fields: { |
| 56 | + id: { type: 'text', name: 'id', label: 'Id', primary: true }, |
| 57 | + name: { type: 'text', name: 'name', label: 'Name' }, |
| 58 | + owner_id: { type: 'text', name: 'owner_id', label: 'Owner' }, |
| 59 | + }, |
| 60 | +}; |
| 61 | + |
| 62 | +const binding = { remoteName: REMOTE.name, columnMap: { assignee: 'owner_id' } }; |
| 63 | + |
| 64 | +/** Served but undeclared: no map, no field, the registry injects its anchor. */ |
| 65 | +const SERVED_UNDECLARED = { |
| 66 | + name: 'ext_owned', |
| 67 | + label: 'External owned rows', |
| 68 | + sharingModel: 'private', |
| 69 | + external: { remoteName: REMOTE_OWNED.name }, |
| 70 | + fields: { name: { type: 'text', label: 'Name' } }, |
| 71 | +}; |
| 72 | + |
| 73 | +/** `owner_id` undeclared, but the columnMap names the remote owner column. */ |
| 74 | +const MAPPED = { |
| 75 | + name: 'ext_rows', |
| 76 | + label: 'External rows', |
| 77 | + sharingModel: 'private', |
| 78 | + external: binding, |
| 79 | + fields: { name: { type: 'text', label: 'Name' } }, |
| 80 | +}; |
| 81 | + |
| 82 | +/** The control: `owner_id` declared, the author vouches for the column. */ |
| 83 | +const DECLARED = { |
| 84 | + name: 'ext_rows_declared', |
| 85 | + label: 'External rows (declared owner)', |
| 86 | + sharingModel: 'private', |
| 87 | + external: binding, |
| 88 | + fields: { |
| 89 | + name: { type: 'text', label: 'Name' }, |
| 90 | + owner_id: { type: 'lookup', reference: 'sys_user', label: 'Owner' }, |
| 91 | + }, |
| 92 | +}; |
| 93 | + |
| 94 | +describe('[#27425] a private SQL federated object whose remote rows carry an owner', () => { |
| 95 | + let driver: SqlDriver; |
| 96 | + let ql: ObjectQL; |
| 97 | + |
| 98 | + beforeAll(async () => { |
| 99 | + driver = new SqlDriver({ |
| 100 | + client: 'better-sqlite3', |
| 101 | + connection: { filename: ':memory:' }, |
| 102 | + useNullAsDefault: true, |
| 103 | + }); |
| 104 | + ql = new ObjectQL(); |
| 105 | + ql.registerDriver(driver as never, true); |
| 106 | + await ql.init(); |
| 107 | + |
| 108 | + await driver.initObjects([ |
| 109 | + REMOTE as never, |
| 110 | + REMOTE_OWNED as never, |
| 111 | + { name: 'sys_record_share', fields: SHARE_FIELDS } as never, |
| 112 | + ]); |
| 113 | + await driver.create(REMOTE.name, { id: 'r_mine', name: 'Mine', assignee: MEMBER }); |
| 114 | + await driver.create(REMOTE.name, { id: 'r_theirs', name: 'Theirs', assignee: ADMIN }); |
| 115 | + await driver.create(REMOTE_OWNED.name, { id: 'r_mine', name: 'Mine', owner_id: MEMBER }); |
| 116 | + await driver.create(REMOTE_OWNED.name, { id: 'r_theirs', name: 'Theirs', owner_id: ADMIN }); |
| 117 | + |
| 118 | + ql.registerObject({ name: 'sys_record_share', label: 'Record share', isSystem: true, fields: SHARE_FIELDS } as never); |
| 119 | + for (const object of [SERVED_UNDECLARED, MAPPED, DECLARED]) { |
| 120 | + ql.registerObject(object as never); |
| 121 | + // What the schema sync does for a federated object: bind it, no DDL. |
| 122 | + driver.registerExternalObject(ql.getSchema(object.name) as never); |
| 123 | + } |
| 124 | + ql.registerMiddleware(buildSharingMiddleware(new SharingService({ engine: ql as never })) as never, { object: '*' }); |
| 125 | + }); |
| 126 | + |
| 127 | + afterAll(async () => { |
| 128 | + await driver?.disconnect?.(); |
| 129 | + }); |
| 130 | + |
| 131 | + const memberReads = async (object: string): Promise<string[]> => { |
| 132 | + const rows = (await ql.find(object, { context: { userId: MEMBER } } as never)) as Array<{ id: string }>; |
| 133 | + return rows.map((r) => r.id).sort(); |
| 134 | + }; |
| 135 | + |
| 136 | + it('PREMISE: the driver serves owner_id on all three, and only the unmapped, undeclared one is the injected anchor', async () => { |
| 137 | + for (const object of [SERVED_UNDECLARED.name, MAPPED.name, DECLARED.name]) { |
| 138 | + const served = (await driver.find(object, {} as never)) as Array<Record<string, unknown>>; |
| 139 | + expect(served.map((r) => [r.id, r.owner_id]).sort()).toEqual([ |
| 140 | + ['r_mine', MEMBER], |
| 141 | + ['r_theirs', ADMIN], |
| 142 | + ]); |
| 143 | + } |
| 144 | + expect(hasPhantomOwnerAnchor(ql.getSchema(SERVED_UNDECLARED.name))).toBe(true); |
| 145 | + expect(hasPhantomOwnerAnchor(ql.getSchema(MAPPED.name))).toBe(false); |
| 146 | + expect(hasPhantomOwnerAnchor(ql.getSchema(DECLARED.name))).toBe(false); |
| 147 | + }); |
| 148 | + |
| 149 | + it('owner_id served but neither declared nor mapped: the member reads no row (it read 2 of 2 before)', async () => { |
| 150 | + expect(await memberReads(SERVED_UNDECLARED.name)).toEqual([]); |
| 151 | + }); |
| 152 | + |
| 153 | + it('columnMap → owner_id with no declared field: own rows only (it read 2 of 2 before)', async () => { |
| 154 | + expect(await memberReads(MAPPED.name)).toEqual(['r_mine']); |
| 155 | + }); |
| 156 | + |
| 157 | + it('ANTI-VACUITY: owner_id declared over the same table reads own-only', async () => { |
| 158 | + expect(await memberReads(DECLARED.name)).toEqual(['r_mine']); |
| 159 | + }); |
| 160 | +}); |
![objectstack-fleet[bot]](https://avatars.githubusercontent.com/u/254823548?v=4&size=40){kind=avatar}
0 commit comments