refactor(app-shell): move ObjectView's view management handlers into a sibling hook (slice 11b) (#26542)

<!-- claude-projects-attribution: {"github_login":"os-steve"} -->
_Requested by **Steve** · [project
thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9VtKf3F9dzJPJM4RRtABaEc)_


Fixes #25992 (slice 11b, the last slice of the move-only split; slices 1
to 11a landed as #26152, #26233, #26310, #26336, #26353, #26374, #26396,
#26412, #26434 and #26492). With this PR, every region of the seam table
in #26336 that was marked for a slice has moved; what stays in
`ObjectView.tsx` is the shared state (A, C, F, J), the panel and dialog
state, the hook calls and the JSX.

Clause-②: no
Metadata-protocol: none

## What moved

Base `a2e4b760` (the branch's merge of `main` at `73683ee1`, slice 11a
merged). `ui/packages/app-shell/src/views/ObjectView.tsx` is 1480 lines
there. Three blocks of `ObjectViewInner` move verbatim into one custom
hook, `useObjectViewViewCrud`, in the new sibling module
`objectViewViewCrud.tsx`. Every input is passed as an argument, typed
from its source (no `any`), and the component destructures the 13
handlers under their original names. No identifier is renamed and no
context is added.

- **B: the view-config save and create doors** (lines 228–371). The
objectui#12504 note on the retired `persistViewPatch`, the objectui#4155
block comment on the absent `persistViewFilter`, `handleViewConfigSave`
and `handleViewCreate`, with their docblocks and dependency lists.
- **B: `handleViewUpdate`** (lines 789–796), the panel's draft field
update, with its docblock.
- **I: view switching and the view-tab CRUD callbacks** (lines
798–1002). `handleViewChange`, the mobile view switcher items and
`useMobileViewSwitcherRegistration`, `handleCreateView`,
`handleViewAction`, `isSavedView`, `handleRenameView`,
`handleDeleteView`, `handlePinView`, `handleSetDefaultView`, the
objectui#12418 docblock and `handleReorderViews`, `handleConfigView` and
`handleAddView`.

The hook is called where `handleViewUpdate` stood, after
`useObjectViewListUrlState`. It returns `handleViewConfigSave`,
`handleViewCreate`, `handleViewUpdate`, `handleViewChange`,
`handleCreateView`, `handleViewAction`, `handleRenameView`,
`handleDeleteView`, `handlePinView`, `handleSetDefaultView`,
`handleReorderViews`, `handleConfigView` and `handleAddView`.
`isSavedView` and the mobile switcher items stay inside the hook, their
only readers.

**What stays.** The five `useState` calls of B (`showViewConfigPanel`,
`viewConfigPanelMode`, `showCreateViewDialog`, `manageViewsOpen`,
`viewDraft`, lines 217–226) stay in the component. `activeView` (F, line
758) reads `viewDraft` before the hook's inputs exist, and the JSX reads
the panel and dialog flags. The hook receives the setters.

**Hook order.** `handleViewConfigSave` and `handleViewCreate` (two
`useCallback`s) used to run before the record count state, `useAuth` and
every hook down to `useObjectViewListUrlState`. They now run after it,
inside the new hook, right before `handleViewUpdate`. They could not be
called at their old spot: their bodies call `setRefreshKey`, declared at
line 401, so passing it to a hook there would hit the TDZ. Nothing
between their old and new positions reads them (measured: no reference
between lines 372 and 788). The hooks of `handleViewUpdate` and I keep
their order and position. The seat's ruling allows this shift when
stated.

### Imports

Each import moves with its only readers: `formatMetadataError`,
`viewTabLabel`, `persistRuntimeMetadata` / `createRuntimeMetadata` /
`viewEnvelope`, `PREVIEW_QUERY_FLAG` / `PREVIEW_QUERY_VALUE`,
`useMobileViewSwitcherRegistration`, `MobileViewSwitcherItem`,
`isSavedViewId`, `buildAddViewSpec`, `setDefaultViewPatches`,
`buildViewConfigSaveBody` and `dispatchViewPatches`. These names are
still re-exported from `ObjectView.tsx` where they were before, and
those lines are unchanged. Names the component still reads elsewhere
(`useCallback`, `useMemo`, `toast`, `VIEW_TYPE_ICONS`) are imported by
the module as well. Nothing new is exported from `ObjectView.tsx`, and
the package entry is untouched. `ObjectView.tsx` goes from 1480 to 1151
lines.

Move-only proof: the multiset of non-blank lines of the base
`ObjectView.tsx` is contained in the new `ObjectView.tsx` plus the
module, except 9 lines. Every one of the 9 is an import line or an
import-list entry that lost a moved name: the `PREVIEW_QUERY_FLAG` and
`PREVIEW_QUERY_VALUE` entries, the `../utils/viewIdentity.js` import
(replaced by its trimmed form), the `buildAddViewSpec`,
`setDefaultViewPatches` and `buildViewConfigSaveBody` entries of the
`./objectViewTabs.js` list, and the three-line `./objectViewOptions.js`
import of `dispatchViewPatches`. The module imports each of those names
itself. The added lines are:
- the trimmed import and the new import;
- the module header and imports;
- the hook signature and parameter types;
- the `return`;
- in `ObjectView.tsx`, the call with its destructuring and a two-line
comment.

## Test edits

Five source-scan readers move to the file that now holds what they read.
Each edit is a path or file-list change, and no assertion changed:

1. `writeRefusalCensus-11583.test.ts`: the six `LEDGER` rows for
`handleViewConfigSave`, `handleViewCreate`, `handleRenameView`,
`handleDeleteView`, `handlePinView` and `handleSetDefaultView` change
`file: 'ObjectView.tsx'` to `file: 'objectViewViewCrud.tsx'`. Callees,
counts, pins and reasons are unchanged. The census walks `views/`, so it
finds the sites in the new file.
2. `ui/scripts/__tests__/check-i18n-call-site-keys.test.ts`: the
`deleteViewConfirm` row of the deleted-fallbacks list →
`packages/app-shell/src/views/objectViewViewCrud.tsx`. Its absent and
present markers are unchanged.
3. `ObjectView.overlayPatchOnly.test.ts`: the joined `objectViewCode`
list gains `'objectViewViewCrud.tsx'`. The control's
`handleViewConfigSave` and `persistRuntimeMetadata` reads are there now.
4. `view-filter-fold.ratchet.test.ts`: the joined `objectViewSrc` list
gains `objectViewViewCrud.tsx`, for the `handleViewConfigSave`
initializer the ratchet parses.
5. `ObjectView.unboundAdapterCall.test.ts`: the detach-then-call ratchet
reads `ObjectView.tsx` and `objectViewViewCrud.tsx` joined, the same way
as the two above. Without this edit it would still pass, but it would no
longer read `handleSetDefaultView` and `handlePinView`, the handlers it
guards.

Edit 5 is the one the seat's list did not name. It is listed for the
same reason as the others: the scan's subject moved.

## Seam table rows this PR changes (measured on `a2e4b760`)

The full table (regions A to Q) is in #26336.

| # | Concern | Lines on `a2e4b760` | Reads | Read by | Slice |
|---|---|---|---|---|---|
| B (state) | Panel and dialog open state, `viewDraft` | 217–226 | — |
F, H, I, N, O, P, Q | stays (shared state) |
| B | `handleViewConfigSave`, `handleViewCreate` and their notes |
228–371 | A, C (`setRefreshKey`) | Q | **11b, this PR** |
| B | `handleViewUpdate` | 789–796 | B (`setViewDraft`), F (`baseView`)
| Q | **11b, this PR** |
| I | View switching, mobile switcher, view-tab CRUD callbacks |
798–1002 | A, B, C, F | N, Q | **11b, this PR** |

## Verification

The full readings are in the os-dev-report comment on the card:
- app-shell `type-check` after rebuilding its dependency closure;
- 208 test files: every `ObjectView.*` test in `views/` (the view CRUD,
refusal, create-view, default-view, view-config save and mobile FAB
tests among them), the `AppContent*` tests, and every other test that
reads `ObjectView.tsx` as source, including the five re-pointed ones;
- eslint on the touched files;
- the derived dispatch gates;
- a Console build.

## Acceptance notes

- eslint: 0 errors, and no new `no-explicit-any`. `ObjectView.tsx` plus
the module report 83 warnings, against 80 for the base `ObjectView.tsx`
alone.
- Added: 10 `react-hooks/exhaustive-deps` warnings in the module, and 1
existing one (the `objectName` warning on `handleDeleteView`) now also
names `setRefreshKey`. Each added warning names a state setter that is
now a hook parameter (`setRefreshKey`, `setViewDraft`,
`setShowViewConfigPanel`, `setViewConfigPanelMode`,
`setShowCreateViewDialog`). The rule treats a `useState` setter as
stable only in the component that declares it. The dependency lists are
kept verbatim, because adding the setters would change code; the setters
are stable, so behaviour is the same. Slice 8 drew the same class of
warning at its hook boundary.
- Gone: the 2 `exhaustive-deps` warnings on `handleViewChange`, the 4
`preserve-manual-memoization` skips on these handlers, and 1
`react-hooks/immutability` finding (`handleViewConfigSave` reading
`setRefreshKey` before its declaration).
- Unchanged: the other `exhaustive-deps` warnings (`listPrefs` in
`handleReorderViews`, and the two on the `objectDef` effect) only moved
lines.
  - Net: 80 + 10 − 2 − 4 − 1 = 83.
- The test edits add no warning.

Changeset: `.changeset/25992-objectview-view-crud-split.md` (patch,
`@object-ui/app-shell`).

---
🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01QciHBvFJXnhZqXmdqpDtpz

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: objectstack-fleet[bot]

.changeset/25992-objectview-view-crud-split.md

@@ -0,0 +1,12 @@
+---
+'@object-ui/app-shell': patch
+---
+
+refactor(app-shell): the Console `ObjectView`'s view management handlers move into a sibling hook
+
+Clause-②: no
+Metadata-protocol: none
+
+The view-config panel's save and create handlers, the draft field update, view switching, the mobile view switcher registration and the view-tab CRUD callbacks (rename, delete, pin, set default, reorder, configure, add) move verbatim out of `ObjectViewInner` in `views/ObjectView.tsx` into `useObjectViewViewCrud` in `objectViewViewCrud.tsx`. The panel and dialog state stays in the component, which passes every input in and reads the returned handlers. No logic, name or rendered output changes, and the package entry is unchanged.
+
+What to do: nothing.

ui/packages/app-shell/src/views/ObjectView.overlayPatchOnly.test.ts

@@ -308,7 +308,7 @@ describe('objectui#5233 — what must NOT be narrowed', () => {
  */
 describe('objectui#12504 census — the toolbar-to-view write family is retired', () => {
     const here = path.dirname(fileURLToPath(import.meta.url));
-    const objectViewCode = stripComments(['ObjectView.tsx', 'objectViewListRenderer.tsx'].map((file) => readFileSync(path.join(here, file), 'utf8')).join('\n'));
+    const objectViewCode = stripComments(['ObjectView.tsx', 'objectViewListRenderer.tsx', 'objectViewViewCrud.tsx'].map((file) => readFileSync(path.join(here, file), 'utf8')).join('\n'));
     const dataSourceCode = stripComments(
         readFileSync(path.join(here, '..', '..', '..', 'types', 'src', 'data.ts'), 'utf8'),
     );

ui/packages/app-shell/src/views/ObjectView.tsx

@@ -188,10 +188,10 @@ describe('set as default (#4463)', () => {
 
 describe('the detach-then-call pattern stays gone (ratchet)', () => {
   it('ObjectView.tsx never assigns an adapter method to a local', () => {
-    const source = readFileSync(
-      fileURLToPath(new URL('./ObjectView.tsx', import.meta.url)),
+    const source = ['./ObjectView.tsx', './objectViewViewCrud.tsx'].map((file) => readFileSync(
+      fileURLToPath(new URL(file, import.meta.url)),
       'utf8',
-    );
+    )).join('\n');
 
     // Comments are stripped FIRST, and that is not a detail: the fix's own
     // docblock quotes the broken line verbatim to explain it, so a scan over the

ui/packages/app-shell/src/views/ObjectView.unboundAdapterCall.test.ts

@@ -43,7 +43,7 @@ const here = path.dirname(fileURLToPath(import.meta.url));
 const objectViewPath = path.join(here, 'ObjectView.tsx');
 const widgetsPath = path.join(here, 'metadata-admin/widgets.tsx');
 
-const objectViewSrc = [objectViewPath, path.join(here, 'objectViewListRenderer.tsx')].map((file) => readFileSync(file, 'utf8')).join('\n');
+const objectViewSrc = [objectViewPath, path.join(here, 'objectViewListRenderer.tsx'), path.join(here, 'objectViewViewCrud.tsx')].map((file) => readFileSync(file, 'utf8')).join('\n');
 const widgetsSrc = readFileSync(widgetsPath, 'utf8');
 
 /**

ui/packages/app-shell/src/views/objectViewViewCrud.tsx

@@ -88,32 +88,32 @@ const LEDGER: Row[] = [
     reason: 'Issues one `updateView` per patch and hands every promise back; set-as-default and reorder await them and answer for the refusal.',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handleViewConfigSave', callee: 'persistRuntimeMetadata', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handleViewConfigSave', callee: 'persistRuntimeMetadata', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.viewWriteRefusal-11583.test.tsx',
     reason: 'The view-config panel\'s edit Save: a toast with the door\'s message, and the panel is told the save failed, so it stays dirty (objectui#11583).',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handleViewCreate', callee: 'createRuntimeMetadata', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handleViewCreate', callee: 'createRuntimeMetadata', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.createViewRefusal-11578.test.tsx',
     reason: 'Create View: a toast with the door\'s message, and the dialog stays open (objectui#11578).',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handleRenameView', callee: 'updateView', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handleRenameView', callee: 'updateView', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.viewWriteRefusal-11583.test.tsx',
     reason: 'Rename: the translated `objectViewActions.renameFailed` title, with the door\'s message as the description (objectui#12417).',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handleDeleteView', callee: 'deleteView', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handleDeleteView', callee: 'deleteView', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.viewWriteRefusal-11583.test.tsx',
     reason: 'Delete: the translated `objectViewActions.deleteFailed` title, with the door\'s message as the description (objectui#12398).',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handlePinView', callee: 'updateView', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handlePinView', callee: 'updateView', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.viewWriteRefusal-11583.test.tsx',
     reason: 'Pin and unpin: a toast with the door\'s message (objectui#11583).',
   },
   {
-    file: 'ObjectView.tsx', symbol: 'handleSetDefaultView', callee: 'dispatchViewPatches', calls: 1,
+    file: 'objectViewViewCrud.tsx', symbol: 'handleSetDefaultView', callee: 'dispatchViewPatches', calls: 1,
     kind: 'surfaces', pin: 'ObjectView.viewWriteRefusal-11583.test.tsx',
     reason: 'Set as default: a toast with the door\'s message; it was a bare untranslated literal with no description until the objectui#11583 patch round.',
   },

ui/packages/app-shell/src/views/view-filter-fold.ratchet.test.ts

@@ -1088,7 +1088,7 @@ export const A = (name: string, label: string, n: number) => {
         "t('marketplace.detail.reseedLocalSuccess', { inserted, updated })",
       ],
       [
-        'packages/app-shell/src/views/ObjectView.tsx',
+        'packages/app-shell/src/views/objectViewViewCrud.tsx',
         // Tight on purpose: the file still holds a legitimate *computed*
         // `defaultValue` ending in the same sentence (line ~1657), and a marker
         // loose enough to catch that one would fail for the wrong reason.