Skip to content

Commit f3d1666

Browse files
committed
fix(lint): the validateFilterTokens registration comment states the runtime's refusal
The comment above the rule's registration in authoring-rules.ts said an unresolvable filter placeholder reaches the data engine as a literal, matches nothing, and the surface renders empty with no error. The data engine refuses such a query (FILTER_TOKEN_UNKNOWN, 400). The comment now says so and keeps the silent-zero history it was written against, in the past tense. Claude-Session: https://claude.ai/code/session_019oFY6Hi35J7atvgVFnmoaK Co-authored-by: Claude <noreply@anthropic.com>
1 parent 6be194c commit f3d1666

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎packages/lint/src/authoring-rules.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -914,9 +914,10 @@ export const AUTHORING_RULES: readonly AuthoringRule[] = [
914914
'saves, a rollout decision over stored tenant rows the in-repo corpus does not measure.',
915915
run: (stack) => validateDashboardWidgetOptions(stack),
916916
},
917-
// #3574 — a filter value like `{current_user}` resolves in no vocabulary,
918-
// reaches the data engine as a literal and matches nothing. The surface
919-
// renders empty with no error, and a silent zero is indistinguishable from a
917+
// #3574 — a filter value like `{current_user}` resolves in no vocabulary. The
918+
// data engine refuses a query carrying it (`FILTER_TOKEN_UNKNOWN`, 400). When
919+
// #3574 was filed it reached the engine as a literal and matched nothing: the
920+
// surface rendered empty with no error, a silent zero indistinguishable from a
920921
// genuine one at review time.
921922
{
922923
name: 'validateFilterTokens',

0 commit comments

Comments
 (0)