Repository navigation
Commit ee0e115
docs: default record page remedies name the other package's page, not the whole package (#23831)
Fixes #23553
Clause-②: no
## What changed
The package registry's `DEFAULT_RECORD_PAGE_CONFLICT` remedy already
says "compose the deployment without the other package's page". Three
sibling texts still told the author (or an AI) to drop the whole
package. They now say the same thing as the registry, with no option
name, package name or tracker number:
| Site | Before | After |
|---|---|---|
| `packages/metadata-protocol/src/protocol.ts`: the save door's refusal
(remedy clause only) | "…stays the default unless the deployment is
composed without that package." | "…stays the default unless the
deployment is composed without that package's page." |
| `packages/spec/src/ui/page.zod.ts`: `PageSchema.isDefault` TSDoc |
"…or compose the deployment without the package that ships the other." |
"…or compose the deployment without the other package's page." |
| `packages/spec/src/api/error-code-ledger.zod.ts`: source comment |
"…or composing the deployment without the other package." | "…or
composing the deployment without the other package's page." |
The save door's pin
(`packages/objectql/src/default-record-page-save-door.test.ts`) moves to
the new text in the same commit. It is changed, not deleted.
**The coupling.** `AppPlugin`'s `private bundle: any` gets a doc comment
naming its readers outside the class. I chose this over a public
readonly accessor because it is smaller and adds no public surface.
Measuring the readers turned up three of them, not the one the card
names: `stackDeclaresOrganizationRecordPage` (`@objectstack/core`), the
translations check in `@objectstack/cli`'s `serve.ts`, and
`graft-runtime-hooks.ts`. The comment names all three.
Changeset: one file, `patch` for `@objectstack/spec` (it ships
`src/**/*.zod.ts`), `@objectstack/metadata-protocol` (the refusal string
is in `dist/index.js`) and `@objectstack/runtime`. For runtime I
measured the built `dist/index.d.ts` and `dist/index.d.cts`: both carry
the new comment, so the shipped text changes.
## Verification (head `be4b60867`)
- Build: `turbo run build` for spec, metadata-protocol and runtime plus
their closure: 31/31 tasks, `VERDICT command-exit 0`.
- `pnpm --filter @objectstack/objectql exec vitest run --maxWorkers=2
src/default-record-page-save-door.test.ts`: 34/34 passed, run against
the rebuilt `metadata-protocol` dist. The old remedy text occurs 0 times
in `dist/index.js`, so the moved pin is reading the new string.
- Typecheck for `@objectstack/objectql`,
`@objectstack/metadata-protocol` and `@objectstack/runtime`: exit 0.
- `pnpm --filter @objectstack/spec check:generated`: all 14 generated
artifacts are up to date, `check:docs` included.
- Derived gate list (`dispatch-gates --commands`): 93 families. 92 exit
0. `check:dual-build-cjs-loads` exited 3 (PREREQUISITE NOT MET: it needs
a full `pnpm build`), so it was NOT MEASURED locally and CI runs it.
`check-engine-split-ratio` and `check-plugin-teardown-shape --self-test`
first refused on the shallow clone; after deepening, both exit 0.
`--ran` reconciliation: 92 run, 1 NOT-MEASURED, 0 UNRUN.
## Acceptance notes
- The D3 entry `18.page-default-record-page-one-per-object-refused.ts`
already says "compose the deployment without that package's page", which
matches the new wording, so it is left as is.
- Nothing about refusals changes: `code`, `status`, `object` and
`holders` are the same, and no `.describe()` changed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01CN3bgHivgMGBHWTNUbYCDp
---
_Generated by [Claude
Code](https://claude.ai/code/session_01CN3bgHivgMGBHWTNUbYCDp)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 3c080a6 commit ee0e115
6 files changed
Lines changed: 32 additions & 5 deletions
File tree
- .changeset
- packages
- metadata-protocol/src
- objectql/src
- runtime/src
- spec/src
- api
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21757 | 21757 | | |
21758 | 21758 | | |
21759 | 21759 | | |
21760 | | - | |
| 21760 | + | |
21761 | 21761 | | |
21762 | 21762 | | |
21763 | 21763 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
153 | 163 | | |
154 | 164 | | |
155 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
946 | 946 | | |
947 | 947 | | |
948 | 948 | | |
949 | | - | |
| 949 | + | |
950 | 950 | | |
951 | 951 | | |
952 | 952 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1871 | 1871 | | |
1872 | 1872 | | |
1873 | 1873 | | |
1874 | | - | |
1875 | | - | |
| 1874 | + | |
| 1875 | + | |
1876 | 1876 | | |
1877 | 1877 | | |
1878 | 1878 | | |
| |||
0 commit comments