Repository navigation
Commit e81cae0
docs(changeset): the two pending console changesets count and mark all ten declared-breaking entries each (deliberate correction) (#23173)
Fixes #23136
Clause-②: no (published changelog text; no accept set or public surface
widens)
## What this does
Two pending `@objectstack/console` changesets get corrected in place:
`.changeset/console-20c6d351ad74.md` and
`.changeset/console-f0268ad78485.md`. In each one:
- the count line reads 10 (it read 6 and 4);
- the entries the old digest left unmarked carry the uniform
`**BREAKING**` marker: 4 in the first file, 6 in the second, 10 in all.
Both files are unconsumed. `.changeset/pre.json` is `mode: pre`, `tag:
next`, with 0 consumed changesets, read on `origin/main` `dc93781c1`. So
whatever they say when the Version Packages PR merges ships in
`@objectstack/console`'s CHANGELOG.
The 12 replaced lines are the digest's own output, copied line for line.
`scripts/objectui-changeset-digest.mjs` on `main` (the digest as of PR
#23131) was re-run over each file's objectui range into a scratch file.
I diffed that output against the committed file: it differs on exactly
these 12 lines and on the ADR-0087 disposition comment, and nowhere
else. The disposition comment was answered by hand, and the digest emits
only its `TODO` placeholder there. So the comment stays as committed and
the bump is not re-run.
The diff has no new changeset, no `CHANGELOG.md`, no
`content/docs/releases/`, no `.changeset/pre.json` and no code: +12 /
-12 over 2 files. I measured every edited file at base `dc93781c1` and
head `6447f32ec` with an md5 of the extracted lines. The frontmatter
bump block and the ADR-0087 disposition comment are byte-identical, and
there is still exactly one `adr-0087:` marker per file:
| file | ADR-0087 comment, md5 (base = head) | frontmatter, md5 (base =
head) |
|:--|:--|:--|
| `console-20c6d351ad74.md` (lines 49-90, 42 lines) |
`4d8165bda53cc2211ebc873b21a0dc8a` | `7f9512041627f495063dfc6b2bea2dc2`
|
| `console-f0268ad78485.md` (lines 120-152, 33 lines) |
`e503fdd7341c8ee1378fe8214dd7afbd` | `7f9512041627f495063dfc6b2bea2dc2`
|
Neither file carries a `Clause-②` line, at base or at head. A
raw-control-byte scan of both files finds nothing.
## The measurement, re-run on `main`
The objectui input is a full, non-shallow clone of
`objectstack-ai/objectui` (`git rev-parse --is-shallow-repository`
answers `false`). All four endpoints resolve to commits. The shared
sibling checkout is shallow and does not hold `20c6d351ad74` or
`a58626c88dc8`, so it was not used.
```
node scripts/objectui-changeset-digest.mjs --from 47b1f0b --to 20c6d35 --objectui-root OBJECTUI_CLONE --out SCRATCH/digest-20c6.md
exit 0, bump minor
→ 33 releasing changeset(s), 10 breaking (0 declared major, 10 annotated), 0 release-nothing, 1 commit(s) without a changeset
node scripts/objectui-changeset-digest.mjs --from a58626c --to f0268ad --objectui-root OBJECTUI_CLONE --out SCRATCH/digest-f026.md
exit 0, bump minor
→ 173 releasing changeset(s), 10 breaking (0 declared major, 10 annotated), 2 release-nothing, 4 commit(s) without a changeset
→ 1 of 175 changeset(s) added in this range no longer exist at f0268ad … the account above is complete.
```
Both counts match the card (10 and 10), so no count differs from it.
**Control: the producer of the under-count.** I ran the digest as it
stood before the two repairs, over the same ranges and the same clone.
The version at `c9b5b24b0` (before PR #23131) and the one at `46064dfa0`
(before PR #23117) both read `33 releasing, 6 breaking` and `173
releasing, 4 breaking`. The `46064dfa0` output equals both base files
byte for byte outside the disposition comment. So the base text is that
digest's output, and PR #23131 is the change that moves these two
counts. PR #23117's decorated-opener reading moves neither of them.
## `check-empty-changeset` is red on purpose: DELIBERATE CORRECTION
`scripts/check-empty-changeset.mjs` refuses a diff that modifies a
changeset present on the merge base (the foreign changeset rule). It
names two classes with opposite remedies:
- COLLISION: restore theirs, rename yours.
- DELIBERATE CORRECTION: "do NOT restore it -- say so on the PR and get
it confirmed; restoring it from the base would put the false sentence
back".
This PR is the second class by design, for both files. Each is a pending
release note whose count line and markers under-state the breaking
entries its own range declares. Nothing here is restored to turn the
gate green. The gate stays red until the correction is confirmed. The
direction on #23136 names that confirmation: a contract-tier review of
record on this same head, as for #22586. That review names each changed
note and judges each rewritten line, and the table below lists all 12.
The gate's output on head `6447f32ec` (`node
scripts/check-empty-changeset.mjs --base origin/main`, exit 1):
```
✓ No empty-frontmatter changeset introduced by this diff (2 declaring changeset(s) added).
This PR changes a changeset it did not add:
.changeset/console-20c6d351ad74.md
present on the merge base and CHANGED by this PR -- this is somebody else's release note
.changeset/console-f0268ad78485.md
present on the merge base and CHANGED by this PR -- this is somebody else's release note
::error file=.changeset/console-20c6d351ad74.md::… DELIBERATE CORRECTION -- your change may have made this PENDING release note false, and you rewrote it in the same stroke. Remedy: do NOT restore it -- say so on the PR and get it confirmed; …
::error file=.changeset/console-f0268ad78485.md::… (the same text)
```
## Corrections, per line
In the table:
- BEFORE is the base text and AFTER is this PR's text, and `…` elides
text left unchanged.
- The last column is the objectui changeset line that declares the entry
breaking, read at the range's `to` commit (the digest reads each
changeset there). I quote it verbatim up to the first sentence.
- I also checked each declaring line at the commit that added the file,
and all ten are identical there.
- All ten are a bold lead label whose parenthetical opens with
"breaking". That is the shape `BREAKING_LEAD_LABEL` reads since PR
#23131, and the digest before it did not.
**`.changeset/console-20c6d351ad74.md`** (objectui range
`47b1f0bb7174...20c6d35`)
| # | file:line (base) | objectui sha | BEFORE | AFTER | objectui
changeset line declaring it breaking |
|:--|:--|:--|:--|:--|:--|
| 1 | `console-20c6d351ad74.md:12` | `8a55f0ccd` | - **minor** — The
console sidebar no longer lets a user drag the app's menu into a private
order; … | - **minor** — **BREAKING** — The console sidebar no longer
lets a user drag the app's menu into a private order; … |
[`.changeset/12059-sidebar-no-reorder.md:9`](https://github.com/objectstack-ai/objectui/blob/20c6d351ad74d2b14a93becdc134d51b91b2d2e6/.changeset/12059-sidebar-no-reorder.md#L9):
"\*\*\`@object-ui/layout\` (breaking, declared \`minor\` per the version
policy).\*\* \`NavigationRenderer\` retires \`enableReorder\` and
\`onReorder\`, …" |
| 2 | `console-20c6d351ad74.md:13` | `c7b30bd66` | - **minor** —
feat(types)!: `UnifiedViewConfig.chart` retires with a tombstone … | -
**minor** — **BREAKING** — feat(types)!: `UnifiedViewConfig.chart`
retires with a tombstone … |
[`.changeset/12063-unified-view-config-chart-retired.md:9`](https://github.com/objectstack-ai/objectui/blob/20c6d351ad74d2b14a93becdc134d51b91b2d2e6/.changeset/12063-unified-view-config-chart-retired.md#L9):
"\*\*Retired (breaking), \`@object-ui/types\`.\*\*
\`UnifiedViewConfig.chart\` declared the list-view chart's" |
| 3 | `console-20c6d351ad74.md:16` | `025341692` | - **minor** —
feat(plugin-list)!: a chart list view binds only an ADR-0021 `dataset`;
… | - **minor** — **BREAKING** — feat(plugin-list)!: a chart list view
binds only an ADR-0021 `dataset`; … |
[`.changeset/6152-list-view-legacy-chart-retired.md:13`](https://github.com/objectstack-ai/objectui/blob/20c6d351ad74d2b14a93becdc134d51b91b2d2e6/.changeset/6152-list-view-legacy-chart-retired.md#L13):
"\*\*Changed (breaking for a stored chart view that names no
\`dataset\`).\*\* Every door refuses the" |
| 4 | `console-20c6d351ad74.md:19` | `3fd862510` | - **minor** —
feat(plugin-list)!: the renderers stop reading the list-view keys every
door refuses: … | - **minor** — **BREAKING** — feat(plugin-list)!: the
renderers stop reading the list-view keys every door refuses: … |
[`.changeset/6152-list-view-readers-retired.md:14`](https://github.com/objectstack-ai/objectui/blob/20c6d351ad74d2b14a93becdc134d51b91b2d2e6/.changeset/6152-list-view-readers-retired.md#L14):
"\*\*Changed (breaking for a stored view that carries a refused
key).\*\* Rounds 11 and 12 of" |
| 5 | `console-20c6d351ad74.md:43` (count line) | n/a | 1 parent 7856110 commit e81cae0
2 files changed
Lines changed: 12 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
0 commit comments