Skip to content

Commit e6522a9

Browse files
committed
test(cli): the Connect-an-Agent wire pin counts the static Setup composition (Branding now travels with service-settings)
Claude-Session: https://claude.ai/code/session_01UmqzD97e14iws6hmVhgZ5y Co-authored-by: Claude <noreply@anthropic.com>
1 parent 30fb515 commit e6522a9

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

‎packages/cli/test/connect-agent-both-halves-wire.pin.test.ts‎

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,10 +252,17 @@ describe('#17647 — Connect-an-Agent visibility: BOTH halves, over the wire', (
252252
expect(allowedIds).toContain('nav_connect_agent');
253253
expect(groupChildren(setupAllowed.body?.item, 'group_integrations'))
254254
.toContain('nav_connect_agent');
255-
// The Setup tree the platform admin is served: 9 authored groups less
256-
// `group_approvals`, which nothing contributes into and the filter
257-
// collapses, plus 23 contributed entries plus the MCP one.
258-
expect(allowedIds).toHaveLength(32);
255+
// The Setup tree the platform admin is served BY THIS COMPOSITION: 9
256+
// authored groups less `group_approvals`, which nothing contributes
257+
// into and the filter collapses, plus the 22 entries
258+
// `SETUP_NAV_CONTRIBUTIONS` carries, plus the MCP one.
259+
// `nav_settings_branding` is not among them, and not because of a
260+
// tenancy wall (this harness boots none): since #24766 it is
261+
// contributed by `@objectstack/service-settings` together with the
262+
// `branding` namespace, offered only where no organization wall stands,
263+
// and this harness composes platform-objects and the MCP bundle alone.
264+
expect(allowedIds).toHaveLength(31);
265+
expect(allowedIds).not.toContain('nav_settings_branding');
259266
// The two per-user stores are reached from the User record page, not
260267
// from Setup's menu (#23803).
261268
expect(allowedIds).not.toContain('nav_accounts');
@@ -277,7 +284,8 @@ describe('#17647 — Connect-an-Agent visibility: BOTH halves, over the wire', (
277284
expect(withAccountHalf.statusCode).toBe(200);
278285
expect(withoutAccountHalf.statusCode).toBe(200);
279286
expect(navIds(withAccountHalf.body?.item)).toEqual(navIds(withoutAccountHalf.body?.item));
280-
expect(navIds(withAccountHalf.body?.item)).toHaveLength(32);
287+
// 31: the composition the count in the test above states.
288+
expect(navIds(withAccountHalf.body?.item)).toHaveLength(31);
281289

282290
// The mechanism behind the invariance, asserted rather than assumed:
283291
// the bundle aims exactly one contribution at `setup` and one at

0 commit comments

Comments
 (0)