Repository navigation
Commit e11ae4b
ci(console): add the six other packed manifests to the console-dist key and the
Fixes #24441
Clause-②: no
## What changes
One file, `.github/workflows/ci.yml` (+15 / -4):
- The console-dist cache key now hashes
`packages/{core,types,client,formula,sdui-parser,lint}/package.json`
next to `packages/spec/package.json`. The `console-pin` job spells the
key in three places, and all three change: the restore step's `key`, the
verify step's `CONSOLE_DIST_CACHE_KEY` env, and the save step's `key`.
The three stay byte-identical: the key expression has one distinct
string, found 3 times.
- The `console` path filter now names the same six paths. A push that
moves only one of them now selects Console Pin Gate.
- Two comments say what the six paths are and what they cost.
There is no new gate and no script edit. Workflows publish nothing, so
there is no changeset (`skip-changeset`).
## Why
`scripts/build-console.sh` packs every `@objectstack/*` package that
objectui overrides into objectui's install, from this tree
(`OBJECTSTACK_ROOT=... node scripts/objectstack-pin.mjs build`). It does
this on a pin that carries `.objectstack-sha`. objectui's pin script
refuses a packed manifest in two cases: its runtime dependency names
differ from what objectui's lockfile records, or an entry file is
missing. Before this change, the key and the filter named only spec's
manifest:
- A push that moved only `packages/core/package.json` skipped Console
Pin Gate on that push, because the filter did not match.
- The hourly full-battery run selects the job anyway. But it hit the old
dist cache entry and skipped `build-console.sh`, so the pin script never
ran.
The refusal first fired at `cut-rc.yml`'s `pnpm objectui:build`, or at
the publish step.
## Premise check (measured at origin/main `ec951e29e`)
1. **Key spellings.** `grep -n console-dist .github/workflows/ci.yml`
finds three: the restore `key` (line 3011), the verify env
`CONSOLE_DIST_CACHE_KEY` (3075) and the save `key` (3088). All three
were identical. `release.yml` keeps its own narrower key
(`.objectui-sha`, `build-console.sh` and the zod range) on purpose. It
is not touched.
2. **The seven-package set, re-derived from the script, not from the
card.** `build-console.sh` reads the set at run time from objectui's
root `package.json`: the `pnpm.overrides` names that start with
`@objectstack/`. At objectui `origin/main` `29c19cc1a6` the set is
exactly client, core, formula, lint, sdui-parser, spec and types.
- console filter (#24470)1 parent 5eb5400 commit e11ae4b
1 file changed
Lines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
305 | 305 | | |
306 | 306 | | |
307 | 307 | | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
308 | 313 | | |
309 | 314 | | |
310 | 315 | | |
| |||
314 | 319 | | |
315 | 320 | | |
316 | 321 | | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
317 | 328 | | |
318 | 329 | | |
319 | 330 | | |
| |||
2983 | 2994 | | |
2984 | 2995 | | |
2985 | 2996 | | |
2986 | | - | |
| 2997 | + | |
2987 | 2998 | | |
2988 | 2999 | | |
2989 | 3000 | | |
| |||
3008 | 3019 | | |
3009 | 3020 | | |
3010 | 3021 | | |
3011 | | - | |
| 3022 | + | |
3012 | 3023 | | |
3013 | 3024 | | |
3014 | 3025 | | |
| |||
3072 | 3083 | | |
3073 | 3084 | | |
3074 | 3085 | | |
3075 | | - | |
| 3086 | + | |
3076 | 3087 | | |
3077 | 3088 | | |
3078 | 3089 | | |
| |||
3085 | 3096 | | |
3086 | 3097 | | |
3087 | 3098 | | |
3088 | | - | |
| 3099 | + | |
0 commit comments