Repository navigation
Commit d770b15
feat(studio): the organization-flows publish toast names the flows that went live (#27882)
domain:ui#3 · os-bill · session_01Utp6CaJoinvGQSbHeDaWBe
<!-- claude-projects-attribution: {"github_login":"os-bill"} -->
_Requested by **Bill** · [project
thread](https://claude.ai/code/project/chan_016iMXWSZDzqWRWvWzdNo8wg?thread=cmsg_016iMXWSZDzqWRWvWzdNo8wg4i9JiKjEjwtuVzd4gKy9hB)_
## 维护者速读
- 改了什么:Studio「组织流程」范围(不属于任何软件包的流程)发布草稿后,toast 不再写「Published 1
package-less flow draft」:一个流程时写 Published flow "流程标签",多个时写 Published N
flows,并在下方列出名字。
- 为什么改:HotCRM 浏览器走查(#27356 第 18 行)指出 toast 不说是哪个流程,"package-less"
也不是业务用语。
- 风险与回滚:只改提示文字,不改发布逻辑;回滚就是 revert 本 PR。
- 先看:`StudioDesignSurface.tsx` 里组织范围发布成功的那段 toast,以及 studio 命名空间 en/zh
的两条文案。
- 两分钟验证:`pnpm --dir ui exec vitest run
packages/app-shell/src/views/studio-design/StudioDesignSurface.publishCount-11807.test.tsx`,应见
8 passed。
- 需要你做的:无,席位落地。
Part of #27356 (row 18, hotcrm#2320 Studio S7: the publish toast names
the flow)
Clause-②: no
Metadata-protocol: none
## What changes
Row 18 has three parts; this PR is the Studio one.
- **The toast names the flow.** On Studio's Organization flows scope, a
publish that put every pending flow draft live toasted `Published
{count} package-less flow draft(s)`. Now one flow reads `Published flow
"{label}"` (the draft's served label resolved for the locale, else its
machine name) and several read `Published {count} flows` with the names,
comma-separated, as the toast's description. A refusal, a partial
failure and the nothing-pending answer are unchanged.
- **i18n.** The values of `engine.studio.publishedAllFlows` and
`engine.studio.publishedAllFlowsOne` change in en and zh (the studio
namespace's two packs; `check:i18n-drift` reads the zh row as followed).
`publishedAllFlowsOne` now takes `{label}` instead of `{count}`. No key
added, renamed or removed.
The other two parts are not Studio's:
- **The clone notice** is server prose: `FLOW_CLONE_NOTICE` in
`packages/runtime/src/flow-clone.ts`, returned by the flow clone door
and shown verbatim on Setup › Packaged automation. Shortening it is a
server change, reported to the seat as a card.
- **The "switch the original off" button** already exists: after a
clone, Packaged automation offers `Switch "{label}" off`
(`packagedAutomation.cloneSwitchSourceOff`).
## Tests
- `StudioDesignSurface.publishCount-11807.test.tsx` gains two cases on
the real surface and client, with the server stubbed at `fetch`: one
package-less draft with a label toasts the label; two drafts (one
labelled, one not) toast the count row with `QA alert (copy),
qa_digest_clone` as the description. The existing two-draft case still
pins the count row.
<details><summary>Readings (head 69fa4a7, branch rebuilt from
origin/main 7f80732 after #27832 merged)</summary>
- `StudioDesignSurface.publishCount-11807`, `.packageLessFlows-11553`,
`.homeLoop-12513` and the whole `packages/i18n/`: 93 files, 1408 passed
/ 13 skipped.
- `pnpm --filter @object-ui/app-shell --filter @object-ui/i18n run
type-check`: both Done, exit 0.
- Ablation through `scripts/ablation-replace.mjs` (anchor 1 to 0): the
names read `d.name` only, never the label: 2 failed / 6 passed (both new
cases red); restored blob = HEAD blob `45453952912c`, `git diff HEAD`
empty. vitest resolves `@object-ui/*` to source, so no rebuild leg.
- `pnpm --dir ui run check:i18n-drift`: 0 pack values changed; the
designer table's 2 changed en values both followed by zh.
</details>
## Acceptance notes
- The description lists every name the publish read, with no cap. A long
list was not measured.
- Row 18's other half, the clone notice (`FLOW_CLONE_NOTICE` in
`packages/runtime/src/flow-clone.ts`), is a server-lane change: filed by
the seat as #27886, not done here.
## Verification
On head `69fa4a77`: `dispatch-gates --commands` derived 34 families for
this diff; all 34 were run locally, each exit 0, and `--ran` reconciled
34 run, 0 NOT-MEASURED, 0 UNRUN (`node scripts/check-sdui-manifest.mjs`
among them). `check:new-line-citations`: 0 new. CI check-runs were in
progress when this was opened.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Utp6CZrsFMFmWFsxTaq2Bu)_
Co-authored-by: Claude <noreply@anthropic.com>1 parent ff784ef commit d770b15
5 files changed
Lines changed: 46 additions & 12 deletions
File tree
- .changeset
- ui/packages
- app-shell/src/views/studio-design
- i18n/src/namespaces/studio
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
244 | 264 | | |
245 | 265 | | |
246 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1765 | 1765 | | |
1766 | 1766 | | |
1767 | 1767 | | |
| 1768 | + | |
| 1769 | + | |
1768 | 1770 | | |
1769 | | - | |
1770 | | - | |
1771 | | - | |
1772 | | - | |
1773 | | - | |
1774 | | - | |
1775 | | - | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
| 1778 | + | |
1776 | 1779 | | |
1777 | 1780 | | |
1778 | 1781 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3141 | 3141 | | |
3142 | 3142 | | |
3143 | 3143 | | |
3144 | | - | |
3145 | | - | |
| 3144 | + | |
| 3145 | + | |
3146 | 3146 | | |
3147 | 3147 | | |
3148 | 3148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2789 | 2789 | | |
2790 | 2790 | | |
2791 | 2791 | | |
2792 | | - | |
2793 | | - | |
| 2792 | + | |
| 2793 | + | |
2794 | 2794 | | |
2795 | 2795 | | |
2796 | 2796 | | |
| |||
0 commit comments