You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d5ff0d2
Browse filesBrowse the repository at this point in the historyBrowse files
fix(app-shell): on a narrow window, a toast raised beside the record drawer no longer covers the record's Edit and ⋯ buttons
6
+
7
+
Clause-②: no
8
+
Metadata-protocol: none
9
+
10
+
When a right-edge drawer is open and the window is too narrow for a toast beside it (a 720px record drawer on a 1024px window, a split screen, a phone), the console's toaster drops below the drawer's header. It cleared only the drawer's own header, so the success toast raised by creating a record sat on the record header's Edit button and ⋯ menu for its whole four seconds. The toast now also drops below the drawer's first row of controls, measured from the drawer's layout, so it clears the record's actions row for any drawer content. Wide windows keep the toast in the strip beside the drawer, as before.
kind: 'edits a file the ui/scripts/__tests__ suite reads (ui package source, the ui apps, the objectui skill bundle, or ui/scripts itself)',
1061
+
matches: 'ui-scripts-suite-input',
1062
+
gates: [
1063
+
{
1064
+
name: 'pnpm --dir ui exec vitest run scripts/',
1065
+
ciJob: 'Test UI',
1066
+
ciRunner: 'pnpm --dir ui exec vitest run',
1067
+
why: "the 178 test files under ui/scripts/__tests__ belong to no package and run only in CI's 16 Test UI shards, where the affected-test selector adds them to every run, so no package suite and no check family covers them: they pin turbo build inputs, the skill-examples floor, the SchemaRenderer channel keys and the other facts a change under ui package source, the ui apps, skills/objectui or ui/scripts moves. The whole suite, never a subset: measured at about five minutes on a 4-vCPU container (284 s and 286 s, 178 files passing, import-bound), against the CI round trip of about 25 minutes it saves. It needs the seven @objectstack packages Test UI builds first, or about twenty files red on an import of a missing dist — build them exactly as the job does: pnpm exec turbo run build --filter=@objectstack/spec... --filter=@objectstack/client... --filter=@objectstack/core... --filter=@objectstack/formula... --filter=@objectstack/lint... --filter=@objectstack/sdui-parser... --filter=@objectstack/types... . Positional filter, no bare `--`, from the repo root: ui/scripts/vitest-invocation-guard.mjs refuses every other spelling",
1068
+
},
1069
+
],
1070
+
},
1016
1071
];
1017
1072
1073
+
/**
1074
+
* The roots whose change the `ui/scripts/__tests__` suite can see (#26318), in CI's own `paths:` language
1075
+
* — the engine matches them with `triggerListCovers`, the reader of every workflow trigger. They are the
1076
+
* card's four, as written there: ui package SOURCE (any depth below `ui/packages`, so a nested package
1077
+
* counts), the ui apps, the objectui skill bundle the suite reads through `ui/scripts/skill-bundle-root.mjs`,
1078
+
* and the suite's own tree. The bare `src` directory form is listed beside its subtree because a dispatch
1079
+
* surface is often given as that directory, and the trigger language reads a directory only through a
1080
+
* pattern's literal prefix.
1081
+
*/
1082
+
exportconstUI_SCRIPTS_SUITE_ROOTS=Object.freeze([
1083
+
'ui/packages/**/src',
1084
+
'ui/packages/**/src/**',
1085
+
'ui/apps/**',
1086
+
'skills/objectui/**',
1087
+
'ui/scripts/**',
1088
+
]);
1089
+
1018
1090
/**
1019
1091
* The globs that MANDATE a model tier for any card whose file surface touches
1020
1092
* them, as DATA. This is the one list in this file besides CHANGE_KIND_GATES,
0 commit comments