Skip to content

Commit cf20650

Browse files
committed
test(dogfood): two comments stop saying the harness composes no metadata plugin
Comment lines only. Claude-Session: https://claude.ai/code/session_01VoSxBQujKLZKPwK2u5ehQ6 Co-authored-by: Claude <noreply@anthropic.com>
1 parent 8b2647e commit cf20650

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎packages/qa/dogfood/test/external-validate-sees-runtime-save.dogfood.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
// an object saved through `PUT /meta/object/:name` is listed with a real
2222
// verdict (it declares a column the remote lacks, and exactly that column is
2323
// reported); an object imported through `…/external/tables/:remote/import` is
24-
// listed beside them. The verify harness composes no metadata plugin, so its
25-
// `metadata` service is the kernel's fallback registered after the
26-
// federation service's `init()`, as on `objectstack start`; the service reads
27-
// it when validation runs ([#21876]), so each row here is a real comparison.
24+
// listed beside them. The verify harness composes `@objectstack/metadata`'s
25+
// artifact-less `MetadataPlugin`, as `objectstack serve` does for a host
26+
// configuration (#23088); the service resolves what it reads when validation
27+
// runs ([#21876]), so each row here is a real comparison.
2828
// The seam pins sit beside the plugin
2929
// (`packages/services/service-datasource/src/__tests__/external-validate-reads-live-registry.test.ts`).
3030
//

‎packages/qa/dogfood/test/multi-package-artifact.dogfood.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,9 @@ describe('dogfood: one artifact, two co-owning packages (ADR-0130 D4)', () => {
160160
// #14599 — the METADATA door, which the block above does not reach
161161
// ───────────────────────────────────────────────────────────────────────────
162162
//
163-
// `bootStack` registers `AppPlugin` and no `MetadataPlugin`, so everything
164-
// above is measured on the ObjectQL registry alone. The defect this block pins
163+
// `bootStack` registers `AppPlugin` and a `MetadataPlugin` with no artifact,
164+
// which loads none of the stack (#23088), so everything above is measured on
165+
// the ObjectQL registry alone. The defect this block pins
165166
// lives in the OTHER reader — `MetadataPlugin._parseAndRegisterArtifact`, the
166167
// door a real `objectstack dev` / `objectstack serve` boot loads the artifact
167168
// through — and the two only disagree once both are present. That is why this

0 commit comments

Comments
 (0)