Skip to content

Commit cc944d6

Browse files
committed
test(create-objectstack): the npm leg pins what npm ci needs, not the pnpm workspace file
Under the old npm-only stage the npm leg went red only because it also required pnpm-workspace.yaml in the npm copy set. It now asserts the npm lockfile is copied, the pnpm lockfile is not, and npm ci ran, so the old stage reddens the pnpm leg alone. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RWZbGvPFcRKvUqASZtunCU
1 parent 35600d0 commit cc944d6

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎packages/create-objectstack/src/dockerfile-build-stage.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,8 @@ describe('scaffolded Dockerfile build stage installs from the project lockfile',
267267

268268
const run = runInstallStep(project);
269269
expect(run.status, `the stage's install failed for an npm project:\n${run.output}`).toBe(0);
270-
expect(run.copied).toEqual(['package-lock.json', 'package.json', 'pnpm-workspace.yaml']);
270+
expect(run.copied).toEqual(expect.arrayContaining(['package-lock.json', 'package.json']));
271+
expect(run.copied).not.toContain('pnpm-lock.yaml');
271272
expect(run.corepackCalls).toEqual([]);
272273
expect(installedLink(run.app), 'no install ran: node_modules/local-dep is missing').toBe(true);
273274
}, 30_000);

0 commit comments

Comments
 (0)