Skip to content

Commit ca13669

Browse files
committed
fix(spec): drop idField from the promoted-route dropped list (FieldSchema has no idField)
Claude-Session: https://claude.ai/code/session_016njDy8ozy9B9Ns5Y8kAWEK Co-authored-by: Claude <noreply@anthropic.com>
1 parent 780de5e commit ca13669

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎packages/spec/src/ui/bulk-action.zod.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,10 @@ export type BulkActionExecution = z.input<typeof BulkActionExecutionSchema>;
161161
* `accept` and `maxSize`, plus a reference-bearing field's `reference`,
162162
* `displayField` and `dependsOn`. From THIS list only `accept` and `maxSize`
163163
* make the trip. The lookup settings `lookupFilters` / `lookupColumns` /
164-
* `lookupPageSize` / `descriptionField` / `idField` are resolved and then
165-
* dropped by the bulk adapter, and the rest are never read off the field. So
164+
* `lookupPageSize` / `descriptionField` are resolved and then dropped by the
165+
* bulk adapter, and the rest are never read off the field (`idField` has no
166+
* `FieldSchema` spelling to declare; the resolver's snake `id_field` read is
167+
* dropped with the lookup settings). So
166168
* "declare it on the field and let the dialog inherit" is right for `accept` /
167169
* `maxSize` on a promoted def, and a confidently wrong answer for every other
168170
* key here, the shape this campaign has already shipped more than once.
@@ -259,8 +261,8 @@ export const BulkActionParamSchema = lazySchema(() => strictObject(
259261
+ 'text), `placeholder`, `defaultValue`, `multiple`, `accept` and `maxSize`, plus a '
260262
+ 'reference field\'s `reference`, `displayField` and `dependsOn`. ⛔ So of these keys only '
261263
+ '`accept` / `maxSize` arrive that way: the picker settings `lookupFilters` / '
262-
+ '`lookupColumns` / `lookupPageSize` / `descriptionField` / `idField` are dropped on the '
263-
+ 'bulk path, and the rest are never read off the field. Remove the key, or for `accept` / '
264+
+ '`lookupColumns` / `lookupPageSize` / `descriptionField` are dropped on the bulk path, '
265+
+ 'and the rest are never read off the field. Remove the key, or for `accept` / '
264266
+ '`maxSize` move the param onto a promoted action; open an issue if a bulk param '
265267
+ 'genuinely needs a key declared here.',
266268
}],

0 commit comments

Comments
 (0)