|
30 | 30 | * likely to be re-litigated: `plugin-email` already ships the explicit |
31 | 31 | * `./email-plugin.js` extension and fails identically to `formula`'s |
32 | 32 | * extensionless `./registry`. Adding extensions to the redirected packages |
33 | | - * cannot fix this, and neither can removing the `paths` blocks — those are |
34 | | - * mandated by `pnpm check:type-source-resolution`, which was green throughout. |
35 | | - * So was `pnpm check:test-source-alias`. The two gates cover the **types** axis |
36 | | - * and the **vitest** axis; the axis that broke — a CLI child's **runtime** |
37 | | - * module resolution — is covered by neither, which is why the defect lived on |
38 | | - * `main` while every gate reported success. The general third-axis guard is |
| 33 | + * cannot fix this, and neither could removing the `paths` blocks — those were |
| 34 | + * mandated by `pnpm check:type-source-resolution` (retired on 2026-09-18 — |
| 35 | + * #18373), which was green throughout. So was |
| 36 | + * `pnpm check:test-source-alias`. The two gates covered the **types** axis and |
| 37 | + * the **vitest** axis; the axis that broke — a CLI child's **runtime** module |
| 38 | + * resolution — was covered by neither, which is why the defect lived on `main` |
| 39 | + * while every gate reported success. The general third-axis guard is |
39 | 40 | * separate scope and tracked separately; this pin is the narrow half that |
40 | 41 | * belongs to the fix. |
41 | 42 | * |
@@ -285,8 +286,8 @@ describe('no CLI command puts a child process under oclif\'s TypeScript source l |
285 | 286 | + 'packages to their .ts source there — so the child resolves a CommonJS package to ' |
286 | 287 | + 'TypeScript and Node\'s CJS resolver then fails on that file\'s sibling imports ' |
287 | 288 | + '(`Cannot find module \'./registry\'`), killing `os dev` before the server starts. ' |
288 | | - + 'Neither check:type-source-resolution (types axis) nor check:test-source-alias ' |
289 | | - + '(vitest axis) sees this; they were both green while it was broken. Pass the child ' |
| 289 | + + 'Neither check:type-source-resolution (types axis, retired 2026-09-18) nor check:test-source-alias ' |
| 290 | + + '(vitest axis) saw this; they were both green while it was broken. Pass the child ' |
290 | 291 | + '`process.env` unmodified, or a NODE_ENV that is not ' |
291 | 292 | + `${[...SOURCE_LOADER_ACTIVATING].map((v) => `'${v}'`).join(' or ')}` |
292 | 293 | + ' — and if a child genuinely needs dev semantics, let the child command set them ' |
|
0 commit comments