test(service-datasource): model better-sqlite3 13's own never-built error, not a phantom bindings

The never-built fixture required the bindings package relative to
better-sqlite3 13, which does not depend on it; it resolved only through
pnpm's hidden hoist of the copy better-sqlite3 12 brought in as
better-auth 1.7.3's optional peer, and the 1.7.12 lift removed that copy.
better-sqlite3 13 loads its addon with a plain require of
build/Release/better_sqlite3.node, so the fixture now makes that require
from the installed package against a module root that was never built,
and the case asserts MODULE_NOT_FOUND. The two docblock sentences that
named bindings' message now describe the 13.x error. No code moves.

Claude-Session: https://claude.ai/code/session_011TdZ8GjixNZFLz1xJD9zzK
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

packages/services/service-datasource/src/__tests__/sqlite-driver-fallback-file-open-failure.test.ts

@@ -18,14 +18,15 @@
  * It is faked at the seam where `better-sqlite3` loads its addon: the knex
  * better-sqlite3 client's `acquireRawConnection` (`new Database(file)`).
  * The fake throws a REAL load error: Node's own `ERR_DLOPEN_FAILED`, or the
- * `bindings` package's own "not built" error.
+ * `MODULE_NOT_FOUND` better-sqlite3's own loader meets when its addon was
+ * never built.
  */
 
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
 import { createRequire } from 'node:module';
 import { tmpdir } from 'node:os';
-import { dirname, join } from 'node:path';
+import { join } from 'node:path';
 import { SqlDriver } from '@objectstack/driver-sql';
 import {
   NATIVE_SQLITE_WASM_FALLBACK_WARNING,
@@ -87,21 +88,24 @@ function realDlopenFailure(): Error {
 }
 
 /**
- * The real error `better-sqlite3` throws when its addon was never built: the
- * `bindings` package it loads the addon through, asked for an addon that is
- * not there. It carries no code.
+ * The real error `better-sqlite3` throws when its addon was never built. Its
+ * 13.x loader (`lib/binding.js`) takes no helper package: with no prebuilt
+ * binary for the platform it `require()`s `build/Release/better_sqlite3.node`
+ * under its own module root, and Node answers `MODULE_NOT_FOUND`. Produced
+ * here by that same require, made from the installed package, against a
+ * module root that was never built.
  */
 function realNotBuiltFailure(): Error {
   const fromHere = createRequire(import.meta.url);
   const fromDriver = createRequire(fromHere.resolve('@objectstack/driver-sql'));
   const betterSqlite3 = fromDriver.resolve('better-sqlite3/package.json');
-  const bindings = createRequire(betterSqlite3)('bindings');
+  const neverBuilt = join(dir, 'never-built', 'build', 'Release', 'better_sqlite3.node');
   try {
-    bindings({ bindings: 'os_24950_never_built.node', module_root: dirname(betterSqlite3) });
+    createRequire(betterSqlite3)(neverBuilt);
   } catch (error) {
     return error as Error;
   }
-  throw new Error('bindings located an addon that was never built');
+  throw new Error('required an addon that was never built');
 }
 
 /**
@@ -170,9 +174,9 @@ describe('resolveSqliteDriver in development: a native addon that cannot load st
     expect(await resolved.driver.execute('SELECT 1 AS one')).toEqual([{ one: 1 }]);
   });
 
-  it('an addon that was never built (no code) steps down to wasm SQLite', async () => {
+  it('an addon that was never built (MODULE_NOT_FOUND) steps down to wasm SQLite', async () => {
     const loadError = realNotBuiltFailure();
-    expect((loadError as any).code).toBeUndefined();
+    expect((loadError as any).code).toBe('MODULE_NOT_FOUND');
     await failNativeAddonLoad(loadError);
 
     const resolved = await resolveDev(join(dir, 'dev.db'));

packages/services/service-datasource/src/sqlite-driver-fallback.ts

@@ -39,9 +39,10 @@
  *
  *   - **The addon cannot load — steps down.** An ABI mismatch (Node's
  *     `ERR_DLOPEN_FAILED`, a `NODE_MODULE_VERSION` message), an addon that was
- *     never built (`bindings`' "Could not locate the bindings file", which has
- *     no code), or a missing `better-sqlite3` package. Today's path,
- *     unchanged.
+ *     never built (better-sqlite3 13's loader `require()`s the absent
+ *     `build/Release/better_sqlite3.node`, and Node answers
+ *     `MODULE_NOT_FOUND`), or a missing `better-sqlite3` package. Today's
+ *     path, unchanged.
  *   - **The database FILE cannot be opened or created, or is not a database —
  *     re-thrown, as in production.** A path under a regular file, a parent
  *     directory the driver cannot make, a permission refusal, a directory where
@@ -164,8 +165,9 @@ function isEphemeralFilename(filename: string): boolean {
  * An addon that cannot load never carries any of these. It surfaces at the
  * probe's `SELECT 1`, whose failure `SqlDriver.execute()` hands back as
  * `DATABASE_ERROR`, with the load error as its `cause`: Node's
- * `ERR_DLOPEN_FAILED`, `MODULE_NOT_FOUND`, or no code at all (`bindings`'
- * "Could not locate the bindings file"). A missing `better-sqlite3` package
+ * `ERR_DLOPEN_FAILED`, or `MODULE_NOT_FOUND` (an addon that was never built:
+ * better-sqlite3 13's loader `require()`s the absent
+ * `build/Release/better_sqlite3.node`). A missing `better-sqlite3` package
  * fails at construction with knex's install hint, which has no code. None of
  * these matches.
  *