You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c396797
Browse filesBrowse the repository at this point in the historyBrowse files
fix(service-settings): move the storage, knowledge and AI warnings into info_banner rows
Each of the four warnings that sat inside a namespace description or a
field's help string becomes an info_banner row with bannerSeverity
'warning', an id, a title and a body, placed in the section it concerns
directly under the field it warns about. The translations move with them
into settings.NAMESPACE.banners.BANNER_ID.{title,text} in every shipped
locale, and the feature-flags beta_notice banner gains its copies too.
The settings translation coverage test now covers banners in both
directions, and a sweep pins that no manifest or bundle description or
help string carries the warning glyph.
Claude-Session: https://claude.ai/code/session_018VqJPGA1NDNSCZsnecsChP
Co-authored-by: Claude <noreply@anthropic.com>
fix(service-settings): the File Storage, Knowledge and AI settings pages show their warnings as `info_banner` callouts with `bannerSeverity: 'warning'`, not as a sentence inside a subtitle or a field's help text
8
+
9
+
Four warnings were written into ordinary strings with a hand-typed warning glyph, so the admin read them as one more sentence of the page subtitle or of a toggle's help. Each one is now an `info_banner` row in the section it concerns, directly under the field it warns about:
10
+
11
+
-`storage` — `adapter_switch_warning`, under the Adapter select: switching adapter does not migrate existing files.
12
+
-`knowledge` — `adapter_switch_warning`, under the Adapter select: switching adapter does not migrate existing indices.
13
+
-`knowledge` — `enforce_rls_warning`, under the Enforce RLS on search toggle: disabling it skips the vector-store leakage safeguard.
14
+
-`ai` — `log_prompts_warning`, under the Log full prompts toggle: full prompts may leak PII.
15
+
16
+
The namespace description or field help of each keeps its non-warning text. The translations moved with them: in the `en`, `zh-CN`, `ja-JP` and `es-ES` bundles each warning sentence left the `description` / `help` copy and sits under `settings.NAMESPACE.banners.BANNER_ID.{title,text}`, with a translated title per banner. The existing Feature Flags `beta_notice` banner gained the same copies, so no shipped locale reads it in English any more.
17
+
18
+
No setting key, value, default or save behaviour changes. A host that renders `info_banner` rows from the manifest literals draws the English title and text; translated copy is read through `resolveSettingsBannerTitle` / `resolveSettingsBannerText` from `@objectstack/spec/system`.
realtime_cursors: {label: 'Cursores en tiempo real'},
341
341
inline_comments: {label: 'Comentarios en línea'},
342
342
},
343
+
banners: {
344
+
beta_notice: {title: 'Atención',
345
+
text: 'Las funciones beta pueden cambiar sin previo aviso. Fíjalas con variables de entorno (p. ej., `OS_FEATURE_FLAGS_AI_ENABLED=true`) para bloquearlas en todo el despliegue.'},
346
+
},
343
347
},
344
348
345
349
storage: {
346
350
title: 'Almacenamiento de archivos',
347
-
description:
348
-
'Backend usado para adjuntos, exportaciones y subidas de usuarios. '+
349
-
'⚠ Cambiar de adaptador no migra los archivos existentes: los archivos '+
350
-
'subidos con el adaptador anterior dejan de ser accesibles a través '+
351
-
'del nuevo.',
351
+
description: 'Backend usado para adjuntos, exportaciones y subidas de usuarios.',
352
352
groups: {
353
353
adapter: {title: 'Backend',description: 'Elige dónde se almacenan los archivos subidos.'},
over_fetch: {label: 'Multiplicador de sobre-obtención',
536
543
help: 'Se obtienen topK × overFetch candidatos internos para que el filtrado de metadatos en JS siga teniendo filas.'},
537
544
enforce_rls: {label: 'Aplicar RLS en la búsqueda',
538
-
help: 'Vuelve a comprobar cada resultado contra los permisos a nivel de registro del solicitante. ⚠ Desactivarlo omite la salvaguarda exclusiva de la plataforma.'},
545
+
help: 'Vuelve a comprobar cada resultado contra los permisos a nivel de registro del solicitante.'},
539
546
},
540
547
actions: {
541
548
test: {label: 'Probar conexión'},
542
549
},
550
+
banners: {
551
+
adapter_switch_warning: {title: 'Los índices existentes no se migran',
552
+
text: 'Cambiar de adaptador NO migra los índices existentes.'},
553
+
enforce_rls_warning: {title: 'Mantenlo activado en producción',
554
+
text: 'Desactivarlo omite la salvaguarda exclusiva de la plataforma.'},
0 commit comments