Repository navigation
Commit b835196
committed
fix(platform-checklist): drop the dangling ADR citation, pin both call sites, narrow the
Four findings from the Tier S contract review, carried in one push.
F1 (BLOCKING) — `docs/qa/platform-checklist/README.md` cited `ADR-0136`, which
names no record under `docs/adr/` (the registry stops at 0135). A bare
`ADR-NNNN` resolves against THIS repo, so `check:adr-anchors` exited 1 and took
the required `Lint & Repo Gates` context with it, leaving 169 gates never run.
The citation came from the card body and was copied; the fix is still owed
here. ⛔ No number is invented and nothing is allowlisted: the lesson is stated
self-containedly instead, which is what a rule in this tree owes anyway.
F3 — the two rules ride on two call sites that nothing pinned. Both were
severed and measured: `--self-test` stayed at 207/207 green, the live gate
stayed green, and a fixture kind whose ONLY item is planned stayed green. A
pure function's battery cannot see whether anything calls it, and the subject
here IS a ratchet, so an unpinned binding is a ratchet that switches off
without a number moving. `statusBindingProblems` reads this file's own source
and is driven ON and OFF over one text, the way the line-citation limb below
already pins its binding. The first draft of it shipped a decoy — its severing
needles were plain string literals the predicate matched instead of the real
call sites, so both OFF legs read as passes. The OFF legs caught it; the
predicate now demands EXACTLY ONE occurrence and the needles arrive in halves.
F2 — `since` is checked for SHAPE only. This ledger holds no release timeline,
so a planned item targeting an already-shipped release passes. The README, the
refusal message and the docblock now say that, and two rows pin the limit in
the direction it deliberately does not go.
F4 — the hand-typed `264` in the self-test prose is derived from the ledger.
Claude-Session: https://claude.ai/code/session_01AmH9bKvGoLjiY86Q4Z3og2
Co-authored-by: Claude <noreply@anthropic.com>since claim1 parent 2245341 commit b835196
2 files changed
Lines changed: 183 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
307 | | - | |
308 | | - | |
309 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
310 | 312 | | |
311 | 313 | | |
312 | 314 | | |
| |||
316 | 318 | | |
317 | 319 | | |
318 | 320 | | |
319 | | - | |
| 321 | + | |
320 | 322 | | |
321 | 323 | | |
322 | 324 | | |
| |||
0 commit comments