Repository navigation
Commit a8f0853
docs(objectql): the last two carriers of the falsified "schema-uniform" premise state what the tree does (#17717)
* docs(objectql): the last two carriers of the falsified "schema-uniform" premise state what the tree does
`engine.insert`'s per-call `preserveAudit` warning and the docblock of
`preserveAuditIgnoredOnInsertWarning` both justified a batch-level union with
"the strip is schema-uniform". Maintainer ruling C (#14147) falsified that: the
static-`readonly` strip runs INSIDE `engine.insert`, after the `beforeInsert`
hooks, and exempts keys a hook itself assigned — armed per ROW
(`hookWrittenKeys: rowHookWrittenKeys[i]`), so two rows can lose different sets.
The aggregation is unchanged and stays right on the reason the producer already
has: a log line has no per-row slot, so the union is the only view one line can
represent. Both sites now say that and tell a reader how to read a name — "at
least one row lost this field", never "every row did".
`rule-validator.ts` contradicted itself: its `hookWrittenKeys` option docs state
"Per ROW, never per call" ~240 lines above the sentence that claimed uniformity.
The file now gives one answer.
Claude-Session: https://claude.ai/code/session_01RuoNSXUbBoWHkNS4AknTrM
Co-authored-by: Claude <noreply@anthropic.com>
* chore: changeset for the objectql schema-uniform carrier correction
Claude-Session: https://claude.ai/code/session_01RuoNSXUbBoWHkNS4AknTrM
Co-authored-by: Claude <noreply@anthropic.com>
* chore: drop the changeset — this diff publishes nothing from a released package
Maintainer ruling on the open question: `skip-changeset` is defined as the
label for a diff that publishes nothing from any released package, and this
diff is one. Measured two independent ways:
- `engine.ts` carries an inline `//` comment inside a method body, never
emitted to a `.d.ts` under any configuration.
- `rule-validator.ts`'s docblock is on `preserveAuditIgnoredOnInsertWarning`,
exported from its module but NOT re-exported from `packages/objectql/src/index.ts`,
so it never reaches `dist/index.d.ts`. Control: that entry re-exports three
other symbols from the same file, so it is selective, not empty.
- After a real build, `dist/` greps 0 for both the old and the new text while
the positive control (the runtime string literal from the same function)
hits 4 files.
The prior comment-only changesets are not precedent for "comment-only ⇒ patch":
each measured that its corrected TSDoc DOES reach the built `.d.ts`. Same rule,
opposite measurement.
Claude-Session: https://claude.ai/code/session_01RuoNSXUbBoWHkNS4AknTrM
Co-authored-by: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent ab37ded commit a8f0853
2 files changed
Lines changed: 21 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10636 | 10636 | | |
10637 | 10637 | | |
10638 | 10638 | | |
10639 | | - | |
10640 | | - | |
| 10639 | + | |
| 10640 | + | |
| 10641 | + | |
| 10642 | + | |
| 10643 | + | |
| 10644 | + | |
| 10645 | + | |
| 10646 | + | |
10641 | 10647 | | |
10642 | 10648 | | |
10643 | 10649 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1652 | 1652 | | |
1653 | 1653 | | |
1654 | 1654 | | |
1655 | | - | |
1656 | | - | |
1657 | | - | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
| 1662 | + | |
| 1663 | + | |
| 1664 | + | |
| 1665 | + | |
| 1666 | + | |
| 1667 | + | |
1658 | 1668 | | |
1659 | 1669 | | |
1660 | 1670 | | |
| |||
0 commit comments