test(objectql,rest): type the having-door tests' query options instead of erasing them (#20263)

Claude-Session: https://claude.ai/code/session_01Bvd69VPa6puiNzzPUroDBx
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

packages/objectql/src/engine-aggregate-having-temporal-door.test.ts

@@ -29,7 +29,7 @@
 
 import { describe, it, expect } from 'vitest';
 import { isUninterpretableTemporalComparand, type TemporalComparandKind } from '@objectstack/core';
-import type { EngineAggregateOptions } from '@objectstack/spec/data';
+import type { EngineAggregateOptions, FilterCondition } from '@objectstack/spec/data';
 import { ObjectQL } from './engine.js';
 import { applyInMemoryAggregation } from './in-memory-aggregation.js';
 
@@ -113,7 +113,7 @@ function query(path: Path, having: unknown, groupBy: EngineAggregateOptions['gro
   const aggregations = path === 'native'
     ? AGGREGATIONS
     : [...AGGREGATIONS, { function: 'count' as const, alias: 'fb', filter: { customer_id: { $ne: '' } } }];
-  return { groupBy, aggregations, having: having as any };
+  return { groupBy, aggregations, having: having as FilterCondition };
 }
 
 interface Refusal extends Error { code?: unknown; status?: unknown }
@@ -173,7 +173,7 @@ async function keptGroups(having: unknown, key = 'customer_id', groupBy?: Engine
 /** The same comparand in a `where` on the aggregated field — the twin. */
 async function whereTwinOf(where: Record<string, unknown>): Promise<{ err?: Refusal; reads: number }> {
   const { engine, reads } = await makeEngine('rows', ROWS);
-  const { err } = await outcome(() => engine.find(OBJECT, { where } as any));
+  const { err } = await outcome(() => engine.find(OBJECT, { where: where as FilterCondition }));
   return { err, reads: reads.find };
 }
 

packages/rest/src/data-query-having-temporal-door.test.ts

@@ -26,7 +26,7 @@
  */
 
 import { describe, it, expect, afterAll } from 'vitest';
-import type { EngineAggregateOptions } from '@objectstack/spec/data';
+import type { EngineAggregateOptions, FilterCondition } from '@objectstack/spec/data';
 import { ObjectQL } from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { ObjectStackProtocolImplementation } from '@objectstack/metadata-protocol';
@@ -126,7 +126,7 @@ function grouped(path: Path, having: Record<string, unknown>): EngineAggregateOp
     { function: 'sum', field: 'amount', alias: 'total' },
   ];
   if (path === 'rows') aggregations.push({ function: 'count', alias: 'fb', filter: { customer_id: { $ne: '' } } });
-  return { groupBy: ['customer_id'], aggregations, having: having as any };
+  return { groupBy: ['customer_id'], aggregations, having: having as FilterCondition };
 }
 
 const refusalOf = async (p: Promise<unknown>) =>
@@ -166,7 +166,7 @@ describe('[#20263] having — a comparand its column cannot read is refused befo
         expect(res._json.error).toContain(column);
       }
       // The twin, at both doors: the same door, the same envelope.
-      const twin = await refusalOf(engine.find(OBJECT, { where } as any));
+      const twin = await refusalOf(engine.find(OBJECT, { where: where as FilterCondition }));
       expect(twin?.code).toBe('INVALID_FILTER');
       expect(twin?.status).toBe(400);
       const twinRes = await post({ where });