Repository navigation
Commit 985a9cd
fix(spec): correct false CoreServiceName JSDoc claims in contracts/*.ts (#9762)
email-service.ts claimed "Aligned with CoreServiceName 'email'" but
CoreServiceName has no `email` member — email is subsumed under
`notification`. The runtime slot `'email'` is real (registered by
`@objectstack/plugin-email`); only the claim about where the name comes
from was false. Corrected to name the registry slot and its registrant.
Swept all 16 copies of the "Aligned with CoreServiceName 'X'" template
sentence across packages/spec/src/contracts/*.ts against the actual
CoreServiceName enum. Two more were false: export-service.ts ('export')
and seed-loader-service.ts ('seed-loader' + a fabricated
"SeedLoaderProtocol in data/seed-loader.zod.ts" that does not exist
anywhere in the repo) — neither is a CoreServiceName member nor has any
evidenced registerService binding. The other 13 are true and left
byte-identical.
No CoreServiceName member added (the #9630-class forbidden fix). JSDoc
prose only — no interface shape, no runtime, no schema changes.
Fixes #9752
Claude-Session: https://claude.ai/code/session_016D9wdJR14KKCxz1WgdAzcw
Co-authored-by: Claude <noreply@anthropic.com>1 parent e9534a4 commit 985a9cd
4 files changed
Lines changed: 17 additions & 3 deletions
File tree
- .changeset
- packages/spec/src/contracts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
| |||
0 commit comments