Skip to content

Commit 937e6e1

Browse files
committed
test(client): record the measured residual and the CI readings in the suites' headers
auth-rotated-session-token's first case is the card's whole probe; with the cold start moved out, what its window holds is its own work, and the header now says how that measured under load and where the lever is. The two organization suites' headers quote their own first-case readings from the red Test Core run instead of a claim about every other case. Claude-Session: https://claude.ai/code/session_01UYBdGBzWSrAMzpW8ah3GbP Co-authored-by: Claude <noreply@anthropic.com>
1 parent 49bd6fd commit 937e6e1

3 files changed

Lines changed: 19 additions & 6 deletions

File tree

‎packages/client/src/auth-rotated-session-token.test.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,15 @@
6565
// the cost moved out, the `60_000`s are gone and every case runs on the
6666
// default `testTimeout`.
6767
//
68+
// ⚠ What a window holds now is behaviour, and ① holds the most: the card's
69+
// whole probe, a sign-up plus five more calls that each check a password or a
70+
// TOTP code. It takes about 700 ms on 4 vCPU with the box otherwise quiet, and
71+
// a warm-up that ran the WHOLE probe left it no faster than this one does, so
72+
// none of that is loading. Under sixteen CPU-bound busy loops it took 4.1-4.2
73+
// s. Under twenty-four, the load that times out every one of these suites'
74+
// cold first cases, it reached the 5000 ms budget on its own work. If CI ever
75+
// reds it, the lever is that case's own work, ⛔ not a timeout.
76+
//
6877
// ⛔ It shares nothing a case asserts on. Its engine and manager are its own
6978
// and are destroyed before any case starts. Every case still builds a fresh
7079
// engine, a fresh `AuthManager` and a fresh sign-up. What it leaves warm is

‎packages/client/src/organization-invitation-resend-team-placement.test.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,11 @@
6565
* `auth-login-register-envelope.test.ts`, which carries the same arrangement
6666
* and the same fix. Here, idle on 4 vCPU at `c74de10a9`, that cost put ① at
6767
* 1245 ms against 307-411 ms for the four later cases that run `arrange()`.
68-
* Under twenty-four CPU-bound busy loops, the load that reproduces CI's
69-
* failure in the sibling suites, ① timed out at vitest's 5000 ms
70-
* `testTimeout` while every other case passed.
68+
* On the `Test Core` shard where a sibling suite went red (PR #20325's run),
69+
* ① took 3599 ms here against 486-820 ms for the later cases that run
70+
* `arrange()`. Under twenty-four CPU-bound busy loops on this box, the load
71+
* that reproduces that red, ① timed out at vitest's 5000 ms `testTimeout` in
72+
* every run.
7173
*
7274
* So the cost is now paid by a module-scope `await`, during COLLECTION, which
7375
* no vitest clock covers: `@vitest/runner@4.1.11` wraps hooks and test bodies

‎packages/client/src/organization-invite-role-default.test.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,11 @@
6969
* `auth-login-register-envelope.test.ts`, which carries the same arrangement
7070
* and the same fix. Here, idle on 4 vCPU at `c74de10a9`, that cost put ① at
7171
* 968 ms against 310-336 ms for ② and ③, which run the same `arrange()`.
72-
* Under twenty-four CPU-bound busy loops, the load that reproduces CI's
73-
* failure in the sibling suites, ① timed out at vitest's 5000 ms
74-
* `testTimeout` while every other case passed.
72+
* On the `Test Core` shard where a sibling suite went red (PR #20325's run),
73+
* ① took 2849 ms here against 497-820 ms for the later cases that run
74+
* `arrange()`. Under twenty-four CPU-bound busy loops on this box, the load
75+
* that reproduces that red, ① timed out at vitest's 5000 ms `testTimeout` in
76+
* every run.
7577
*
7678
* So the cost is now paid by a module-scope `await`, during COLLECTION, which
7779
* no vitest clock covers: `@vitest/runner@4.1.11` wraps hooks and test bodies

0 commit comments

Comments
 (0)