Repository navigation
Commit 93505c9
committed
fix(ui-core): ActionDef stops mirroring the aged-out
CI's Build Core went red on the merged head in ui/packages/core: `ActionDef`
declared `shortcut?: SpecActionInput['shortcut']` and `bulkEnabled?:
SpecActionInput['bulkEnabled']`, two mirrors of spec-17 `retiredKey()`
tombstones that resolved to `undefined` for as long as the tombstones
stood. The ≤16.x kits left the schema one major on, so the indexed access
has nothing to name and tsc refuses it. The two members leave `ActionDef`
with their rows in `ACTION_DEF_KEYS` and `SPEC_ACTION_KEYS` (the key
inventories the pin tests hold against the spec's `ActionSchema` shape),
and `SPEC_ACTION_KEYS` drops its `execute` row for the same reason: the
pin that walks the spec shape reported it stale once that tombstone aged
out. `RETIRED_ACTION_KEYS` keeps the console's own `execute` rename
prescription (a stored row can reach the runner unparsed), and
`ActionEngine.registerAction(action, { shortcut, bulkEnabled })` keeps
both as host-passed options, as before; the closed-surface pin's comment
and the tombstone test's title say what refuses the key now.
Claude-Session: https://claude.ai/code/session_01H37vtTJRVBf1LkyYNW5yfo
Co-authored-by: Claude <noreply@anthropic.com>shortcut and bulkEnabled action keys1 parent 34b0688 commit 93505c9
4 files changed
Lines changed: 18 additions & 23 deletions
File tree
- ui/packages/core/src/actions
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
502 | 502 | | |
503 | 503 | | |
504 | 504 | | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
521 | 513 | | |
522 | 514 | | |
523 | 515 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
203 | | - | |
| 202 | + | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
237 | | - | |
238 | 237 | | |
239 | 238 | | |
240 | 239 | | |
| |||
248 | 247 | | |
249 | 248 | | |
250 | 249 | | |
251 | | - | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
| |||
310 | 314 | | |
311 | 315 | | |
312 | 316 | | |
313 | | - | |
314 | 317 | | |
315 | 318 | | |
316 | 319 | | |
| |||
0 commit comments