You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8da6368
Browse filesBrowse the repository at this point in the historyBrowse files
fix(publish-smoke): derive the tarball pin set from the publishable population, not a by-name exclusion (#11257)
* fix(publish-smoke): derive the tarball pin set from the publishable population, not a scope/exclusion
The packed-tarball smoke built its pin set as "publishable MINUS a hand-written
exclusion", and the exclusion held `create-objectstack` on the rationale that no
@objectstack/* manifest depends on it. That rationale expired when
@objectstack/cli took a dependency on the scaffolder: the unscoped name was
neither packed nor pinned, pnpm fell back to the registry, and the smoke died on
ERR_PNPM_NO_MATCHING_VERSION for a version that by definition is not published
yet — a deterministic false red on every release candidate.
- publish-smoke-pack.mjs: the set is `private !== true`, full stop. No scope
filter, no exclusion, no hand list. `assertPinSetTotal` re-checks pin set ==
publishable set in BOTH directions at the derivation site and names the
offending packages, so a future exclusion cannot reopen the hole silently.
- publish-smoke.sh: the registry-leak assertion drove off a `@objectstack/*`
grep, which made it blind in exactly the case it existed to catch. It now
drives off the override map's own names, scoped and unscoped alike.
- A --self-test (unscoped package survives derivation; both directions of the
equality assertion) wired as `check:publish-smoke-pin` in lint.yml, so a
regression reddens on the PR that causes it rather than on a release run.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(publish-smoke): de-duplicate the registry-leak diagnostic across lockfile sections
A name is keyed in both `packages:` and `snapshots:`, so counting lines listed
every offender twice and inflated the tarball-resolved total.
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
0 commit comments