Skip to content

Commit 84f4580

Browse files
committed
pm-dispatch: a FAIL verdict leaves the review marker on
The marker tracks "landing still owes an at-tier PASS on the current head"; a FAIL starts a patch round and the PR still owes that PASS, so only a PASS on file, a merge or a close clears it. Stated in the rule and in the roster comment so a seat does not clear on FAIL and re-hang at the next ACCEPT. Claude-Session: https://claude.ai/code/session_01A22sUB3mUWs6M36VgfijBq Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2014600 commit 84f4580

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎.claude/skills/pm-dispatch/references/contract-review.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@
3131

3232
- 只作等复核标记,⛔ 不是闸门;单载体 = PR,卡上副本在规则外、不是要求。
3333
- 挂:ACCEPT 时条款②任一肢命中而现 head 无同形 PASS 在案 ⇒ 派发席同笔挂于 PR。
34-
- 摘:现 head 同形 PASS 在案 ⇒ 写记录的席同笔摘;PR 合并或关闭 ⇒ 派发席摘。
34+
- 摘:现 head 同形 PASS 在案 ⇒ 写记录的席同笔摘;PR 合并或关闭 ⇒ 派发席摘;FAIL 不摘。
3535
- 读者 = 维护者过滤 `is:pr is:open label:needs:contract-review` 与席位巡查、交接。
3636
- ⛔ 无 check、workflow、队列守卫或巡查脚本读它;入队只认同形记录,标记有无不改判。

‎scripts/pm/ensure-pm-labels.sh‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -329,10 +329,11 @@ gh label create needs:pack-smoke -R objectstack-ai/objectstack -c 006b75 -d "Opt
329329
# .claude/skills/pm-dispatch/references/contract-review.md 〈等复核标记〉. The
330330
# dispatching seat hangs it on the PR at ACCEPT when either clause-② limb hits
331331
# and no same-form PASS is on the current head; the seat posting that PASS, or
332-
# the dispatching seat at merge/close, clears it. Named readers: the
333-
# maintainer's PR-list filter `is:pr is:open label:needs:contract-review` and
334-
# each seat's patrol and handover. ⛔ No check, workflow, queue guard or patrol
335-
# script reads it — the queue releases on the `## Contract review` record alone.
332+
# the dispatching seat at merge/close, clears it (a FAIL leaves it on). Named
333+
# readers: the maintainer's PR-list filter
334+
# `is:pr is:open label:needs:contract-review` and each seat's patrol and
335+
# handover. ⛔ No check, workflow, queue guard or patrol script reads it — the
336+
# queue releases on the `## Contract review` record alone.
336337
# Restored by the maintainer's instruction recorded on #19973, verbatim:
337338
# 「恢复 needs:contract-review,把这句原话写进一张 skills 车道的卡」 — answering a
338339
# question that proposed a marker, not a gate. The gate role, `--pair`, the

0 commit comments

Comments
 (0)