Skip to content

Commit 82095d3

Browse files
committed
fix(platform-objects): rotate-secret result dialog states the immediate cut-off
Claude-Session: https://claude.ai/code/session_01MrvwG9BMeMc4oCSG9FsV95 Co-authored-by: Claude <noreply@anthropic.com>
1 parent abd5acd commit 82095d3

4 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎packages/platform-objects/src/apps/translations/es-ES.objects.generated.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1557,7 +1557,7 @@ export const esESObjects: NonNullable<TranslationData['objects']> = {
15571557
description: "¿Rotar el secreto de este cliente OAuth? El secreto anterior dejará de funcionar de inmediato y cualquier integración que lo utilice fallará hasta que se actualice con el nuevo secreto. El nuevo secreto se muestra una sola vez.",
15581558
resultDialog: {
15591559
title: "Secreto de cliente rotado",
1560-
description: "Guarde el nuevo secreto ahora: se muestra una sola vez. Actualice todas las integraciones antes de que termine el periodo de gracia del secreto anterior.",
1560+
description: "Guarde el nuevo secreto ahora: se muestra una sola vez. El secreto anterior ya ha dejado de funcionar; actualice todas las integraciones con el nuevo secreto.",
15611561
acknowledge: "He actualizado mis integraciones",
15621562
fields: {
15631563
client_secret: "Nuevo secreto de cliente"

‎packages/platform-objects/src/apps/translations/ja-JP.objects.generated.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1557,7 +1557,7 @@ export const jaJPObjects: NonNullable<TranslationData['objects']> = {
15571557
description: "このOAuthクライアントのシークレットをローテーションしますか?以前のシークレットは直ちに使用できなくなり、それを使用している連携は新しいシークレットに更新されるまで動作しなくなります。新しいシークレットは一度しか表示されません。",
15581558
resultDialog: {
15591559
title: "クライアントシークレットをローテーションしました",
1560-
description: "新しいシークレットを今すぐ保存してください。表示は一度きりです。旧シークレットの猶予期間が終わる前にすべての連携を更新してください。",
1560+
description: "新しいシークレットを今すぐ保存してください。表示は一度きりです。以前のシークレットはすでに使用できなくなっています。すべての連携を新しいシークレットに更新してください。",
15611561
acknowledge: "連携を更新しました",
15621562
fields: {
15631563
client_secret: "新しいクライアントシークレット"

‎packages/platform-objects/src/apps/translations/zh-CN.objects.generated.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1557,7 +1557,7 @@ export const zhCNObjects: NonNullable<TranslationData['objects']> = {
15571557
description: "确定要轮换此 OAuth 客户端的密钥吗?旧密钥将立即失效,任何使用它的集成都将中断,直到更新为新密钥为止。新密钥仅显示一次。",
15581558
resultDialog: {
15591559
title: "Client Secret 已轮换",
1560-
description: "请立即保存新密钥——它只显示一次。请在旧密钥宽限期结束前更新所有集成。",
1560+
description: "请立即保存新密钥——它只显示一次。旧密钥已经失效:请用新密钥更新所有集成。",
15611561
acknowledge: "我已更新所有集成",
15621562
fields: {
15631563
client_secret: "新的 Client Secret"

‎packages/platform-objects/src/identity/sys-oauth-application.object.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,21 @@ export const SysOauthApplication = ObjectSchema.create({
183183
// then the `resultDialog` that reveals the new secret AFTER the rotation.
184184
// The result dialog is not part of the #7278 defect — it is a post-run
185185
// reveal for output shown only once, not a second pre-run decision.
186+
//
187+
// Both texts state the same cut-off, because that is what the route does:
188+
// better-auth's `rotateClientSecretEndpoint` (@better-auth/oauth-provider
189+
// 1.7.3) overwrites the client's single stored `clientSecret`, and
190+
// `validateClientCredentials` checks a presented secret against that one
191+
// value only. No previous secret is kept, so there is no grace period —
192+
// the old secret is refused from the moment the rotation commits.
186193
description: 'Rotate this OAuth client\'s secret? The previous secret will stop working immediately and any integrations using it will break until they are updated with the new secret. The new secret is shown only once.',
187194
refreshAfter: true,
188195
params: [
189196
{ name: 'client_id', field: 'client_id', defaultFromRow: true, required: true },
190197
],
191198
resultDialog: {
192199
title: 'Client secret rotated',
193-
description: 'Save the new secret now — it is shown only once. Update every integration before the previous secret\'s grace period ends.',
200+
description: 'Save the new secret now — it is shown only once. The previous secret has already stopped working: update every integration with the new secret.',
194201
acknowledge: 'I have updated my integrations',
195202
fields: [
196203
{ path: 'client_secret', label: 'New Client Secret', format: 'secret' },

0 commit comments

Comments
 (0)