Repository navigation
Commit 80ec71d
fix(cli): retire the five stale scaffold peerDependencyRules entries (#25239)
<!-- claude-projects-attribution: {"github_login":"os-sales"} -->
_Requested by **Sales** · [project
thread](https://claude.ai/code/project/chan_01D5bWFY3rFzgJcytD5gD4Uu?thread=cmsg_01D5bWFY3rFzgJcytD5gD4UuDWJsBGQpadCH8JR2xZQ5re)_
Fixes #25123
Clause-②: no
Metadata-protocol: none
## What
On the better-auth `1.7.12` pin, all five
`SCAFFOLD_ALLOWED_PEER_VERSIONS` entries suppress peer mismatches that
no longer exist, so they retire at once (a ledger entry states a fact
that holds; no staged grace):
| Entry | Reading on `origin/main` 123ff6f |
|:---|:---|
| `better-auth>better-sqlite3` (`13`) | `better-auth@1.7.12` declares no
`better-sqlite3` peer (lockfile `peerDependencies` block and `npm
view`). Control leg: `npm view better-auth@1.7.3 peerDependencies` still
names `better-sqlite3: ^12.0.0`. |
| `@better-auth/core`, `/oauth-provider`, `/scim`, `/sso` each
`>@better-auth/utils` (`0.5.0`) | All four at 1.7.12 peer `^0.4.2 \|\|
^0.5.0`; the tree resolves `0.5.0`. |
The map is now empty, so both scaffold paths (`objectstack init` and
`npx create-objectstack`) stop emitting a `peerDependencyRules` block;
`renderPnpmWorkspaceYaml` already omitted it for an empty map. The
docblock's better-call reading is corrected to what holds: stable scim
peers `better-call` exactly at `1.4.4`, the resolved copy (it read
`1.4.0` on the 1.7.3 pin).
`allowedVersions` only silences a report, so the resolution a scaffold
gets is unchanged.
## Files
- `packages/cli/src/commands/init.ts`: map emptied; its docblock
rewritten as the retired-entries record; the `renderPnpmWorkspaceYaml`
docblock line about the peer block updated.
- `packages/cli/test/init.test.ts`: presence pins flipped to per-key
absence pins, a set pin (`toEqual({})`), a no-block pin, and a
fixture-map pin for the render path; the top-level key list loses
`peerDependencyRules`.
- `packages/cli/test/better-sqlite3-peer-declaration.pin.test.ts`: the
widening-equals-declared-major limb becomes an absence pin; the CLI's
own 13.x declaration pins stay.
- `packages/cli/test/scaffold-workspace-consistency.test.ts`: drops the
non-vacuity guard that required a non-empty peer map (two empty maps are
now the intended state; the byte-equality limb still holds both files).
- `packages/create-objectstack/src/templates/blank/pnpm-workspace.yaml`
+ `src/template-consistency.test.ts`: same retirement in the bundled
template, which is held byte-equal to the cli renderer.
- `pnpm-workspace.yaml` (root): one comment sentence that called these
entries' retirement conditions unmet.
- `.changeset/25123-scaffold-peer-ledger-retired.md`: `patch` for
`@objectstack/cli` and `create-objectstack` (the template ships in
`dist/templates`).
## Verification (head 3737254)
- Closure build under the verify lock: `pnpm --filter
'@objectstack/cli^...' --filter 'create-objectstack^...' --filter
@objectstack/cli --filter create-objectstack build` → `VERDICT
command-exit 0`.
- Targeted: cli `test/init.test.ts`,
`test/better-sqlite3-peer-declaration.pin.test.ts`,
`test/scaffold-workspace-consistency.test.ts` → 3 files, 63/63;
create-objectstack `src/template-consistency.test.ts` → 1 file, 39/39.
- cli unit layer (`vitest run --project unit`) → 324 files, 4775/4775;
`create-objectstack` `pnpm test` → 18 files, 278/278; `pnpm --filter
@objectstack/cli typecheck` and `pnpm --filter create-objectstack
typecheck` → exit 0. The integration layer is left to CI (no spawn entry
or integration file touched).
- Mutation leg (one-shot, via `scripts/ablation-replace.mjs`, restored
by `git checkout HEAD`, blob re-verified as `73c71be9f`): re-adding
`'better-auth>better-sqlite3': '13'` to the map turns 7 tests red across
the three cli files. Tests import `src/`, so no dist leg applies.
- `pnpm lint` → exit 0.
- `dispatch-gates --commands`: 81 derived; 79 exit 0;
`check:dual-build-cjs-loads` and `check:i18n-coverage` exit 3
PREREQUISITE NOT MET (they need dist for packages outside this closure)
→ NOT MEASURED locally, CI runs them.
## Acceptance notes
- The dispatch named `packages/cli/src/commands/init.test.ts`; the pins
actually live at `packages/cli/test/init.test.ts`.
- The bundled template's package is named `create-objectstack`
(unscoped), so the changeset names it that way.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01CxBKycaiUpA1yGx1XyoGqX)_
Co-authored-by: Claude <noreply@anthropic.com>1 parent 345f0b1 commit 80ec71d
8 files changed
Lines changed: 150 additions & 338 deletions
File tree
- .changeset
- packages
- cli
- src/commands
- test
- create-objectstack/src
- templates/blank
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
177 | 153 | | |
178 | 154 | | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
207 | 158 | | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
| 159 | + | |
| 160 | + | |
233 | 161 | | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
| 162 | + | |
245 | 163 | | |
246 | 164 | | |
247 | 165 | | |
| |||
696 | 614 | | |
697 | 615 | | |
698 | 616 | | |
699 | | - | |
700 | | - | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
701 | 620 | | |
702 | 621 | | |
703 | 622 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
66 | 61 | | |
67 | 62 | | |
68 | 63 | | |
| |||
103 | 98 | | |
104 | 99 | | |
105 | 100 | | |
106 | | - | |
| 101 | + | |
107 | 102 | | |
108 | 103 | | |
109 | 104 | | |
110 | 105 | | |
111 | 106 | | |
112 | 107 | | |
113 | 108 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
120 | 113 | | |
121 | 114 | | |
122 | 115 | | |
123 | 116 | | |
124 | 117 | | |
125 | 118 | | |
126 | | - | |
127 | | - | |
| 119 | + | |
| 120 | + | |
128 | 121 | | |
129 | 122 | | |
130 | 123 | | |
| |||
0 commit comments