Skip to content

Commit 7b575a1

Browse files
committed
test(ui/scripts): restate the vacuity floors the page's readers fed, and keep the UI CI pointer inside the section's path rule
Claude-Session: https://claude.ai/code/session_01QSeKYoVqdPtw3tbJG1vCDH Co-authored-by: Claude <noreply@anthropic.com>
1 parent 67c1714 commit 7b575a1

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ Its "repository root" is `ui/`. The guard is `ui/scripts/vitest-invocation-guard
270270
### UI CI
271271

272272
GitHub runs only the workflows in the repository root's
273-
[`.github/workflows/`](./.github/workflows/), so a `ui/` change is checked by the same
273+
[workflow directory](./.github/workflows/), so a `ui/` change is checked by the same
274274
`ci.yml` as the rest of the repository: its `Lint UI`, `Type Check UI`, `Test UI` and
275275
`Build & E2E UI` jobs run when a pull request changes `ui/`. Read those jobs for what each one
276276
runs; `ui/` keeps no CI guide of its own.

‎ui/scripts/__tests__/doc-version-claims.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3036,7 +3036,7 @@ describe('doc version claims - the workflow-version assertion', () => {
30363036
workflowVersionChecks.reduce((n, check) => n + check.stated.length, 0),
30373037
'the workflow-version assertion compared no doc lines at all - the claim resolution ' +
30383038
'collapsed and it is now green over nothing',
3039-
).toBeGreaterThanOrEqual(3);
3039+
).toBeGreaterThanOrEqual(2); // 3 until objectstack#26944 deleted the CI guide page's entry
30403040

30413041
for (const check of workflowVersionChecks) {
30423042
expect(
@@ -3316,7 +3316,7 @@ describe('doc version claims - the workflow-version assertion', () => {
33163316
'no inventory entry carries workflowVersionKey - the workflow-anchored entries lost ' +
33173317
'the field and are back to being recorded rather than checked, which is the state ' +
33183318
'objectui#6400 found them in',
3319-
).toBeGreaterThanOrEqual(3);
3319+
).toBeGreaterThanOrEqual(2); // 3 until objectstack#26944 deleted the CI guide page's entry
33203320
});
33213321
});
33223322

‎ui/scripts/__tests__/markdown-test-inputs.test.ts‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,10 @@ describe('objectui#9096 — `scripts` is a scan root, and the class is now total
163163
// candidates at all, so a root that silently stopped resolving is caught.
164164
// 45 files the day the root landed; 38 once objectstack#26080 deleted the
165165
// tree's root README, ROADMAP.md and QUICK_REFERENCE.md, the literals
166-
// several of these tests only matched against those files.
167-
expect(fromScripts.length).toBeGreaterThanOrEqual(35);
166+
// several of these tests only matched against those files; 27 once
167+
// objectstack#26944 deleted objectui's CI guide page, the one document eight
168+
// more of them named.
169+
expect(fromScripts.length).toBeGreaterThanOrEqual(27);
168170
});
169171

170172
it('names the card\'s instance: three gate tests read `AGENTS.md`, so it is an input', () => {
@@ -292,7 +294,10 @@ describe('objectui#9142 — a root-level markdown file a pull request ADDS', ()
292294
const hits = markdownTestInputsAmong(['AGENTS.md']);
293295
expect(hits).toHaveLength(1);
294296
expect(hits[0].entries).toEqual(expect.arrayContaining(['./*', 'AGENTS.md']));
295-
expect(hits[0].readers.length).toBeGreaterThanOrEqual(4);
297+
// 3 since objectstack#26944: `check-required-check-set.test.ts` named
298+
// `AGENTS.md` only beside objectui's CI guide page, and left the ledger with
299+
// the page. Three readers still prove every one is reported, not the first.
300+
expect(hits[0].readers.length).toBeGreaterThanOrEqual(3);
296301
// The same overlap outside the root, which predates this card: a package
297302
// README declared exactly AND inside `packages/**`.
298303
const nested = markdownTestInputsAmong(['packages/app-shell/README.md']);

0 commit comments

Comments
 (0)