test(plugin-approvals, plugin-security, service-messaging): ask a pinyin-enabled registry about the search companion

The engine the tests boot builds its registry with the companion switched
off (it follows OS_SEARCH_PINYIN_ENABLED), so "no __search column" could
never fail there. The pin now registers each object in a registry built
with `searchCompanion: true` and asserts no companion field is provisioned.

Claude-Session: https://claude.ai/code/session_01Evb5jFDZGKQE9KG4jbMfMF
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

packages/plugins/plugin-approvals/src/sys-approval-delegation-display-title.test.ts

@@ -24,11 +24,13 @@
  *     here every title column is required);
  *  4. the formula reads exactly the columns `titleFormat` names, on this row
  *     only, each required and none withheld from a reader of the row;
- *  5. the formula adds no stored column.
+ *  5. the formula adds no stored column, and no search companion column
+ *     either — not even where pinyin search provisions one (a formula is
+ *     never a companion source).
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, resolveRecordTitle } from '@objectstack/objectql';
+import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { SysApprovalDelegation } from './sys-approval-delegation.object.js';
@@ -139,10 +141,20 @@ describe('[#20044] sys_approval_delegation resolves a real record title under AD
     }
   });
 
-  it('adds no stored column: the formula is computed on read, and no search companion appears', async () => {
+  it('adds no stored column: the formula is computed on read', async () => {
     const columns = Object.keys(await driver.getKnex()(OBJECT).columnInfo());
     expect(columns).toContain('delegator_id');
     expect(columns).not.toContain('display_title');
-    expect(columns).not.toContain('__search');
+  });
+
+  it('provisions no search companion column, even where pinyin search is on', () => {
+    // The companion (`__search`) is a real column fed by the title field; a
+    // registry only provisions it when pinyin search is enabled, so ask one
+    // that is. A formula title is never a companion source.
+    const companionRegistry = new SchemaRegistry({ searchCompanion: true });
+    companionRegistry.registerObject(SysApprovalDelegation as any, 'com.objectstack.test.20044');
+    const registered = companionRegistry.getObject(OBJECT) as any;
+    expect(registered.nameField).toBe('display_title');
+    expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
   });
 });

packages/plugins/plugin-security/src/objects/sys-security-assignment-display-title.test.ts

@@ -23,7 +23,9 @@
  *     server-side accessor (`resolveRecordTitle`) agrees;
  *  3. a row missing a title column is refused by the write path, so the
  *     formula never sees a NULL part;
- *  4. the formula adds no stored column.
+ *  4. the formula adds no stored column, and no search companion column
+ *     either — not even where pinyin search provisions one (a formula is
+ *     never a companion source).
  *
  * And, because these are permission-assignment tables, the property the new
  * field must not break: the formula reads exactly the columns `titleFormat`
@@ -35,7 +37,7 @@
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, resolveRecordTitle } from '@objectstack/objectql';
+import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { SysPositionPermissionSet } from './sys-position-permission-set.object.js';
@@ -178,11 +180,21 @@ describe('[#20044] permission-assignment tables resolve a real record title unde
       }
     });
 
-    it(`${object}: adds no stored column — the formula is computed on read, and no search companion appears`, async () => {
+    it(`${object}: adds no stored column — the formula is computed on read`, async () => {
       const columns = Object.keys(await driver.getKnex()(object).columnInfo());
       expect(columns).toContain(Object.keys(data)[0]);
       expect(columns).not.toContain('display_title');
-      expect(columns).not.toContain('__search');
+    });
+
+    it(`${object}: provisions no search companion column, even where pinyin search is on`, () => {
+      // The companion (`__search`) is a real column fed by the title field; a
+      // registry only provisions it when pinyin search is enabled, so ask one
+      // that is. A formula title is never a companion source.
+      const companionRegistry = new SchemaRegistry({ searchCompanion: true });
+      companionRegistry.registerObject(schema, 'com.objectstack.test.20044');
+      const registered = companionRegistry.getObject(object) as any;
+      expect(registered.nameField).toBe('display_title');
+      expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
     });
   }
 });

packages/services/service-messaging/src/objects/notification-display-title.test.ts

@@ -31,11 +31,13 @@
  *     write path refuses it, or fills the column's declared default;
  *  4. the formula reads exactly the columns `titleFormat` names, on this row
  *     only, each required and none withheld from a reader of the row;
- *  5. nothing adds a stored column — no formula column, no search companion.
+ *  5. nothing adds a stored column: no formula column, and no search
+ *     companion column even where pinyin search provisions one (a formula is
+ *     never a companion source, and a `select` is not title text).
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, resolveRecordTitle } from '@objectstack/objectql';
+import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { NotificationDelivery } from './notification-delivery.object.js';
@@ -224,11 +226,21 @@ describe('[#20044] notification objects resolve a real record title under ADR-00
       }
     });
 
-    it(`${object}: adds no stored column — no formula column and no search companion`, async () => {
+    it(`${object}: adds no stored column for the title`, async () => {
       const columns = Object.keys(await driver.getKnex()(object).columnInfo());
       expect(columns).toContain(titleFormatColumns(c.schema)[0]);
       expect(columns).not.toContain('display_title');
-      expect(columns).not.toContain('__search');
+    });
+
+    it(`${object}: provisions no search companion column, even where pinyin search is on`, () => {
+      // The companion (`__search`) is a real column fed by the title field; a
+      // registry only provisions it when pinyin search is enabled, so ask one
+      // that is.
+      const companionRegistry = new SchemaRegistry({ searchCompanion: true });
+      companionRegistry.registerObject(c.schema, 'com.objectstack.test.20044');
+      const registered = companionRegistry.getObject(object) as any;
+      expect(registered.nameField).toBe(c.pointer);
+      expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
     });
   }
 });