Repository navigation
Commit 71e3ae2
committed
fix(objectql)!: a
The aggregated row carries exactly the columns the query projects, so a
`having` key outside them read "no value" in every group: a typo for an
alias (`{ totl: { $gt: 100 } }`) kept no group, and a negated test on it
kept every group, with no error either way.
`assertHavingIsEvaluable` now judges every key, at any depth under
`$and` / `$or` / `$not`, against the same `aggregatedRowColumns` set the
`{ $field }` reference is judged against, once the rest of the clause has
passed, and refuses the unknown ones together (INVALID_FILTER / 400),
naming each, the first with its position, and listing the columns.
Claude-Session: https://claude.ai/code/session_01Bvd69VPa6puiNzzPUroDBx
Co-authored-by: Claude <noreply@anthropic.com>having key naming no column of the aggregated row is refused (#20123)1 parent 8662122 commit 71e3ae2
4 files changed
Lines changed: 172 additions & 7 deletions
File tree
- .changeset
- packages/objectql/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
667 | 667 | | |
668 | 668 | | |
669 | 669 | | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16070 | 16070 | | |
16071 | 16071 | | |
16072 | 16072 | | |
16073 | | - | |
| 16073 | + | |
| 16074 | + | |
| 16075 | + | |
| 16076 | + | |
16074 | 16077 | | |
16075 | 16078 | | |
16076 | 16079 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
417 | 454 | | |
418 | 455 | | |
419 | 456 | | |
| |||
496 | 533 | | |
497 | 534 | | |
498 | 535 | | |
499 | | - | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
500 | 544 | | |
501 | 545 | | |
502 | 546 | | |
503 | 547 | | |
504 | 548 | | |
505 | | - | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
506 | 552 | | |
507 | 553 | | |
508 | 554 | | |
| |||
537 | 583 | | |
538 | 584 | | |
539 | 585 | | |
540 | | - | |
| 586 | + | |
541 | 587 | | |
542 | 588 | | |
543 | 589 | | |
544 | 590 | | |
545 | | - | |
546 | | - | |
547 | | - | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
548 | 594 | | |
549 | 595 | | |
| 596 | + | |
| 597 | + | |
550 | 598 | | |
551 | 599 | | |
552 | 600 | | |
| |||
565 | 613 | | |
566 | 614 | | |
567 | 615 | | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
568 | 619 | | |
569 | 620 | | |
570 | 621 | | |
| |||
0 commit comments