Skip to content

Commit 68294cc

Browse files
committed
fix(spec): name the unreported non-legacy value and all three props-gate commands in the D3 entry and the pending note
Claude-Session: https://claude.ai/code/session_01CiCTczDo7tGhafXjf61dUJ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 930fae9 commit 68294cc

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

‎.changeset/17321-record-filter-d2-conversion.md‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ excludes every row for a rule array, so a rewrite there would empty the block. T
4848
on a block that queries an object converts. Such a page keeps loading and rendering unchanged,
4949
and its `filter` door refuses the form: at `dataSource.filter` on the page's next save; at a
5050
block's `properties.filter` / `properties.defaultFilters` only as the component-props gate's
51-
advisory finding (`os validate`) — a re-save through the metadata API is not refused there,
52-
measured — and for a combinator record that refusal no longer renders the combinator as a field
53-
(`{ field: '$or', … }`); it names the combinator and says why no rule spells it.
54-
`os migrate meta --stored` lists each filter left as stored as a TODO under its row.
51+
advisory finding (`os validate`, `os build`, `os lint`) — a re-save through the metadata API is
52+
not refused there, measured — and for a combinator record that refusal no longer renders the
53+
combinator as a field (`{ field: '$or', … }`); it names the combinator and says why no rule
54+
spells it.
55+
`os migrate meta --stored` lists each such filter left as stored as a TODO under its row.

‎packages/spec/src/migrations/entries/semantic/18.element-data-source-and-object-block-filter-rule-array.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,14 @@ export const entry: SemanticMigration = {
7979
+ 'contract), and its `filter` door refuses the form: at `dataSource.filter` on the page\'s '
8080
+ 'next save; at a block\'s `properties.filter` — like `properties.defaultFilters`, a key of '
8181
+ 'the open `properties` bag — only as the component-props gate\'s advisory finding '
82-
+ '(`os validate`), since a re-save through the metadata API is not refused there. For a '
83-
+ 'combinator record that refusal names the combinator and says why no rule spells it. '
84-
+ '`os migrate meta --stored` lists each filter left as stored as a TODO under its row, '
85-
+ 'naming the block and what blocks the rewrite; a row whose only finding is such a TODO is '
86-
+ 'reported `skipped`, and the run\'s exit code does not change for it.',
82+
+ '(os validate, os build, os lint), since a re-save through the metadata API is not '
83+
+ 'refused there. For a combinator record that refusal names the combinator and says why no '
84+
+ 'rule spells it. `os migrate meta --stored` lists each such filter as a TODO under its '
85+
+ 'row, naming the block and what blocks the rewrite (a value that is not a record or AST '
86+
+ 'form at all — a bare string or number one of the former `z.unknown()` doors took — is '
87+
+ 'neither converted nor reported, and a row carrying nothing else reads as already on '
88+
+ 'protocol); a row whose only finding is such a TODO is reported `skipped`, and the run\'s '
89+
+ 'exit code does not change for it.',
8790
acceptanceCriteria:
8891
'`ElementDataSourceSchema.safeParse({ object, filter: [{ field: \'status\', operator: '
8992
+ '\'equals\', value: \'active\' }] })` succeeds and the parsed `filter` is the same rule '

0 commit comments

Comments
 (0)