Skip to content

Commit 61d7caf

Browse files
committed
test(platform-objects): name the credential-param roster rows by action and param
Claude-Session: https://claude.ai/code/session_01G3YZBh5FVysqzzALckNTWy Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2d002ac commit 61d7caf

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

‎packages/platform-objects/src/platform-objects.test.ts‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -103,27 +103,27 @@ describe('@objectstack/platform-objects', () => {
103103
// readable on screen and in screenshots; `password` renders the masked
104104
// input. The roster pins each param by name; the sweep over every identity
105105
// object fails on a credential-named param added later as `text`.
106-
const roster: Array<[string, { name: string; actions?: readonly unknown[] }, string, string]> = [
107-
['SysUser', SysUser, 'create_user', 'password'],
108-
['SysUser', SysUser, 'set_user_password', 'newPassword'],
109-
['SysUser', SysUser, 'change_my_password', 'currentPassword'],
110-
['SysUser', SysUser, 'change_my_password', 'newPassword'],
111-
['SysUser', SysUser, 'delete_my_account', 'password'],
112-
['SysUser', SysUser, 'enable_two_factor', 'password'],
113-
['SysUser', SysUser, 'disable_two_factor', 'password'],
114-
['SysUser', SysUser, 'generate_backup_codes', 'password'],
115-
['SysTwoFactor', SysTwoFactor, 'enable_two_factor', 'password'],
116-
['SysTwoFactor', SysTwoFactor, 'disable_two_factor', 'password'],
117-
['SysTwoFactor', SysTwoFactor, 'regenerate_backup_codes', 'password'],
118-
['SysSsoProvider', SysSsoProvider, 'register_sso_provider', 'clientSecret'],
106+
const roster: Array<[string, string, string, { name: string; actions?: readonly unknown[] }]> = [
107+
['SysUser', 'create_user', 'password', SysUser],
108+
['SysUser', 'set_user_password', 'newPassword', SysUser],
109+
['SysUser', 'change_my_password', 'currentPassword', SysUser],
110+
['SysUser', 'change_my_password', 'newPassword', SysUser],
111+
['SysUser', 'delete_my_account', 'password', SysUser],
112+
['SysUser', 'enable_two_factor', 'password', SysUser],
113+
['SysUser', 'disable_two_factor', 'password', SysUser],
114+
['SysUser', 'generate_backup_codes', 'password', SysUser],
115+
['SysTwoFactor', 'enable_two_factor', 'password', SysTwoFactor],
116+
['SysTwoFactor', 'disable_two_factor', 'password', SysTwoFactor],
117+
['SysTwoFactor', 'regenerate_backup_codes', 'password', SysTwoFactor],
118+
['SysSsoProvider', 'register_sso_provider', 'clientSecret', SysSsoProvider],
119119
];
120120

121121
type Param = { name?: string; type?: string };
122122
type Action = { name?: string; params?: readonly Param[] };
123123
const actionsOf = (object: unknown): readonly Action[] =>
124124
((object as { actions?: readonly Action[] }).actions ?? []);
125125

126-
it.each(roster)('%s.%s#%s declares `password`', (_exportName, object, actionName, paramName) => {
126+
it.each(roster)('%s.%s#%s declares `password`', (_exportName, actionName, paramName, object) => {
127127
const action = actionsOf(object).find((a) => a.name === actionName);
128128
const param = (action?.params ?? []).find((p) => p.name === paramName);
129129
expect(param, `${object.name}.${actionName} must declare a '${paramName}' param`).toBeDefined();
@@ -148,7 +148,7 @@ describe('@objectstack/platform-objects', () => {
148148
}
149149
}
150150
// Positive control: the sweep reaches exactly the rostered params.
151-
expect(seen.sort()).toEqual(roster.map(([, o, a, p]) => `${o.name}.${a}#${p}`).sort());
151+
expect(seen.sort()).toEqual(roster.map(([, a, p, o]) => `${o.name}.${a}#${p}`).sort());
152152
expect(offenders).toEqual([]);
153153
});
154154
});

0 commit comments

Comments
 (0)