Skip to content

Commit 5a144ef

Browse files
committed
docs(observability,verify): re-anchor the dead tracker citations to the commits that decided them
Four comment lines in packages/observability/src and packages/verify/src cited tracker numbers that answer 404. Each now cites the commit in this repository's history that decided what the line describes: - observability semconv.ts: the transport-seam move of http_request_duration_ms -> commit 1e050a5 - verify harness.ts: the host importer's undeclared fallback resolving from the caller -> commit 46d34ab - verify erasure-transaction-authorization.test.ts (two lines): the /admin/remove-user shading that runs gateAdmin before the break-glass guard -> commit 6dd3e69 Comments only; every touched file keeps its line count. Claude-Session: https://claude.ai/code/session_01VvcEokUG1tvVxkceYfR5XB Co-authored-by: Claude <noreply@anthropic.com>
1 parent 22e584c commit 5a144ef

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎packages/observability/src/semconv.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const SEMCONV = {
4646
// status, elapsedMs}` and no throw signal at all.
4747
// ⇒ Read the 5xx rate from `http_requests_total{status=~"5.."}` instead.
4848
// The transport emits that family through the seam, so it covers every
49-
// inbound surface (#9650 / #9835 / #10004) and carries the status label
49+
// inbound surface (#9650 / #9835 / commit 1e050a5b1) and carries the status label
5050
// this counter only stood in for. Maintainer ruling 2026-08-20.
5151

5252
// ── Storage — emitted by `@objectstack/service-storage` adapters ──

‎packages/verify/src/erasure-transaction-authorization.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,11 @@ describe('#10792 — the erasure route answers authorization on a pool max=1 dia
160160
it('a signed-in plain member gets the AUTHORIZATION refusal, not 401', async () => {
161161
const answer = await fire('POST', '/auth/admin/remove-user', { userId: targets[2] }, memberToken);
162162
expect(answer.status, `member remove-user: ${answer.status} ${answer.body}`).toBe(403);
163-
// #11477 (maintainer-ruled option A): the route is now shaded by an
163+
// Commit 6dd3e6968 (maintainer-ruled option A): the route is now shaded by an
164164
// ObjectStack raw mount whose gateAdmin runs BEFORE the break-glass guard,
165165
// so the refusal a plain member hears is the gate's target-independent
166166
// PERMISSION_DENIED — no longer the vendor's
167-
// YOU_ARE_NOT_ALLOWED_TO_DELETE_USERS, which the pre-#11477 route only
167+
// YOU_ARE_NOT_ALLOWED_TO_DELETE_USERS, which the route before that commit only
168168
// reached after the guard had already answered. This pin's intent is
169169
// unchanged: the member hears an AUTHORIZATION verdict, and asserting the
170170
// code (not just the status) keeps a 403 from some unrelated layer from

‎packages/verify/src/harness.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ export async function bootStack(
577577
// booted multi-tenant off a hoisted copy — and the RLS posture a fixture
578578
// then asserted against depended on the launcher.
579579
//
580-
// #10943: the undeclared FALLBACK is this package's own resolution only if
580+
// Commit 46d34ab7c: the undeclared FALLBACK is this package's own resolution only if
581581
// this package supplies it. A bare `import()` written inside
582582
// `@objectstack/types` resolves against THAT package — which declares
583583
// `@objectstack/spec` and nothing else — so the helper's documented

0 commit comments

Comments
 (0)