Skip to content

Commit 4a1f38a

Browse files
hotlongclaude
andcommitted
docs(cloud-connection): re-anchor the dead tracker citations in packages/cloud-connection/src to the commits that decided them
Ten comment sites (five in marketplace-install-local-plugin.ts, five in two test files) cited three tracker numbers that no longer resolve. Each now cites the commit that decided what the line describes, in ruling C+D's form C: 01074e5 for the install-local listing's authenticated floor and field narrowing, b537855 for the /meta promotion verbs' manage_metadata gate, and 6a180e4 for re-raising a permission-store outage instead of reading it as "nobody is authenticated". Comment prose only: ten lines out, ten in, every file keeps its line count. Claude-Session: https://claude.ai/code/session_local_1d2a197c-c20e-4e90-9be8-413d4d432289 Co-authored-by: Claude <noreply@anthropic.com>
1 parent b291fcd commit 4a1f38a

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎packages/cloud-connection/src/marketplace-install-local-capability-enumeration.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
* ## Why an enumeration and not four more assertions
3939
*
40-
* The same reason as the `/meta` precedent (#8919,
40+
* The same reason as the `/meta` precedent (commit b5378550e,
4141
* `meta-write-door-capability-enumeration.test.ts`): a gate held by repetition
4242
* drifts the moment someone adds a fifth route by copying whichever neighbour
4343
* was nearest. `derives every mutating route the plugin mounts` builds the door
@@ -47,7 +47,7 @@
4747
* ⚠️ The `GET` listing is deliberately NOT in this family. It is a read, and
4848
* this card's ruling is about the four mutating doors; silently folding it in
4949
* here would have decided its posture by accident. That posture has since been
50-
* ruled on separately (#9011: authenticated floor, with `installedBy` and
50+
* ruled on separately (commit 01074e551: authenticated floor, with `installedBy` and
5151
* `storageDir` narrowed to `manage_metadata` holders) and is pinned in
5252
* `marketplace-install-local-list-posture.test.ts` — so the filter below still
5353
* means "not this family", never "ungated".
@@ -300,7 +300,7 @@ describe('#8976 — the mutating install-local doors are enumerated, not recited
300300
// Without this, a refactor that stopped mounting the GET would leave the
301301
// assertion above passing while silently proving less than it claims.
302302
// The listing's OWN posture lives in
303-
// `marketplace-install-local-list-posture.test.ts` (#9011); ⛔ the fix
303+
// `marketplace-install-local-list-posture.test.ts` (commit 01074e551); ⛔ the fix
304304
// for an unauthorized read there is a refusal, never an unmounted route
305305
// — cloud#1287 made this mount unconditional so air-gapped boxes stop
306306
// 404ing, and this assertion is what keeps that true.

‎packages/cloud-connection/src/marketplace-install-local-list-posture.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* [#9011] `GET /api/v1/marketplace/install-local` — the read door's posture.
4+
* [commit 01074e551] `GET /api/v1/marketplace/install-local` — the read door's posture.
55
*
66
* ## THIS is the file that answers "is the installed-apps LISTING gated?"
77
*
@@ -299,7 +299,7 @@ describe('#9011 — a `manage_metadata` holder still gets the full payload', ()
299299
expect(res.payload.data.storageDir).toBe(new LocalManifestSource(dir).dir);
300300
const [item] = res.payload.data.items;
301301
expect(item.installedBy).toBe('usr_operator');
302-
// The pre-#9011 wire shape, intact for the caller who is entitled to it.
302+
// The wire shape before commit 01074e551, intact for the caller who is entitled to it.
303303
expect(Object.keys(item).sort()).toEqual(
304304
['installedAt', 'installedBy', 'manifestId', 'packageId', 'version', 'versionId', 'withSampleData'],
305305
);

‎packages/cloud-connection/src/marketplace-install-local-plugin.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* → lists currently installed marketplace packages. Requires an
3333
* authenticated principal (anonymous → 401); `installedBy` and
3434
* `storageDir` are served only to a `manage_metadata` holder
35-
* (#9011). The four routes above require `manage_metadata`
35+
* (commit 01074e551). The four routes above require `manage_metadata`
3636
* outright (#8976).
3737
*
3838
* DELETE /api/v1/marketplace/install-local/:manifestId
@@ -95,7 +95,7 @@ const ROUTE_BASE = '/api/v1/marketplace/install-local';
9595
*
9696
* `manage_metadata` is ADR-0066 D1's authoring capability and the SAME key the
9797
* platform's other metadata-write doors already require — `PUT`/`DELETE`
98-
* `/api/v1/meta/:type/:name`, `POST /meta/_migrate-stored`, and since #8919 the
98+
* `/api/v1/meta/:type/:name`, `POST /meta/_migrate-stored`, and since commit b5378550e the
9999
* publish/rollback promotion verbs. These four routes are a metadata-write door
100100
* by every measure that matters: `POST` hot-registers an inline manifest's
101101
* objects into the shared registry and then runs `syncSchemas()` against the
@@ -998,7 +998,7 @@ export class MarketplaceInstallLocalPlugin implements Plugin {
998998
* short list was served with `success: true` and nobody, anywhere, could
999999
* have known.
10001000
*
1001-
* ## [#9011] Authenticated floor + field narrowing — the posture, ruled
1001+
* ## [commit 01074e551] Authenticated floor + field narrowing — the posture, ruled
10021002
*
10031003
* #8976 gated the four MUTATING doors and left this read as the only
10041004
* anonymous door on the surface: `handleList` opened on `this.readAll()`,
@@ -1810,15 +1810,15 @@ export class MarketplaceInstallLocalPlugin implements Plugin {
18101810
systemPermissions: Array.isArray(authz.systemPermissions) ? authz.systemPermissions : [],
18111811
};
18121812
} catch (err) {
1813-
// [#13279] `null` here means "nobody is authenticated", which is
1813+
// [commit 6a180e42d] `null` here means "nobody is authenticated", which is
18141814
// not what a permission-store outage established. Re-raised.
18151815
if (isAuthzStoreUnavailableError(err)) throw err;
18161816
return null;
18171817
}
18181818
};
18191819

18201820
/**
1821-
* [#9011] The ONE `401` this plugin issues — every door, one literal.
1821+
* [commit 01074e551] The ONE `401` this plugin issues — every door, one literal.
18221822
*
18231823
* The five routes now share an authenticated floor but NOT a capability
18241824
* requirement (the four writes demand `manage_metadata`; the read narrows

0 commit comments

Comments
 (0)