Skip to content

Commit 47cec88

Browse files
committed
fix(cli): the walled undeclared-position remedy names no catalog the code door contradicts; the uncomposed control pins only the pointer's absence
Patch round 1 of the seat's review. 'Declare the position NAME in the environment catalog ... through the deployment's code' said two opposite things: the environment catalog is the environment-authored items, and a code declaration is a package declaration. The sentence now reads 'Declare the position NAME with permissionSets naming SETS, through one door only: ...', in the source and in the changeset's TO line. The uncomposed-block walled control no longer pins an act for everyone: its fake catalog declares no everyone, while a composed boot declares it sealed. It asserts only that the pointer and the composition are gone. Claude-Session: https://claude.ai/code/session_01Q9PZ5Pzqcus4woVvTZwWNU Co-authored-by: Claude <noreply@anthropic.com>
1 parent cac34a8 commit 47cec88

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎.changeset/23542-walled-binding-remedy.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The blocker's first sentence is unchanged: "Binding rows give position NAME sets
1212

1313
- **A position no catalog declares.**
1414
- FROM: "The authored-conversion step carries them; resolve its blocker, then re-run."
15-
- TO: "Under the POSTURE posture no ceremony step carries binding rows (ADR-0131 D3). Declare the position NAME in the environment catalog with permissionSets naming SETS, through one door only: the deployment's code (compiled into the artifact this ceremony boots), or the metadata door as the platform administrator (PUT /api/v1/meta/position/NAME). A cold boot refuses a position name a package declares and the environment catalog also holds. Then re-run."
15+
- TO: "Under the POSTURE posture no ceremony step carries binding rows (ADR-0131 D3). Declare the position NAME with permissionSets naming SETS, through one door only: the deployment's code (compiled into the artifact this ceremony boots), or the metadata door as the platform administrator (PUT /api/v1/meta/position/NAME). A cold boot refuses a position name a package declares and the environment catalog also holds. Then re-run."
1616
- **A declared position the metadata door reports editable, whose definition lacks some of the bound sets.**
1717
- FROM: the same pointer.
1818
- TO: "Under the POSTURE posture no ceremony step carries binding rows (ADR-0131 D3). Add MISSING to the permissionSets of the position NAME through the metadata door as the platform administrator (PUT /api/v1/meta/position/NAME), then re-run."

‎packages/cli/src/utils/organization-ownership-apply.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2136,7 +2136,9 @@ describe('ADR-0131 D10 --apply — a name only the uncomposed security plugin de
21362136
`);
21372137
const rewrite = step(await apply(catalog(), ledger(), { posture: 'isolated', securityPlugin }), 'rewrite');
21382138
expect(blockerOf(rewrite, 'the permission set admin_full_access,')).toMatch(/or remove the grants/);
2139-
expect(blockerOf(rewrite, 'position everyone ')).toContain('PUT /api/v1/meta/position/everyone');
2139+
// Not the pointer. This fake catalog declares no `everyone` (a composed boot declares it, sealed), so which
2140+
// walled remedy follows is not this control's question.
2141+
expect(blockerOf(rewrite, 'position everyone ')).not.toMatch(/resolve its blocker/);
21402142
expect(rewrite.blockers.join('\n')).not.toContain(COMPOSITION);
21412143
});
21422144
});

‎packages/cli/src/utils/organization-ownership-apply.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2003,7 +2003,7 @@ async function walledBindingRemedy(run: Run, name: string, sets: readonly string
20032003
const entry = await resolveName(run, 'position', name);
20042004
if (!entry) {
20052005
return (
2006-
`${why} Declare the position ${name} in the environment catalog with permissionSets naming ${sets.join(', ')}, ` +
2006+
`${why} Declare the position ${name} with permissionSets naming ${sets.join(', ')}, ` +
20072007
`through one door only: the deployment's code (compiled into the artifact this ceremony boots), or ${door}. A ` +
20082008
'cold boot refuses a position name a package declares and the environment catalog also holds. Then re-run.'
20092009
);

0 commit comments

Comments
 (0)