Skip to content

Commit 473c6ff

Browse files
committed
fix(changeset,dogfood): the pre-mode parenthetical states the exited state, and the no-collision case carries its own positive control
Claude-Session: https://claude.ai/code/session_015mj2S1LnzLNur4rJeZuMbN Co-authored-by: Claude <noreply@anthropic.com>
1 parent 44da7fe commit 473c6ff

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎.changeset/24318-platform-objects-change-slug-to-cloud.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Clause-②: no (narrowing) (a platform object stops declaring an action whose do
1010

1111
The action now belongs to the composition that serves its route. That composition declares `change_slug` as a top-level action bound by `objectName: 'sys_organization'`, and the registry attaches such an action to the served object, whichever package registers first.
1212

13-
**BREAKING — what moves for consumers.** A declared action leaves a published platform object, shipped as `minor` under the launch-window convention for breaking changes (`.changeset/pre.json` is open in `next` pre mode).
13+
**BREAKING — what moves for consumers.** A declared action leaves a published platform object, shipped as `minor` under the launch-window convention for breaking changes (pre mode was exited at `c46b5f14cf`, so the launch-window guard is armed and a breaking change ships as `minor`).
1414

1515
- FROM: `GET /api/v1/meta/object/sys_organization` served `change_slug` on every composition, and the four generated locale bundles carried its `label`, `description` and `successMessage`.
1616
- TO: the object serves it only where a composition binds it. The open-source record header offers Invite User, Set Active and Rename Organization inline, and Leave Organization in the overflow; each of them is a better-auth door this composition mounts.

‎packages/qa/dogfood/test/org-change-slug-bound-action.dogfood.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ describe('a cloud-shaped composition binds change_slug to sys_organization, and
147147
});
148148

149149
it('the boot names no collision for it: the platform object declares no change_slug of its own', () => {
150-
expect(bootLines.some((line) => / WARN /.test(line))).toBe(true); // the capture saw the boot's warnings
150+
// Positive control: the capture saw the boot's own kernel log (the ObjectQL
151+
// plugin's lines), so an empty match below is a reading, not a dead spy.
152+
expect(bootLines.some((line) => line.includes('[ObjectQLPlugin]'))).toBe(true);
151153
expect(bootLines.filter((line) => line.includes("'change_slug'") && / (WARN|ERROR) /.test(line))).toEqual([]);
152154
});
153155
});

0 commit comments

Comments
 (0)