Skip to content

Commit 4475469

Browse files
committed
test(platform-objects): catalog count pins follow the options repeater's kind row
Claude-Session: https://claude.ai/code/session_017qmjVjz61scwQFLfspdBX6 Co-authored-by: Claude <noreply@anthropic.com>
1 parent ec9f775 commit 4475469

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎packages/platform-objects/src/apps/translations/field-panel-echo-decisions.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,10 @@ describe('#19403 round 4 — the blind spot, FOURTH shape: a type-level coverage
673673
// `width`, `defaultHidden`), all twelve of their translated labels
674674
// authored by the same flight, so the loop below still reads every one of
675675
// them translated.
676-
expect(ROW_PROPERTIES.length).toBe(10);
676+
//
677+
// 11 since #23809: the `options` repeater gained `kind`, the option's
678+
// lifecycle category, its label authored in all three locales.
679+
expect(ROW_PROPERTIES.length).toBe(11);
677680
expect(ROW_PROPERTIES).toContain('options.color');
678681
expect(ROW_PROPERTIES).toContain('options.visibleWhen');
679682
expect(ROW_PROPERTIES).toContain('inlineColumns.defaultHidden');

‎packages/platform-objects/src/apps/translations/object-collapsed-sections-echo-decisions.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,10 @@ describe('#19403 round 8 — the population, DERIVED from the form and a shape',
965965
// 116 since #21765 gave `basics` the `imageField` row beside `nameField` —
966966
// the record-picture pointer, now live — whose label and help text are
967967
// authored in all three locales by that card, so `openEchoes` stays at zero.
968-
expect(OPEN_LEAVES.length).toBe(116);
968+
// 118 since #23809 gave the field rows' `options` repeater its `kind`
969+
// sub-row (the option's lifecycle category) — label and help text, both
970+
// authored in all three locales, so `openEchoes` stays at zero.
971+
expect(OPEN_LEAVES.length).toBe(118);
969972
expect(PANEL_LEAVES.some((l) => l.path === 'fields.placeholder')).toBe(false);
970973
expect(OPEN_LEAVES.some((l) => l.path === 'fields.placeholder')).toBe(true);
971974
for (const path of ['name', 'label', 'fields', 'fields.valueDomain', 'fields.deleteBehavior', 'fields.expression']) {

‎packages/platform-objects/src/apps/translations/object-lifecycle-panel-echo-decisions.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1196,7 +1196,10 @@ describe('#19403 round 10 — the verdicts, on the live bundles', () => {
11961196
// 672 since the field form offers the `referenceDeletedWhen` composite
11971197
// beside `referenceVia`, with its `field` and `value` sub-rows — three new
11981198
// row labels, authored in all three locales.
1199-
expect(translated.length, `${locale} positive control`).toBe(672);
1199+
// 674 since #23809: the options repeaters gain `kind`, the option's
1200+
// lifecycle category — one row label on the field form, one on the
1201+
// object form, authored in all three locales.
1202+
expect(translated.length, `${locale} positive control`).toBe(674);
12001203
}
12011204
// ⭐ DARK — the blindness, executable. On a synthetic two-locale catalog the
12021205
// all-three predicate returns 0 while the per-locale one returns 1, so the

0 commit comments

Comments
 (0)