Skip to content

Commit 43782da

Browse files
committed
test(lint): the retired-key pin binds a value provider, not the retired view-level api provider
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
1 parent 69ae4c4 commit 43782da

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.changeset/24728-filterable-fields-residue.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ fix(lint)!: `os lint` and the react-page props check report the retired list-vie
88

99
Clause-②: yes (narrowing)
1010

11-
<!-- adr-0087: not-required (already-registered view-list-filterable-fields-removed, list-view-filterable-fields-retired) The key's retirement, its D2 conversion and its D3 entry are already registered by the change that tombstoned it, in this same unreleased major. This change adds no key, conversion or stored shape: it makes `os lint` and the react-page props check give the verdict `os validate` and `os build` already give the list-view key, with the tombstone's own prescription. -->
11+
<!-- adr-0087: not-required (already-registered view-list-filterable-fields-removed, list-view-filterable-fields-retired) The key's retirement, its D2 conversion and its D3 entry are already registered by the change that tombstoned it, which shipped in 18.0.0. This change adds no key, conversion or stored shape: it makes `os lint` and the react-page props check give the verdict `os validate` and `os build` already give the list-view key, with the tombstone's own prescription. -->
1212

1313
**BREAKING** (an authoring narrowing), shipped as `minor` under the launch-window convention for breaking changes.
1414

‎packages/lint/src/list-view-filterable-fields-retired.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ describe('the list view\'s retired `filterableFields` is reported by name, never
112112
stackWithList(listWith({ data: { provider: 'object', object: 'no_such_object' }, filterableFields: ['x'] })),
113113
);
114114
expect(retiredOf(unbound)).toHaveLength(1);
115-
const api = validateListViewFieldRefs(
116-
stackWithList(listWith({ data: { provider: 'api', read: { url: '/x' } }, filterableFields: ['x'] })),
115+
const inline = validateListViewFieldRefs(
116+
stackWithList(listWith({ data: { provider: 'value', items: [] }, filterableFields: ['x'] })),
117117
);
118-
expect(retiredOf(api)).toHaveLength(1);
118+
expect(retiredOf(inline)).toHaveLength(1);
119119
const noObjects = validateListViewFieldRefs(stackWithList(listWith({ filterableFields: ['x'] }), []));
120120
expect(retiredOf(noObjects)).toHaveLength(1);
121121
});

0 commit comments

Comments
 (0)